Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Oct 2022 14:56:00 +0200
From:   Johan Hovold <johan@kernel.org>
To:     Sudeep Holla <sudeep.holla@arm.com>
Cc:     Johan Hovold <johan+linaro@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware/psci: demote suspend-mode warning to debug level
Message-ID: <Y1fc4FQ8WKnFb5my@hovoldconsulting.com>
References: <20221024143417.11463-1-johan+linaro@kernel.org>
 <20221025115355.26zrhmaudigumivn@bogus>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221025115355.26zrhmaudigumivn@bogus>
Precedence: bulk

On Tue, Oct 25, 2022 at 12:53:55PM +0100, Sudeep Holla wrote:
> On Mon, Oct 24, 2022 at 04:34:17PM +0200, Johan Hovold wrote:
> > On some Qualcomm platform, like SC8280XP, the attempt to set PC mode
> > during boot fails with PSCI_RET_DENIED and since commit 998fcd001feb
> > ("firmware/psci: Print a warning if PSCI doesn't accept PC mode") this
> > is now logged at warning level:
> >
> > 	psci: failed to set PC mode: -3
> >
> > As there is nothing users can do about the firmware behaving this way,
> > demote the warning to debug level.
> >
> 
> As mentioned in the other thread I prefer to keep this as error as we
> shouldn't mask this error and enable more/newer platforms to ignore it
> when they can go and fix it. So I don't agree with this.

But now every owner of an X13s laptop will see this not very informative
error at every boot and wonder what it means. Has something gone broken?
Should they be worried? Can something be done about it?

Remember that this is firmware used by Windows machines so by the time
we see this in Linux it's probably way too late to fix in firmware
anyway.

Johan