Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Oct 2022 15:52:32 +0300
From:   Vadym Kochan <vadym.kochan@plvision.eu>
Subject: Re: [PATCH v4 1/2] dt-bindings: mtd: marvell-nand: Convert to YAML DT
 scheme
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Gregory Clement <gregory.clement@bootlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc:     Elad Nachman <enachman@marvell.com>,
        Chris Packham <chris.packham@alliedtelesis.co.nz>
In-Reply-To: <a980821f-9177-8eb7-ee36-1b1e614d30fc@linaro.org>
References: <20221025101713.11893-1-vadym.kochan@plvision.eu>
        <20221025101713.11893-2-vadym.kochan@plvision.eu>
        <a980821f-9177-8eb7-ee36-1b1e614d30fc@linaro.org>
Content-Type: text/plain
Message-ID: <VI1P190MB0317E39BD8D5531F94EB185C95319@VI1P190MB0317.EURP190.PROD.OUTLOOK.COM>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?j4914nMVfcJVUZC5EanCXMG162GezQxCeNBW2XU7zmtiihzIWAB1q3b4W4ap?=
 =?us-ascii?Q?TdRf3rbOVZIG08akY7f3HkvFc2yoA7EZUHoU4snl4R2PDeQvdz38w3Aq5PZJ?=
 =?us-ascii?Q?e6pclvLPthhwpAas6uUbB+kqwRKuEPqHYhYD4598iv7Eqjm49dAhqEoEjU7Z?=
 =?us-ascii?Q?++JCka1Z0zoTG1p/Sva1CN4Pdx+4u6feuDjufxPRrHgZR7y48a3AEJIBDgXj?=
 =?us-ascii?Q?R6ZydhlYB2nW9UBZ66s13tJpKBSJQ0szCZvLcivGj2tSt/DPZ4Y1NLWIwy7m?=
 =?us-ascii?Q?li6q9mzqUIaww0eycioIhGM8VUTGcFQP7qEl7iwl4qW31SLR9IqhTFZz5Yau?=
 =?us-ascii?Q?IrPeXoRHJTtrTHpDqAdaXmy23GUFHvvYidiuQY6Rh8mB8KrdQbdY4Zyrxh6u?=
 =?us-ascii?Q?PIKTHxq37D9R3dsmQ0f3NyXhLFWFlmDdrfjMeWdqUJQzrr437P6ogiKortAW?=
 =?us-ascii?Q?ze3ZnTdICmph93p0H6kyCS2hz2lSMygoESqvcGmFDJsSOCgCv8ZHi3uBz+0j?=
 =?us-ascii?Q?e7ylpUIuIC9VGgu0RNtJe2rC1uHVjbJjsz1mGBUezw5Kweq5pjGYGyhIvRqN?=
 =?us-ascii?Q?XKXp3RPtKj4UySYSq1/mmL5TNNnhkkFwQhbCe7pZMHonPBA1EFbgTDP9b2lG?=
 =?us-ascii?Q?mzxJlRIMQDYXIgS4c3zz0dpLd3AW4jr/sXVoTiDXSOYrPONiquLxsGmurylW?=
 =?us-ascii?Q?5SYl7a48cUCVo7S6BF+EQa9H5MSlPB0tGzQz+HOI7xVvt8lHvMuuCMgfcIHo?=
 =?us-ascii?Q?p4rfCHQCke1ktORfArwMNzcNt6cdiNH6s2BWBlff7SQ5ak0OJI3E2cDBUPvI?=
 =?us-ascii?Q?Xpt75Z7/PCntD3o9Fg96f96lO8J4ZMia73FNaMAEgzReOPCabst/nbxA7E2F?=
 =?us-ascii?Q?x4itTG/zJodMG5gmF5fCsUHEXWRQeHhUjaMihmGRyZ5GI4h3ZdHswzZceHuI?=
 =?us-ascii?Q?uQ/nyS0bVJsbo4jaCg0wIAuaeNGvB+zheGyRXdc6num4S8DLZF8qWyLHXoB8?=
 =?us-ascii?Q?EipFB+XZTja4Xjpk3wr0K/6/96UpBw9IVOYF6HnHa3j1rWFSuyOEAwmGBL/D?=
 =?us-ascii?Q?DWk2szlY8GAHsHiSbm+w7VdbRN9/OL83HSjgG1Hgnggm6hOVovHQ/nJAivoc?=
 =?us-ascii?Q?UqYz3PV9iiB08Y/XSOPIbGT0tX6VOBch29tTBySNzj6fBVrloedrK8XJgNxu?=
 =?us-ascii?Q?lV8/SRCiVDfNe+QwXHoJubx4rnzyZZyv2JkdEvfxkBM9DJ9sZgEYpEWm8/Yk?=
 =?us-ascii?Q?E+ldJ8lSyPTJxde48c1UdEpAhjeD3soqmdXU7kCjylv+tltdCT4BNW4jELzw?=
 =?us-ascii?Q?KxRc2fN1gV7emGIi7o0yap/1d0IMUVQgmjC04T7kj8AzBkFFqCmrYm+X/1/o?=
 =?us-ascii?Q?ANirR2LklwwzSSkNY/Zr1U5OQVd5R6FHoOiTsK6PLwkIwcmFwVkd8sA9hl7o?=
 =?us-ascii?Q?UJgAiEg3jQ22StY3yUAYdAXPt2b3pdbDvAoPyYz5IkrI57P3F5M2pdgpCqqn?=
 =?us-ascii?Q?qYREQc/mdLZTAUtcVLBvbZPMDnI45KCc3tTZ0er9ZtMN68xGxAqUQy4lIsjB?=
 =?us-ascii?Q?m30voiqwXAzlLKzl9XKARQGO23TOBWGpMLVZd6ilLQGjrfV0Y2DNNYhS6/yb?=
 =?us-ascii?Q?Dw=3D=3D?=
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f740423-ffe3-4830-6856-08dab687c93e
X-MS-Exchange-CrossTenant-AuthSource: VI1P190MB0317.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 12:52:34.0746
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G077uKCh0if43lOrkd+vvIYrBkgZ/Nb939s0LkQ3n7aHGXvYoKlwImH4il5m0+XH+fF19MZpx05fdt6NVDdbJWFhuP9t/TL3enpEAFscbTs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1P190MB1725
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 25 Oct 2022 08:25:01 -0400, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 25/10/2022 06:17, Vadym Kochan wrote:
> > Switch the DT binding to a YAML schema to enable the DT validation.
> > 
> > Dropped deprecated compatibles and properties described in txt file.
> > 
> > Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>
> > ---
> > 
> > v4:
> >    1) Remove "label" and "partitions" properties
> 
> I think you did not read the feedback.
> 
> 
> (...)
> 
> > +
> > +  marvell,system-controller:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +    description: Syscon node that handles NAND controller related registers
> > +
> > +patternProperties:
> > +  "^nand@[0-3]$":
> > +    type: object
> > +    properties:
> > +      reg:
> > +        minimum: 0
> > +        maximum: 3
> > +
> > +      nand-rb:
> > +        minimum: 0
> > +        maximum: 1
> > +
> > +      nand-ecc-strength:
> > +        enum: [1, 4, 8]
> > +
> > +      nand-on-flash-bbt: true
> > +
> > +      nand-ecc-mode: true
> > +
> > +      nand-ecc-algo:
> > +        description: |
> > +          This property is essentially useful when not using hardware ECC.
> > +          Howerver, it may be added when using hardware ECC for clarification
> > +          but will be ignored by the driver because ECC mode is chosen depending
> > +          on the page size and the strength required by the NAND chip.
> > +          This value may be overwritten with nand-ecc-strength property.
> > +
> > +      nand-ecc-step-size:
> > +        description: |
> > +          Marvell's NAND flash controller does use fixed strength
> > +          (1-bit for Hamming, 16-bit for BCH), so the actual step size
> > +          will shrink or grow in order to fit the required strength.
> > +          Step sizes are not completely random for all and follow certain
> > +          patterns described in AN-379, "Marvell SoC NFC ECC".
> > +
> > +      marvell,nand-keep-config:
> > +        description: |
> > +          Orders the driver not to take the timings from the core and
> > +          leaving them completely untouched. Bootloader timings will then
> > +          be used.
> > +        $ref: /schemas/types.yaml#/definitions/flag
> > +
> > +      marvell,nand-enable-arbiter:
> > +        description: |
> > +          To enable the arbiter, all boards blindly used it,
> > +          this bit was set by the bootloader for many boards and even if
> > +          it is marked reserved in several datasheets, it might be needed to set
> > +          it (otherwise it is harmless) so whether or not this property is set,
> > +          the bit is selected by the driver.
> > +        $ref: /schemas/types.yaml#/definitions/flag
> > +        deprecated: true
> > +
> > +    required:
> > +      - reg
> > +      - nand-rb
> 
> I have no clue why you are doing some random changes. Now you dropped
> additionalProperties for nand@ about which no one asked you to drop.
> 
> No. It *must* be here.

Sorry for this mess, I was confused with the "label" and "partitions"
because I got errors about these properties when I used only
"additionalProperties: false", so I tried to put reference to partition.yaml.

Then I looked at other nand-controllers schemas and I did not find inclusion of partition.yaml
for them so I decided to just drop it at all. My understanding is that "additionalProperties:false"
is needed for nand@ if to have "label" and "partitions" properties, otherwise it is not needed.

> 
> Best regards,
> Krzysztof
>