Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Oct 2022 17:05:16 +0200
From:   Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To:     Jernej Skrabec <jernej.skrabec@gmail.com>
Cc:     mripard@kernel.org, mchehab@kernel.org, gregkh@linuxfoundation.org,
        wens@csie.org, samuel@sholland.org, hverkuil-cisco@xs4all.nl,
        linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/11] media: cedrus: prefer untiled capture format
Message-ID: <Y1f7LCVwRgT9FHDe@aptenodytes>
References: <20221024201515.34129-1-jernej.skrabec@gmail.com>
 <20221024201515.34129-9-jernej.skrabec@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="w+BAvZwxLTv8gd/o"
Content-Disposition: inline
In-Reply-To: <20221024201515.34129-9-jernej.skrabec@gmail.com>
Precedence: bulk


--w+BAvZwxLTv8gd/o
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Jernej,

On Mon 24 Oct 22, 22:15, Jernej Skrabec wrote:
> While all generations of display engine on Allwinner SoCs support
> untiled format, only first generation supports tiled format.  Let's
> move untiled format up, so it can be picked before tiled one. If
> Cedrus variant doesn't support untiled format, tiled will still be
> picked as default format.

Makes sense to me. Of course the order shouldn't matter to smart-enough
userspace but it doesn't hurt to serve the most generic case first.

Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Cheers,

Paul

> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> ---
>  drivers/staging/media/sunxi/cedrus/cedrus_video.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/=
staging/media/sunxi/cedrus/cedrus_video.c
> index 3591bf9d7d9c..f9f723ea3f79 100644
> --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> @@ -56,13 +56,13 @@ static struct cedrus_format cedrus_formats[] =3D {
>  		.capabilities	=3D CEDRUS_CAPABILITY_VP8_DEC,
>  	},
>  	{
> -		.pixelformat	=3D V4L2_PIX_FMT_NV12_32L32,
> +		.pixelformat	=3D V4L2_PIX_FMT_NV12,
>  		.directions	=3D CEDRUS_DECODE_DST,
> +		.capabilities	=3D CEDRUS_CAPABILITY_UNTILED,
>  	},
>  	{
> -		.pixelformat	=3D V4L2_PIX_FMT_NV12,
> +		.pixelformat	=3D V4L2_PIX_FMT_NV12_32L32,
>  		.directions	=3D CEDRUS_DECODE_DST,
> -		.capabilities	=3D CEDRUS_CAPABILITY_UNTILED,
>  	},
>  };
> =20
> --=20
> 2.38.1
>=20

--=20
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

--w+BAvZwxLTv8gd/o
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmNX+ywACgkQ3cLmz3+f
v9FCUwf/V3Ng/xfoDLZGeEjzDHQU3ZtEXX1RMo0WULubg8BMamTlPR4tbDQTBW56
ipFZ0EtzlcdwnQHAhA+3HAu6CTfp+MwxLeeWEr4luVFSX+LuMU22Mclz9Ji7/vwh
OMcQ5fcCJDrYZE0Lc6Y6EzQozjt9q/m7dNG2joUKQzm9Futr6RTUOjUvZ5RgrR3q
8HMZKxxnVxgirPAIMl1h0y57hKWx+C/0L/TGrDeEzjcNxoZYcBuXCUNhdl9lXMFY
MNQq430Jsb4LYuu3bTjtDXYRBGGHOwyjrNsyhWtM8/djejO+FiP48NLQtbL72cIK
CT9U2hRl24cMNSB5oe2ZTZ4pmnGoqw==
=UyBL
-----END PGP SIGNATURE-----

--w+BAvZwxLTv8gd/o--