Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp8682126rwi; Tue, 25 Oct 2022 09:31:07 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5BLWnr9Pe9NgJWGBvuhL+rtmuMFKxSU/gdz078PuMlww6k8E+KWbRAAEZBP927IZBPHY80 X-Received: by 2002:a17:907:7f92:b0:78d:ed9c:d86f with SMTP id qk18-20020a1709077f9200b0078ded9cd86fmr33356988ejc.251.1666715467239; Tue, 25 Oct 2022 09:31:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666715467; cv=none; d=google.com; s=arc-20160816; b=Q3gF0RhuVj4UcS8k7Xdhi0Oq1BnGjyyRAt2acp6mQvKG5udP5YfeUSeBvJrq3Mpn9o Fxn+li+3YcheLB98jYQ95pB/mZX9t5a6VMnPJfeoLXv6LpB84mec8q0a4jSz4fpDzDte nTeRQIiH9K4mMaPG4b5HsIVF2cgx9tYnorn0/swq1rqOIbuvBEJVG2Qj6YTmdwm+DObJ ZyOtSM/9tNJaC8wybyRrmIJPMPF9uVWTUxHAJ+l9Nw4mdxwmg+P7qPia33edIdQ+nUkT XgJfRydZ215ljM3hWupXIt4w2hjPTgeu83J0UBggF7fyLCyi7FOJNXCXl17BhOKl1j2U 25nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:in-reply-to :from:references:cc:to:content-language:user-agent:mime-version:date :message-id:dkim-signature; bh=f8Du+MtqcshkZAivSawu/fPBgzGqyOuTUC9w0UwA0us=; b=NOLv2ia+TNNH0QahaT01GeLMwb2xAcgmvfLylv5GAIfGRYXQyD0x8u+BiiN8GfuuxI IRBp7xkYDqvK4WOvH8XnLUJEoaDKyteKHY2RM3RyM0FwLz6Kdt5x9WTs3RN30VLdRMa2 33qVLe1lXxv/0p32WfBZcC660CarbvyKqzF93FDaPHV7T0rkEi/zsH2niDO9SEm18soM Tl69cmCLxDO9WLKYrOjh6WV0aA5f/TYo207jmrvOaWoK0ALw3BEnKztewTUlCiEMkH1I 2zTGvsODTdkXhfYxMMgsnkPMMwlt8QLARPMIZz6RqFteX1d8uf5TvO4qWJ6xrcCfBEjc hiLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@deltatee.com header.s=20200525 header.b=ma12HTv0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=deltatee.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l12-20020a170906230c00b0078e1206d934si3007392eja.162.2022.10.25.09.30.39; Tue, 25 Oct 2022 09:31:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@deltatee.com header.s=20200525 header.b=ma12HTv0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=deltatee.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231742AbiJYPhp (ORCPT + 99 others); Tue, 25 Oct 2022 11:37:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232308AbiJYPhm (ORCPT ); Tue, 25 Oct 2022 11:37:42 -0400 Received: from ale.deltatee.com (ale.deltatee.com [204.191.154.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3D9ED8EF5; Tue, 25 Oct 2022 08:37:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:In-Reply-To:From:References:Cc:To: MIME-Version:Date:Message-ID:content-disposition; bh=f8Du+MtqcshkZAivSawu/fPBgzGqyOuTUC9w0UwA0us=; b=ma12HTv07ZvN/PMtXNYq8f4UVE tKXtoxcuzCMVqGLKjEXOj7DMUtJYVGj5+rPki6TxyFFCVpP46hxCji5pMn3E9YHtuuherZrziOpaW DH0G+ZZM5c5NQTW5Y3uRl0wIvA6qiQ3zQt6Bx/ixCGbeutwRoUdLhsNp/QeIQf9DclGpoHLHCPx8b VQ9U8Qs3jUiMZU1aWJnEuAT1K3GPkZ2M0LwAwXaBbiCoSJYnesVrmxPgqhLBib86Lqx3YeRc/zDAW IYZAXgSHru2stPrxuF0ZSV1HZTm4k6O75N1xXS/uIro7syUZ3yRkEPuMD0oloe6g8+dQEHQ9Ln/8G kHBW5WdA==; Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1onLzk-00H0S9-TU; Tue, 25 Oct 2022 09:37:37 -0600 Message-ID: <458b5dce-e130-6608-119a-63ccf6bd1eae@deltatee.com> Date: Tue, 25 Oct 2022 09:37:35 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Content-Language: en-CA To: Chaitanya Kulkarni , "linux-kernel@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-mm@kvack.org" Cc: Christoph Hellwig , Greg Kroah-Hartman , Dan Williams , Jason Gunthorpe , =?UTF-8?Q?Christian_K=c3=b6nig?= , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy , Martin Oliveira , Chaitanya Kulkarni , Ralph Campbell , Stephen Bates References: <20221021174116.7200-1-logang@deltatee.com> <20221021174116.7200-7-logang@deltatee.com> From: Logan Gunthorpe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: chaitanyak@nvidia.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, hch@lst.de, gregkh@linuxfoundation.org, dan.j.williams@intel.com, jgg@ziepe.ca, christian.koenig@amd.com, jhubbard@nvidia.com, ddutile@redhat.com, willy@infradead.org, daniel.vetter@ffwll.ch, dave.b.minturn@intel.com, jason@jlekstrand.net, dave.hansen@linux.intel.com, jianxin.xiong@intel.com, helgaas@kernel.org, ira.weiny@intel.com, robin.murphy@arm.com, martin.oliveira@eideticom.com, ckulkarnilinux@gmail.com, rcampbell@nvidia.com, sbates@raithlin.com X-SA-Exim-Mail-From: logang@deltatee.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Subject: Re: [PATCH v11 6/9] block: set FOLL_PCI_P2PDMA in __bio_iov_iter_get_pages() X-SA-Exim-Version: 4.2.1 (built Sat, 13 Feb 2021 17:57:42 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-10-24 19:23, Chaitanya Kulkarni wrote: > /* >> * Each segment in the iov is required to be a block size multiple. >> * However, we may not be able to get the entire segment if it spans >> @@ -1217,8 +1221,9 @@ static int __bio_iov_iter_get_pages(struct bio *bio, struct iov_iter *iter) >> * result to ensure the bio's total size is correct. The remainder of >> * the iov data will be picked up in the next bio iteration. >> */ >> - size = iov_iter_get_pages2(iter, pages, UINT_MAX - bio->bi_iter.bi_size, >> - nr_pages, &offset); >> + size = iov_iter_get_pages(iter, pages, >> + UINT_MAX - bio->bi_iter.bi_size, >> + nr_pages, &offset, gup_flags); > > nit, 3rd param in above call fits on the first line ? plz check :- > > iov_iter_get_pages(iter, pages, UINT_MAX - bio->bi_iter.bi_size, > nr_pages, &offset, gup_flags); Oh, yup, this just fits. I'll queue up the fix for if I send v12. Logan