Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Oct 2022 18:20:39 +0200
From:   Claudio Imbrenda <imbrenda@linux.ibm.com>
To:     Pierre Morel <pmorel@linux.ibm.com>
Cc:     David Hildenbrand <david@redhat.com>, kvm@vger.kernel.org,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        borntraeger@de.ibm.com, frankja@linux.ibm.com, cohuck@redhat.com,
        thuth@redhat.com, hca@linux.ibm.com, gor@linux.ibm.com,
        svens@linux.ibm.com
Subject: Re: [PATCH v2 1/1] KVM: s390: vsie: clarifications on setting the
 APCB
Message-ID: <20221025182039.6dc82fbf@p-imbrenda>
In-Reply-To: <0117e263-2856-b2fd-1e61-59b21e5da2e5@linux.ibm.com>
References: <20221025091319.37110-1-pmorel@linux.ibm.com>
        <20221025091319.37110-2-pmorel@linux.ibm.com>
        <e9a237d7-3a34-11c8-1c5b-1a3c14e8cfb0@redhat.com>
        <0117e263-2856-b2fd-1e61-59b21e5da2e5@linux.ibm.com>
Organization: IBM
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 25 Oct 2022 15:17:36 +0200
Pierre Morel <pmorel@linux.ibm.com> wrote:

> On 10/25/22 11:30, David Hildenbrand wrote:
> > On 25.10.22 11:13, Pierre Morel wrote:  
> >> The APCB is part of the CRYCB.
> >> The calculation of the APCB origin can be done by adding
> >> the APCB offset to the CRYCB origin.
> >>
> >> Current code makes confusing transformations, converting
> >> the CRYCB origin to a pointer to calculate the APCB origin.
> >>  
> > 
> > 
> > While at it, can we rename "crycb_o" to "crycb_gpa" and "apcb_o" to 
> > "apcb_gpa".
> > 
> > These are not pointers but guest physical addresses.
> >   
> 
> I can do that.
> the _o came from the name in the documentation "origin"
> but gpa is more obvious.
> 

with that fixed: 

Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>