Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Oct 2022 21:54:21 +0300
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     Ricardo Ribalda <ribalda@chromium.org>
Cc:     Pedro Guilherme Siqueira Moreira 
        <pedro.guilherme@espectro.eng.br>, mchehab@kernel.org,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] media: uvc_driver: fix assignment inside if
 condition
Message-ID: <Y1gw3cppUIBIbK34@pendragon.ideasonboard.com>
References: <20221025050450.1743072-1-pedro.guilherme@espectro.eng.br>
 <20221025050450.1743072-2-pedro.guilherme@espectro.eng.br>
 <CANiDSCs1pQEq73=vuNR9gymLMZFDkS3acDXRPNT=hc=eEvLzSA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CANiDSCs1pQEq73=vuNR9gymLMZFDkS3acDXRPNT=hc=eEvLzSA@mail.gmail.com>
Precedence: bulk

On Tue, Oct 25, 2022 at 10:45:40AM +0200, Ricardo Ribalda wrote:
> On Tue, 25 Oct 2022 at 07:08, Pedro Guilherme Siqueira Moreira
> <pedro.guilherme@espectro.eng.br> wrote:
> >
> > Fixes 'do not use assignment in if condition' errors issued by
> > scripts/checkpatch.pl on drivers/media/usb/uvc/uvc_driver.c
> >
> > Signed-off-by: Pedro Guilherme Siqueira Moreira <pedro.guilherme@espectro.eng.br>
>
> Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>

Likewise, this looks good to me.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> > ---
> >  drivers/media/usb/uvc/uvc_driver.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> > index b591ad823c66..7b6c97ad3a41 100644
> > --- a/drivers/media/usb/uvc/uvc_driver.c
> > +++ b/drivers/media/usb/uvc/uvc_driver.c
> > @@ -1174,7 +1174,8 @@ static int uvc_parse_control(struct uvc_device *dev)
> >                     buffer[1] != USB_DT_CS_INTERFACE)
> >                         goto next_descriptor;
> >
> > -               if ((ret = uvc_parse_standard_control(dev, buffer, buflen)) < 0)
> > +               ret = uvc_parse_standard_control(dev, buffer, buflen);
> > +               if (ret < 0)
> >                         return ret;
> >
> >  next_descriptor:
> > @@ -2213,7 +2214,8 @@ static int uvc_probe(struct usb_interface *intf,
> >         usb_set_intfdata(intf, dev);
> >
> >         /* Initialize the interrupt URB. */
> > -       if ((ret = uvc_status_init(dev)) < 0) {
> > +       ret = uvc_status_init(dev);
> > +       if (ret < 0) {
> >                 dev_info(&dev->udev->dev,
> >                          "Unable to initialize the status endpoint (%d), status interrupt will not be supported.\n",
> >                          ret);

-- 
Regards,

Laurent Pinchart