Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Oct 2022 22:02:11 +0300
From:   Alexey Dobriyan <adobriyan@gmail.com>
To:     Li Zetao <lizetao1@huawei.com>
Cc:     viro@zeniv.linux.org.uk, ebiederm@xmission.com,
        keescook@chromium.org, akpm@linux-foundation.org,
        yi.zhang@huawei.com, chengzhihao1@huawei.com,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/binfmt_elf: Fix memory leak in load_elf_binary()
Message-ID: <Y1gys5Cvjh8cREWB@p183>
References: <20221024154421.982230-1-lizetao1@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20221024154421.982230-1-lizetao1@huawei.com>
Precedence: bulk

On Mon, Oct 24, 2022 at 11:44:21PM +0800, Li Zetao wrote:
> If "interp_elf_ex" fails to allocate memory in load_elf_binary(),
> the program will take the "out_free_ph" error handing path,
> resulting in "interpreter" file resource is not released.

Yes :-(

> --- a/fs/binfmt_elf.c
> +++ b/fs/binfmt_elf.c
> @@ -911,7 +911,7 @@ static int load_elf_binary(struct linux_binprm *bprm)
>  		interp_elf_ex = kmalloc(sizeof(*interp_elf_ex), GFP_KERNEL);
>  		if (!interp_elf_ex) {
>  			retval = -ENOMEM;
> -			goto out_free_ph;
> +			goto out_free_file;

Reviewed-by: Alexey Dobriyan <adobriyan@gmail.com>