Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Oct 2022 14:42:01 -0500
From:   Bryan Brattlof <bb@ti.com>
To:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Nishanth Menon <nm@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Tero Kristo <kristo@kernel.org>
CC:     Keerthy <j-keerthy@ti.com>, Linux PM <linux-pm@vger.kernel.org>,
        Device Trees <devicetree@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        LKML ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 04/11] thermal: k3_j72xx_bandgap: map fuse_base only
 for erratum workaround
Message-ID: <20221025194201.3iup4ionv3zhnfd5@bryanbrattlof.com>
References: <20221025191515.9151-1-bb@ti.com>
 <20221025191515.9151-5-bb@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <20221025191515.9151-5-bb@ti.com>
User-Agent: NeoMutt/20171215
Precedence: bulk

On October 25, 2022 thus sayeth Bryan Brattlof:
> Some of TI's J721E SoCs require a software trimming procedure for the
> temperature monitors to function properly. To determine if a particular
> J721E is not affected by this erratum, both bits in the WKUP_SPARE_FUSE0
> region must be set. Other SoCs, not affected by this erratum, will not
> need this region.
> 
> Map the 'fuse_base' region only when the erratum fix is needed.
> 
> Signed-off-by: Bryan Brattlof <bb@ti.com>
> ---
>  drivers/thermal/k3_j72xx_bandgap.c | 37 ++++++++++++++++++------------
>  1 file changed, 22 insertions(+), 15 deletions(-)
> 

...

>  
> -	if (workaround_needed)
> -		devm_iounmap(dev, fuse_base);
> -

Ugh... This is wrong. 

Of course I will catch it right after I send this out

Sorry for the noise everyone
~Bryan