Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4caa8083-017f-034e-55cf-321ad1a7ba44@amd.com>
Date:   Tue, 25 Oct 2022 15:42:47 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH -next] drm/amdkfd: clean up some inconsistent indentings
Content-Language: en-US
To:     Yang Li <yang.lee@linux.alibaba.com>, alexander.deucher@amd.com
Cc:     christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
        daniel@ffwll.ch, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
References: <20221025060944.31705-1-yang.lee@linux.alibaba.com>
From:   Felix Kuehling <felix.kuehling@amd.com>
In-Reply-To: <20221025060944.31705-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c1loMjhraWplUnJjdTl0aVI4T1d5ZmpObmNqbW1POHc5Rmc1M2ZYcFJpajJW?=
 =?utf-8?B?OTBmcnV5YjFuTUF5THNXMTVkWFNsS0FoT0pRaTVVTXA4eW15b0pDOUVIcGFB?=
 =?utf-8?B?WnN5b0FrUmlMT2dvUi9vN1ZLVHcvNFI1K3Vma3g3bFNJWThTdDkzL0JJcDZD?=
 =?utf-8?B?RjN3cmdJbmdTRGFVbGVRc3o1NEtqTCswQTRmb1AreXRBd0dJenllUDF1TVM4?=
 =?utf-8?B?Uk1KcS90NHQ3dFhPUDBXZHVxUjV3N3hnRkR0TzhhYXFiNjVaN21FNWpCbWpL?=
 =?utf-8?B?ckM0YjRrci9MNkR3SkFSbThIVFlNVGhMMnRKYzJUVGs3MFRzdnVpMmRxM3Rw?=
 =?utf-8?B?N0sxbHJOdElhT0liMG1ZcTA4THg5bERjaFJwNlBTNGFkd1RQRDEzVmZnU1Jn?=
 =?utf-8?B?YTV5czY0NldnNnprK0kzbldUaVlVNFhwaVk0aUF2V0w4bFVDMytIRE9LMkdz?=
 =?utf-8?B?a3oyRll4MzVyN3hzN05sNHN0MnNxZXA1c3VRVW1sOW4wcGVEdm5aMWNGK01k?=
 =?utf-8?B?ZDFmcnZ3WUZrbXRxWU4rdXRrcWRTWDZVcmliVDU3TEplOUNJbmRUc2lZRDly?=
 =?utf-8?B?Tzg0QmFyMW1LYjRXWjJGUXFBQXNXYWJoaGs4TndRRkVjZ1hLSldYSFF6QVFx?=
 =?utf-8?B?NVpoQVlkcWJJbHJkTU1wdzJsYjVGY1ZOMFQzVlIySGJiTVpTUittR1FlZStj?=
 =?utf-8?B?eFptc1pyTURwT3k5NFd0UVB1TThIbzd4R3A3VVNoNFNrVVdsTitHa0VaOXJC?=
 =?utf-8?B?aHBZVm1Db3N0STBzYkhrb0R2WXFlem5OMWJ2ZHdlMTlTQlFZSnl2OVlOWGg1?=
 =?utf-8?B?Q0RFWWY2YVBQZmt6Rk1BclpGdUNEZFdWaFVMWVEzeXdtdzdnV29BWmNsSVdx?=
 =?utf-8?B?dnZuT1JzdG9TVldRL0ZFUndoa1ZodEh3dDI4aThTd0YyTGg4Zlp3UlRQaEg5?=
 =?utf-8?B?ak9lM3AxN3RGUExKcU9MeEI1VkZ0bHgrZ1pMMlVLQmRFZVViT0Vqc1YzU2pr?=
 =?utf-8?B?TTNIa20yK3FtZjJTaGcyMkJaakV2L0ppcVQwTGcyY0M1THl6eXhJZi9qMFM1?=
 =?utf-8?B?WHQybmdzeEFCM1JkU1VEQzNqQVBIWGFKOVdjV1Z2SHYzMEtjc1RXNUpvY21s?=
 =?utf-8?B?SWwyMThLclRqenRjMWszWitLWVM5SDIwNmFLU0o5MlorY1J4cEowRHBKMmZK?=
 =?utf-8?B?cmFBNzYreU5lQjJZRkVib3FweDM1UlA4ZWpaVTlXa1RwNk5nZEF6UTMvK1RP?=
 =?utf-8?B?WWJYdTRscVZrMXc4Q3RqYmF4Nm1lY3ZUaUxNWkFESndsRnFnVzdaQWRpOUlK?=
 =?utf-8?B?RkRIVTdoQVRWdXdqL2VkYkc0eGxQdTJlZGM5OUdUVmg4Zzc0dGlaOEF5dUhZ?=
 =?utf-8?B?SFRuR3Y1dVdKclIxdG1jcG4xekxkUnlVNzN5VUlyNmFiby9JbGR5TlZlU09F?=
 =?utf-8?B?T0NpWUhyVklWbmlkMFB0KzZmSi83aXZEZG1LWHVyQ0lxd0hINlMySWtMeko1?=
 =?utf-8?B?bUI3Y1pkTjhmTnhWYjg4TlYra3dLcnBJdktLcmlCVndZM2NUZ0RrL0JobElQ?=
 =?utf-8?B?NXp5bWJaTU5UenJWcHhHeEVYeG84aHZDcjNlenhqVnpuN3BjTTNmSkZFdE1p?=
 =?utf-8?B?RzRwNTd3cFRRMC9ZT3hNZUZNOWxEWHllYjlOZm1GZG5ZK2VteldCRitDMEt6?=
 =?utf-8?B?ZFA4bS9Uby9IMG0vbTZ1djJmeEx2eTBKSERFV1NZblo0NmVNWUNPeG1lclF0?=
 =?utf-8?B?NVZIblFZY1E3d3FDRnNXcDFjZ0loWUxtUEZ2dHJuZnVSeURyczhLVFI2Umxv?=
 =?utf-8?B?RWNuaHhUUTZkOVcwMlhEdFpiN01SSHJjZ1pwZU9wY3ZNZDcwQ2UzS3lLRS9G?=
 =?utf-8?B?TkMvWFRzOGJleEloc1BZR1did2VET0ljNEhLV2xLZ25OUGpKNUFLNCt3Rm1B?=
 =?utf-8?B?TTU5eW8yNkx4L0dld1YwTGVJMldkLzFnQXcxYnRVemlCdVFLTklQaHZ2KzZ3?=
 =?utf-8?B?L2pzdjliRnVMaXZlNnp2ejlKUHUxc3J6M1dpbldaUE5VSmdtcTlwcnlhTDVU?=
 =?utf-8?B?bGYyMU5zRm5ZNlhMeDdnRnU0WTY5WDVhUkJGZ3hFZ0oxeW5WOHFIVFdHaWta?=
 =?utf-8?Q?Jl93yk0fZwQstHyD6m0U81O8p?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e82d64d-674b-486a-4509-08dab6c118e1
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 19:42:49.0737
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BpWXOoOMyDkgSCVPvih0c2g6S+9MA9scGRTld22iivxfRKBu0DLB/AG7pBtB/2otL4Dty0N9q5DAWG/cnkcbyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6026
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 2022-10-25 um 02:09 schrieb Yang Li:
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c:331 svm_migrate_copy_to_vram() warn: inconsistent indenting
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2537
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

This patch doesn't apply to our amd-staging-drm-next, nor to the 
kernel.org master branch. Which branch is this against?

Thanks,
   Felix


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> index 20d6b2578927..cddf259875c0 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> @@ -328,8 +328,7 @@ svm_migrate_copy_to_vram(struct amdgpu_device *adev, struct svm_range *prange,
>   
>   		dst[i] = cursor.start + (j << PAGE_SHIFT);
>   		migrate->dst[i] = svm_migrate_addr_to_pfn(adev, dst[i]);
> -			svm_migrate_get_vram_page(&kfddev->pgmap, prange,
> -						  migrate->dst[i]);
> +		svm_migrate_get_vram_page(&kfddev->pgmap, prange, migrate->dst[i]);
>   		migrate->dst[i] = migrate_pfn(migrate->dst[i]);
>   
>   		spage = migrate_pfn_to_page(migrate->src[i]);