Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Date:   Tue, 25 Oct 2022 23:01:55 +0300
From:   Jami Kettunen <jami.kettunen@somainline.org>
To:     Caleb Connolly <caleb.connolly@linaro.org>
Cc:     Alex Elder <elder@linaro.org>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Alex Elder <elder@kernel.org>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: ipa: don't configure IDLE_INDICATION on v3.1
In-Reply-To: <20221024234850.4049778-1-caleb.connolly@linaro.org>
References: <20221024234850.4049778-1-caleb.connolly@linaro.org>
User-Agent: Roundcube Webmail/1.4.6
Message-ID: <37e3f35ab495ab26e506a5619172092c@somainline.org>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 25.10.2022 02:48, Caleb Connolly wrote:
> IPA v3.1 doesn't support the IDLE_INDICATION_CFG register, this was
> causing a harmless splat in ipa_idle_indication_cfg(), add a version
> check to prevent trying to fetch this register on v3.1
> 
> Fixes: 6a244b75cfab ("net: ipa: introduce ipa_reg()")
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>

Tested-by: Jami Kettunen <jami.kettunen@somainline.org>

> ---
> This will need to wait for Jami's Tested-by as I don't have any v3.1 
> hardware.
> ---
>  drivers/net/ipa/ipa_main.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c
> index 3461ad3029ab..49537fccf6ad 100644
> --- a/drivers/net/ipa/ipa_main.c
> +++ b/drivers/net/ipa/ipa_main.c
> @@ -434,6 +434,9 @@ static void ipa_idle_indication_cfg(struct ipa 
> *ipa,
>  	const struct ipa_reg *reg;
>  	u32 val;
> 
> +	if (ipa->version < IPA_VERSION_3_5_1)
> +		return;
> +
>  	reg = ipa_reg(ipa, IDLE_INDICATION_CFG);
>  	val = ipa_reg_encode(reg, ENTER_IDLE_DEBOUNCE_THRESH,
>  			     enter_idle_debounce_thresh);