Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp9054511rwi; Tue, 25 Oct 2022 14:39:36 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6XTv0NjHGCic/FIgLoXq1qvirOfgaNw1+lPXh/c9TjeGYU/VpMrwiKTYp6RSIKAeMMvtHt X-Received: by 2002:a17:902:e552:b0:179:e796:b432 with SMTP id n18-20020a170902e55200b00179e796b432mr39936215plf.21.1666733976408; Tue, 25 Oct 2022 14:39:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666733976; cv=none; d=google.com; s=arc-20160816; b=SW1XLt9BWzIw9xcACDaAUqLqjVoH3KmtCJ2tEKiMzomUjordg6bStSVNhmmRjXT6db Ix1HdpPGWLdg4S3saj+RCd30hKd4N3sL7z20kB4xTfHIxoahJOYIoZ4A4N1OEoADFaLy KzCP7VMCVAPzUx245TKrtyIb4LFGmZxoAe6aglyObBmdkqmm8BO3R6wn+AKe95KhJLpv uuXkGUM73XvRI4OkAZu0yeSimQWEIoiClS5lJj4gcVY/gv1Fbp8Vv30J6JQMVBweh0uX rnZrbQKpjLaXBZnPR0kauRBiJHH3X2IJSNRGxKLne/jHtZjqhQUkQ/oihtdcPlZXgNfJ 6q2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=4OTS/vMH0Ype2jr/4k8t3xcotn1QnrWG9tBCWs+7BxY=; b=I6hYJmYWvtrwuZBxM7DDtAkPbcafipbMkTfsoEiyOJVJJ4IwaZqtV1QYQy5YV8lHW9 xBodlaJikCUh89SF7w024o2+eyyZJYpNm2UKjVeu1HOwbmC8SyH90TBXaapMIV6rADUq 2ahpgUqug8enYZVvADmWssOKU7rDj2qoA+D4RjpPA3TfQ/W4dFTUgzyf9sQPYNS/6h1u 7IIdJzvzsPyLcZs55LRuCzgTfySCF3Uhww8/urb0ztn8hW0hGv90C77t1IkULiW38ozQ bsZUeQdOjfJGFf/uT4vxivr3sCj5XZi10WiMDdorqwNiGoGWS5bsefEPvfkRz83fgcCw +LeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=i8wngfqK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q61-20020a17090a4fc300b002129a8204d2si180006pjh.44.2022.10.25.14.39.10; Tue, 25 Oct 2022 14:39:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=i8wngfqK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232334AbiJYVaV (ORCPT + 99 others); Tue, 25 Oct 2022 17:30:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232024AbiJYVaS (ORCPT ); Tue, 25 Oct 2022 17:30:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A773E4F64C; Tue, 25 Oct 2022 14:30:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 43FB161BAC; Tue, 25 Oct 2022 21:30:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 93F39C433D7; Tue, 25 Oct 2022 21:30:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666733416; bh=sOpXMCe9LC1xfyUXh2lmcg/3x2PBBpExWr6Hng1hpAQ=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=i8wngfqK8cXmbc2Bn0/GH0lD40yiiXTzQzGaoftBx6FOZOqMNz1oG92AUzTKJtfTl +PDpYSNe3XbSTSKU8l5LBbV46pmxJhyThuIvEotpWbYqdJaCds48JMHC+sfG3evXVx sDvef30alWKmmKuwUyMRYX0bm1VJHPjv72iwDCQGohaUX9Ouiza3CjwjVyGYbUJtON 0LKC38A65N1T53TjX4bmNcFe30fxMADlvL9DkhY9gy0mnEU6HQs3KkcCTpsaAxDT8d 8jSMlseccyi94HZJWQFWw+TwqGruQqSC5IwqzOGEBizBsfK67q3jGZe/vIXzBpMz6g EGWSB2dlmasbA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 73CCEE45192; Tue, 25 Oct 2022 21:30:16 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH][next] net: dev: Convert sa_data to flexible array in struct sockaddr From: patchwork-bot+netdevbpf@kernel.org Message-Id: <166673341646.9987.5803101009027995896.git-patchwork-notify@kernel.org> Date: Tue, 25 Oct 2022 21:30:16 +0000 References: <20221018095503.never.671-kees@kernel.org> In-Reply-To: <20221018095503.never.671-kees@kernel.org> To: Kees Cook Cc: kuba@kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, axboe@kernel.dk, asml.silence@gmail.com, dsahern@kernel.org, dylany@fb.com, yajun.deng@linux.dev, petrm@nvidia.com, liuhangbin@gmail.com, leon@kernel.org, syzkaller@googlegroups.com, willemb@google.com, pablo@netfilter.org, netdev@vger.kernel.org, nathan@kernel.org, ndesaulniers@google.com, trix@redhat.com, alibuda@linux.alibaba.com, jk@codeconstruct.com.au, bigeasy@linutronix.de, imagedong@tencent.com, kuniyu@amazon.com, liu3101@purdue.edu, wsa+renesas@sang-engineering.com, william.xuanziyang@huawei.com, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Tue, 18 Oct 2022 02:56:03 -0700 you wrote: > One of the worst offenders of "fake flexible arrays" is struct sockaddr, > as it is the classic example of why GCC and Clang have been traditionally > forced to treat all trailing arrays as fake flexible arrays: in the > distant misty past, sa_data became too small, and code started just > treating it as a flexible array, even though it was fixed-size. The > special case by the compiler is specifically that sizeof(sa->sa_data) > and FORTIFY_SOURCE (which uses __builtin_object_size(sa->sa_data, 1)) > do not agree (14 and -1 respectively), which makes FORTIFY_SOURCE treat > it as a flexible array. > > [...] Here is the summary with links: - [next] net: dev: Convert sa_data to flexible array in struct sockaddr https://git.kernel.org/netdev/net-next/c/b5f0de6df6dc You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html