Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "Li zeming" <zeming@nfschina.com>
Cc:     willy@infradead.org, jlayton@kernel.org, song@kernel.org,
        bvanassche@acm.org, reiserfs-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org, "Li zeming" <zeming@nfschina.com>
Subject: Re: [PATCH] reiserfs: journal: Increase jl pointer check
In-reply-to: <20221025084704.3922-1-zeming@nfschina.com>
References: <20221025084704.3922-1-zeming@nfschina.com>
Date:   Wed, 26 Oct 2022 08:30:13 +1100
Message-id: <166673341340.7585.173987927705263434@noble.neil.brown.name>
Precedence: bulk

On Tue, 25 Oct 2022, Li zeming wrote:
> If kzalloc fails to allocate the jl pointer, NULL is returned directly.
>=20
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
>  fs/reiserfs/journal.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
> index 94addfcefede..d64e9de126c1 100644
> --- a/fs/reiserfs/journal.c
> +++ b/fs/reiserfs/journal.c
> @@ -2569,6 +2569,9 @@ static struct reiserfs_journal_list *alloc_journal_li=
st(struct super_block *s)
>  	struct reiserfs_journal_list *jl;
>  	jl =3D kzalloc(sizeof(struct reiserfs_journal_list),
>  		     GFP_NOFS | __GFP_NOFAIL);
> +	if (!jl)
> +		return NULL;
> +

What do you think the __GFP_NOFAIL flag might mean?

NeilBrown


>  	INIT_LIST_HEAD(&jl->j_list);
>  	INIT_LIST_HEAD(&jl->j_working_list);
>  	INIT_LIST_HEAD(&jl->j_tail_bh_list);
> --=20
> 2.18.2
>=20
>=20