Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: enetc: zeroize buffer descriptors in
 enetc_dma_alloc_bdr()
Thread-Topic: [PATCH net] net: enetc: zeroize buffer descriptors in
 enetc_dma_alloc_bdr()
Thread-Index: AQHY58z/UOKKnjnr/UCCCxbobVhRlK4fxFEA
Date:   Tue, 25 Oct 2022 23:31:53 +0000
Message-ID: <20221025233152.idxmtikicu3kmedo@skbuf>
References: <20221024172049.4187400-1-vladimir.oltean@nxp.com>
In-Reply-To: <20221024172049.4187400-1-vladimir.oltean@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o/hKFpJQUomytHW8gpq1Ylv2T8xqwNhj+WNquC6aDkjkk5gDX4xZCzK8Yt7D?=
 =?us-ascii?Q?DM71X+HQDyy1OG4VTVSxzdB8dChMp+5Ht9xUqqMM9/qWS/d4n3CkJuikELQ0?=
 =?us-ascii?Q?8iRxFFDEOxuIuf5vx3+ddabAg6UWj5LlHgD45w8+y6vBJa7tuH82tVcy+bNK?=
 =?us-ascii?Q?GWOqdYSwJoc+FyxmvFiAz95KaNe4dCkANdziHSlnfZh64UeuJ3BEAXFRd2X6?=
 =?us-ascii?Q?KFIcSUO8/RvEbJQSnD2OOGLZyxx0tJj1XdKnwIQyZNRU1SJMVxKDbZq4Czjg?=
 =?us-ascii?Q?hCuVSIj0YT1qBM/HxqlNoRg/yCCZ5Emegv8y9Y2Qhm4Cc1tFcIgWfvn5uUaM?=
 =?us-ascii?Q?rdG8TNgThCKnFlCgt6IrJxe0Vjei0K0AwXiLb+eKb3h2XiTE9ytB4j4idhza?=
 =?us-ascii?Q?S5+93JbYnc3HOUVgMVZUHddVtVI5bKwXwxtVUNf2OdRTRJPCIj7DGwUkG3fh?=
 =?us-ascii?Q?DeF+y2RpaY+sr9THcNXLZ20KpWTeT3lfHffi/nCG36lixmPF2OzkERGvshuv?=
 =?us-ascii?Q?SqMHHi5UopEP1jC3lCsE09eGkuHvOkFHuknqV6GR9zjsUUmez2GB1jH6pA7g?=
 =?us-ascii?Q?pwFtDzj7WCmRiDkg9shozzYygkeDHpj0V9rYZ4NiUlNM4DPsKnPeQyGNv7SB?=
 =?us-ascii?Q?X7Adq0QbJu1VFujhhVMikgR9z9Lwml/xyO4TftZOeO8U4+Xi76UCd1oS8dyY?=
 =?us-ascii?Q?l9nEKkuddPwIPVeUsffoUf18fXSlAiE1qrJNfBA+SfH+vbrQH1iidlX9+iDF?=
 =?us-ascii?Q?KGX0+SLspo/DYr4Ywv5hpea4SH0u0Tt+KxzyniEiRRNJBKBAGJX9AuflCB+m?=
 =?us-ascii?Q?s4nOaezUAXetJueWb/kVvbppAFOK237nNpxOgxgk9/n4E7zKK5SGx1QzWMho?=
 =?us-ascii?Q?hCkw64mwf4qCyRv0RSNOR3Z5/4TahU4G3Ng7LotxhQi/nRdhfqXbW3gAzlW7?=
 =?us-ascii?Q?Gkc8NJUenI7oA/0XX0cjjsl5Qdb9CYsWSlQzkHzS7y+EFAVBpuBF8c4O9+8e?=
 =?us-ascii?Q?Ys3/QNIPAdxzFCudx1NYW+t8NNIjQDcHNj41kuCqQ9S9CK1JTo80/iS8nSH0?=
 =?us-ascii?Q?mCIV4s5E8YlOmV0GeTkclKE5uEKIlltFJ2NOEXPG7bR97jTa6CYeeNS6vo5K?=
 =?us-ascii?Q?ZtalxhVpV8Nv8agdHYwgkr887kQ2Rsw6cj+4DWaDFLQkkLYm5N1XzkiLxt/9?=
 =?us-ascii?Q?zhf+DPUjkSLDQEp6kRFVErfbJuvFK3VSVxEu8TDCFt48c+SRT7mlHKB52xlU?=
 =?us-ascii?Q?55aUUCYrEaFoUGYQBIVd4bFRJTHfQGZW7jAXF3Z0UC/u2pJrUXUbSxHa5ZLJ?=
 =?us-ascii?Q?rFZNds6g3mnzbUEJ1nWFp7FSiyu73xVdR/eXw9p58GX2wHjOq33V78wr0R7q?=
 =?us-ascii?Q?jZLHqQGMQV8S557WiRVjYNP4OLH/XM659knknTgv+yhoWnwhQtTXxTePWTu1?=
 =?us-ascii?Q?9QDSVypx9qhwV2V8Sx3MjerhtpUqaEAnqAQHEybe4soEE1fLkVH80vEHIN0L?=
 =?us-ascii?Q?Oj1QXR9uFGekLqeV35HAFKqyJETsXHHwubKag0gDNhFjZJOSXK9+a7Wm9isp?=
 =?us-ascii?Q?R18moRk30h6ythPVbGw6A5wZ0vEPhKjqIajyEjt+QM3wDMnjBU15c3wXMF2b?=
 =?us-ascii?Q?cg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <BCECCFA63B101548B9AA41D62F44DF8F@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fdbf3a36-348a-42c8-d0be-08dab6e1193d
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2022 23:31:53.3256
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9EtN6FFMc1pUV14ZMV8qQQjwWSSr4Dlg6kUf2+yKBKQsAkSgDzixfhId3Md5lvQ9vFwTzEIoH//9rCL7kZTQEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8749
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 24, 2022 at 08:20:49PM +0300, Vladimir Oltean wrote:
> Under memory pressure, enetc_refill_rx_ring() may fail, and when called
> during the enetc_open() -> enetc_setup_rxbdr() procedure, this is not
> checked for.

Please don't apply this yet, I'm still investigating a crash which has
the symptoms described here, and I'm not sure why the patch didn't fix it.=