Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <75059026-f5fb-59de-8f68-bb71597d55e6@intel.com>
Date:   Tue, 25 Oct 2022 16:50:08 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.4.0
Subject: Re: [PATCH v7 12/12] Documentation/x86: Update resctrl.rst for new
 features
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>
References: <166604543832.5345.9696970469830919982.stgit@bmoger-ubuntu>
 <166604565437.5345.14867510739122394750.stgit@bmoger-ubuntu>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <166604565437.5345.14867510739122394750.stgit@bmoger-ubuntu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1BXbzNGQTlyeXRFS0xNbUVUdElJWDI5YUNma3V0dzJ4cFRtK3Z3VU1ERnVh?=
 =?utf-8?B?czR5bVZvR0ZxdEFoTEJiYTQxWmU3cVhwQU1TY1ZvQjRWUlhYeEprOW5FcTI4?=
 =?utf-8?B?YW5vOE9kcWNUUUp1UW1RRTVlTGdYb1dUdHljT21jZllHKy8vbEtOdVFnMU9t?=
 =?utf-8?B?a2htY2tabC83bFA3YklFeXh1OXJXTDFXTWt2ekh2ZDlOTEF1WW9lNS9jUWwy?=
 =?utf-8?B?d1lpcTR2UDUwK2NYVzRybGhqQkVQa2lIUmVPQi9qYWJYQVorWlJQbUxLcTlq?=
 =?utf-8?B?WERJUGJpQkgxcXY5cEQ0UnRPKzArNmwxZHFIYXZaKzIxU0p2SklwckwwYkh3?=
 =?utf-8?B?R1Nxem9XbjlFSFd3d2pQVktZcVFJTkFqY1lPNlRMYWV6Zkx4WW02MS9LZmZz?=
 =?utf-8?B?SkxQYnNLUEU2OWZpVTVGTWYyZmR1bHAyYzJKRTFxUkYzcjlnVURyNFJtWnho?=
 =?utf-8?B?OFU3emw1aThDSmg0aVExUk5pRU9TRzRQcWxiNXd2a0lodEdJZVhIRjlvclNh?=
 =?utf-8?B?NDhiU1o3ME5GODBOd20vdlJjbUV0bmZxNmJ1bUNxWFI5UUNnVG11KzVFNVY3?=
 =?utf-8?B?Z3RlNjlHZXlxMDd3V2Z0dkhFTGRZY0c3MWo1NjVZeVMvcEhlNnk4VXZWUjRt?=
 =?utf-8?B?MWdUc0dnZ0JrOS9QbnplY1FxMExRcVF3MTJsa0FIQ1hVOUo3cTJReFRlNENH?=
 =?utf-8?B?bGtyV3YxTUl0UjlXQVo0bzlCMlAvNjQ1ckI1N3YraFU5YjRSTDRUREpuQVFO?=
 =?utf-8?B?M0pnWXhPc1RnUGlDQWF3NUJxY01aaUloaUxmRW4xTHd6eElEQ05NZUplcHQ3?=
 =?utf-8?B?Z203ZmQwQ0l2dkFtanhSRVhkNlg0b21PYWNMM0d6UWNDcWIyaFZyRU44RTZh?=
 =?utf-8?B?NFo5aW1XM0grL3BQMzE2bUtNS29LUmJ2RVcvTnV3WUZERHNYbkJZdzVHYjFk?=
 =?utf-8?B?WFpiU3hLbUJZeFFkSklKYzlvcmhFWHY5c2RrVEdCSHVWOVRRZkVtUEpKZGhE?=
 =?utf-8?B?c0ZPWkJvdEhMYmgzcVhoTElyUmErWUhtcHl3TWQ4V2o2dU1DMUlZVnhhQTZk?=
 =?utf-8?B?TVNLZnc2VEpTUXJaZVVMZ0dEYmJ1N2xGMXZNT1JNcWlIeGlXTGRDeXpzb0oy?=
 =?utf-8?B?VGFCWi9QUEVVRGF1OHJEbDNVOFNCdXprQmQyS2xYMFBzdTRsc2QybFNpbnlE?=
 =?utf-8?B?WXUwRlJsSlY1QkFNU2dsLzRVUXJOdldmRzJGV3lqcVVGc2JBSjR4eGluVisy?=
 =?utf-8?B?bitxRHZpREUxRjMyWUpQNlM3WG9KZDNkVUQrVDlKaWp1c21kZDVDa2NVY3Zq?=
 =?utf-8?B?NkJWYlBTL096cHQrRWc5V240Q1c1VXMzQTMvYlNXdzJyRHhNL1J3cTAyMmxL?=
 =?utf-8?B?amJBTWRFdHQ1cFNSVEw1ZzJsVzg5NG4vSXBkY1FhK25SMzBPaTlKcm1tTXll?=
 =?utf-8?B?Ri91M0tUVWJySnB3N2hrSTBNd3RlZkJ6WnptWXU4ZHNCbFk1ZXM0SW55UXly?=
 =?utf-8?B?TWV2Ykdoc1VOdWVZcFBtRnZxUG5rUHN2aENrdTlpTSt0emVBRlJFZTh2anM5?=
 =?utf-8?B?QnR1bHZwOVh2S2RVWnZycytpMG1ZblgzWEZ2VTNFWW13UkkyRFB5aTZyYTQv?=
 =?utf-8?B?MVAwM0JVZm42MWc5MnFOVGJnVTJrZUo4ZzRiRUdSRm9TM0hobjlPT1ZXN2sx?=
 =?utf-8?B?U1FOclNxUXR1bHJHOUp2R0J5WmZyS2YrK3VTSzV3akxvRUJPMS9kbm0vSWsx?=
 =?utf-8?B?RGVQS3MvTzB5L0poQzhiZUlraVZMcjVjajMxZ2Y4aHJLM1YydERYVnYwZjFE?=
 =?utf-8?B?MEQ0L2dPUXdzTjl0UE5iZ09KT0IwdkVzU1J5T2RSNDJtd3hDc1Y0K2JwM2N0?=
 =?utf-8?B?Qm9sU0s0VWdtcC9ieENkeEVLaWFraDBDSnRWOVVKempINGRPUUhQK3pBRjBF?=
 =?utf-8?B?eWpmY2pWUzFscnl2RGhuSFJ1UysyMjNyaCtnR3lhWUY2UkRPLzY3U29tcllQ?=
 =?utf-8?B?N1lLQm90dVR3d0xremZtUFpwcVVPUFhjcVE5YWpDTWM0Z2RINCtmdHorM2kx?=
 =?utf-8?B?WHlFOU5TRzhRVDBQb2xtTEpzNWYxS29UQ0xLRGhFdjhEbzJRdWNKWmhQSU55?=
 =?utf-8?B?Z1E5b1FSamxxQ3J0c3ozM3VFWDZjU2pHQXlWT0lkUTJzb3lRd1NzK0VnSFdR?=
 =?utf-8?B?K2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a22d83f8-eeb6-42ee-5b59-08dab6e3a806
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 23:50:12.1041
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gPSX/C5Aie0gjKLhyhRZG1Deg2sh2TfOfVlS9HbUjF1ZAGxnMvl9pOQIJ63SRAiVHde3qII/Ol5DhpfzSPiU9e5vLYAZo6Mj/o3fuAdpRi8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7201
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 10/17/2022 3:27 PM, Babu Moger wrote:

...

> +"mbm_total_config", "mbm_local_config":
> +        These files contain the current event configuration for the events
> +        mbm_total_bytes and mbm_local_bytes, respectively, when the
> +        Bandwidth Monitoring Event Configuration (BMEC) feature is supported.
> +        The event configuration settings are domain specific and will affect
> +        all the CPUs in the domain.
> +
> +        Following are the types of events supported:
> +
> +        ====    ========================================================
> +        Bits    Description
> +        ====    ========================================================
> +        6       Dirty Victims from the QOS domain to all types of memory
> +        5       Reads to slow memory in the non-local NUMA domain
> +        4       Reads to slow memory in the local NUMA domain
> +        3       Non-temporal writes to non-local NUMA domain
> +        2       Non-temporal writes to local NUMA domain
> +        1       Reads to memory in the non-local NUMA domain
> +        0       Reads to memory in the local NUMA domain
> +        ====    ========================================================
> +
> +        By default, the mbm_total_bytes configuration is set to 0x7f to count
> +        all the event types and the mbm_local_bytes configuration is set to
> +        0x15 to count all the local memory events.
> +
> +        Examples:
> +
> +        * To view the current configuration::
> +          ::
> +
> +            # cat /sys/fs/resctrl/info/L3_MON/mbm_total_config
> +            0=0x7f;1=0x7f;2=0x7f;3=0x7f
> +
> +            # cat /sys/fs/resctrl/info/L3_MON/mbm_local_config
> +            0=0x15;1=0x15;3=0x15;4=0x15
> +
> +        * To change the mbm_total_bytes to count only reads on domain 0,
> +          the bits 0, 1, 4 and 5 needs to be set, which is 110011b in binary
> +          (in hexadecimal 0x33):
> +          ::
> +
> +            # echo  "0=0x33" > /sys/fs/resctrl/info/L3_MON/mbm_total_config
> +
> +            # cat /sys/fs/resctrl/info/L3_MON/mbm_total_config
> +            0=0x33;1=0x7f;2=0x7f;3=0x7f
> +
> +        * To change the mbm_local_bytes to count all the slow memory reads
> +          on domain 1, the bits 4 and 5 needs to be set, which is 110000b
> +          in binary (in hexadecimal 0x30):
> +          ::
> +
> +            # echo  "1=0x30" > /sys/fs/resctrl/info/L3_MON/mbm_local_config
> +
> +            # cat /sys/fs/resctrl/info/L3_MON/mbm_local_config
> +            0=0x15;1=0x30;3=0x15;4=0x15
>  

The code supports modifying multiple domains with one write. To help users
understand this it may be useful to have one of these examples do so to show
that and how it can be done.

>  "max_threshold_occupancy":
>  		Read/write file provides the largest value (in
> @@ -464,6 +539,26 @@ Memory bandwidth domain is L3 cache.
>  
>  	MB:<cache_id0>=bw_MBps0;<cache_id1>=bw_MBps1;...
>  
> +Slow Memory bandwidth Allocation (SMBA)

bandwidth -> Bandwidth?

> +---------------------------------------
> +AMD hardwares support Slow Memory bandwidth Allocation (SMBA) feature.

hardware -> hardware?
bandwidth -> Bandwidth?

Reinette