Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <151c093f-1e92-1c8e-957b-8781e488626a@amd.com>
Date:   Tue, 25 Oct 2022 16:55:24 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 0/2] efi/cper, cxl: Decode CXL Protocol Errors CPER
Content-Language: en-US
To:     Dan Williams <dan.j.williams@intel.com>, linux-cxl@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Robert Richter <rrichter@amd.com>,
        Yazen Ghannam <yazen.ghannam@amd.com>,
        Terry Bowman <terry.bowman@amd.com>,
        Ard Biesheuvel <ardb@kernel.org>
References: <20221007211714.71129-1-Smita.KoralahalliChannabasappa@amd.com>
 <63531a9dd51b9_4da32946c@dwillia2-xfh.jf.intel.com.notmuch>
From:   Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
In-Reply-To: <63531a9dd51b9_4da32946c@dwillia2-xfh.jf.intel.com.notmuch>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2NyWW16UDdUQTVYei9SMjA5Uk9wcEhmOHdVNGN2NHVEVUNRMWUxQmd4c3k5?=
 =?utf-8?B?ZGMrSEZOaEMwQmxrazNoUFV4TnpMTVpQdXJXb3pmckozc1ZpN3plaXVYWXNw?=
 =?utf-8?B?M2NFRzBKVG1WUEhpM3FBNU5CQ3ZqQ2ZZbDVzdW1VM0J3MWtPcTdhbmExa00r?=
 =?utf-8?B?czVFUjQyRXFqRnNkeStJbStXc2xlL2w0ZUFNQ1FtUzdRd0pjWjVSbGFIUlZ4?=
 =?utf-8?B?Nm94ZVpLYUVGd3V6SWhkTFZPWkFYQWcxSFpPVEw2QkVib2orcjVLYzVXTmRC?=
 =?utf-8?B?WEViVTNBb3FrN0dpVXRERTNadExDaTlaMSs2bkVRV3hCb3haZ28wSk1mWkhW?=
 =?utf-8?B?KzdNQ1Y4U3FnenRVRkdwa1NqRU1OZ3BaU1N3STdGeG9xa1RiZkFvUWhqOVE5?=
 =?utf-8?B?cGlRTUFMQ3BKR2VoK0RpeC94UWxSUU85ajdmWE03Ly9NTkFvTzBtNGZxZXNB?=
 =?utf-8?B?TFV1dHdmRFZudVNBeGJpczlwcFY0TCtBckZabU5sOFpkUzNVN1dGWG5ySnJy?=
 =?utf-8?B?blhaZHJaUXM0Vjg4b1U5NWgxOXg2NjRSN2QzOURzQWtIenFnWjlMd0xSYjFh?=
 =?utf-8?B?ZmZKUlBzVStjMnBEVCthNkIwQ1dBeDYxT2t2NW1jLzkxL25pMnJ5NUNpR1N1?=
 =?utf-8?B?R1pHK0paRzQxQ1NPeWg1UGw5d2J0TkRBNDZhbUJJekoxbUU4S2NpdHZPTGs5?=
 =?utf-8?B?VVBpampUenFtRUFaTW1LbWlmVUxkYUNEZXFSVTNRMURNYk5oMmRQSG1wOXNQ?=
 =?utf-8?B?ZEhRWjIyL2FEeERySWp5VXBBa0lVeERnZithaVEvRUZtY2poSzlrU1FnWjNM?=
 =?utf-8?B?N0NuZFZmTUx1My9RMEpJZkp6SkVxMFlCK3RWNWlSYkxLb1NmUEhkalMvK0dP?=
 =?utf-8?B?aEFEN2pPNDFtaTh5ZFFpdEpnVXdBQmROV2JMd1JIQTVaTExPelhKcHFkSEEz?=
 =?utf-8?B?Z1VKQlNCQWhQOEZhWWNtaXFqTDY4OGpLWXlidExIaTdCZ1F3UW9iRWRXcmFR?=
 =?utf-8?B?eEpnS3hwS0RvN1REbnd2amNWVDhlSm1kejZlQk5KVGtKaG90UEtqY0RjOVFz?=
 =?utf-8?B?S0hPUXpwa1BNdG9KSU5Salp4KzZoR05zMElZSkU0cUF6UVJxSHAwTHBrOXAv?=
 =?utf-8?B?ZkorQzNQaG0zMVhBTE1GTjV6RzJQcWlkem1wLzhkd3JnZkptMG91UjdIUWVl?=
 =?utf-8?B?Y3FuQXJmZ21yQVcxdVM3QnY0Y3FDT2g4ZnpQMWZwamtIM015QWIzdTNpNUZk?=
 =?utf-8?B?bkJtUWZRWXdSM1BKTktHOFZEWmgwK2dhakZwSkMrQlRFN2sxSW5HRnhNZVMy?=
 =?utf-8?B?d3h3WC9SZFR6YnZ2VzZZK0hoYjV4dXF0MFVOS2F6WVpBL3ZKUmh5THZpbnh5?=
 =?utf-8?B?bWl0VTlMcGtPYk9QYWNjcDU0bzVaekZwaUJ4Vit5Nld5SDRBS1h5U1Vid0o3?=
 =?utf-8?B?azVFbGpvWWJDZXpSN2dWTVFHUkMzQTFDaVBoeWZSbGkxS2J1ZUQvVUcraERJ?=
 =?utf-8?B?L011WWNZc3l6aW9PWlhkZVRIM1czM21rZHFHSEJqMWpoSDE4cWliNmxoZnJI?=
 =?utf-8?B?M2dhTFBJaTlVTG90dG8xZzJPVlJiRW5MZjBvemc2RXdhNnBWeDBYd2VjYzQv?=
 =?utf-8?B?a1lhUXNrakJybUE2b0hFdDlxY3BNYXBJbHZmbFluYndDemJBL2J5dzV1QW5z?=
 =?utf-8?B?aVlQejBjZGsybVFiWFBKZDZVYkFOV095YSszUDMzNGE5bWtnWkN3aVZiOWw3?=
 =?utf-8?B?S0JUck5QT3NDVDdxSHhhc1crMUZDOWFtM0t6cHNEK2FVUFlUeU1Oc05GeGxU?=
 =?utf-8?B?TWxXSXNXU05laDBiYnhvT04vSVlhUUZMeFNhNnhzdTRlQXUza29McEhnSmtB?=
 =?utf-8?B?RG4rUFlpVHJ2L3dhdXhmbzArOWdOOE9pemZFeW13akpFNDA2SWNHOWxHZGlo?=
 =?utf-8?B?SURiaGtTRUxyT3d2RFVQTUc1TU1lMCtycVVkbXhKVUVzd2NxR3Q2VmZZTmZU?=
 =?utf-8?B?SlJOSFR4VmFob004L1lKRU9CcVJYejNzREZBNVhJQjArWjl5SlA0Z3RJSXIz?=
 =?utf-8?B?NDV5VlBFUFIvN085dWk1eWh5bEtCU1JxVmlRMmZaR3BDV3RIZzljUlcyVVlU?=
 =?utf-8?Q?ZUS9UIforbkvYJKvFlgCJYGRD?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67fe08bb-7494-4992-4b7c-08dab6e46581
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 23:55:29.9523
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UX4L0azO91Rr1vvLmjiwPAhMk3k9T9NyZdzEKrWqc5OtgKUZp9y+Q4CVe/wfSDlYQP4+3GFLz5fML8Sx/HtFYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4320
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Dan,

On 10/21/2022 3:18 PM, Dan Williams wrote:
> Hi Smita,
>
> Smita Koralahalli wrote:
>> This series adds decoding for the CXL Protocol Errors Common Platform
>> Error Record.
> Be sure to copy Ard Biesheuvel <ardb@kernel.org>, added, on
> drivers/firmware/efi/ patches.
>
> Along those lines, drivers/cxl/ developers have an idea of what is
> contained in the new CXL protocol error records and why Linux might want
> to decode them, others from outside drivers/cxl/ might not. It always
> helps to have a small summary of the benefit to end users of the
> motivation to apply a patch set.

Sure, will include in my v2.

>
>> Smita Koralahalli (2):
>>    efi/cper, cxl: Decode CXL Protocol Error Section
>>    efi/cper, cxl: Decode CXL Error Log
>>
>>   drivers/firmware/efi/Makefile   |   2 +-
>>   drivers/firmware/efi/cper.c     |   9 +++
>>   drivers/firmware/efi/cper_cxl.c | 108 ++++++++++++++++++++++++++++++++
>>   drivers/firmware/efi/cper_cxl.h |  58 +++++++++++++++++
>>   include/linux/cxl_err.h         |  21 +++++++
>>   5 files changed, 197 insertions(+), 1 deletion(-)
> I notice no updates for the trace events in ghes_do_proc(), is that next
> in your queue? That's ok to be a follow-on after v2.

Sorry, if I haven't understood this right. Are you implying about the 
"handling"
of cxl memory errors in ghes_do_proc() or is it just copying of CPER 
entries to
tracepoints?

Thanks,
Smita