Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Oct 2022 02:17:13 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Geert Uytterhoeven <geert+renesas@glider.be>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Biju Das <biju.das.jz@bp.renesas.com>,
        linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pwm: Add missing dummy for devm_pwmchip_add()
Message-ID: <20221026001713.kuu5mj6kogosvqnk@pengutronix.de>
References: <12f2142991690d2b1d6890821f6e7779a4d4bdc0.1666706435.git.geert+renesas@glider.be>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="zqa4narnp7crhw3w"
Content-Disposition: inline
In-Reply-To: <12f2142991690d2b1d6890821f6e7779a4d4bdc0.1666706435.git.geert+renesas@glider.be>
Precedence: bulk


--zqa4narnp7crhw3w
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Geert,

On Tue, Oct 25, 2022 at 04:03:42PM +0200, Geert Uytterhoeven wrote:
> The PWM subsystem supports compile-testing if CONFIG_PWM is disabled.
> However, no dummy is provided for devm_pwmchip_add(), which may lead to
> build failures.
>=20
> Fixes: bcda91bf86c1ff76 ("pwm: Add a device-managed function to add PWM c=
hips")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Is this a problem that today yields a failure to compile? As of v6.1-rc1
and also in next all callers are below drivers/pwm/ which isn't included
in the build without PWM=3Dy.

Am I missing something or is this just preparing that one of the drivers
that doesn't live in drivers/pwm might call devm_pwmchip_add in the
future? In that case I wouldn't add that Fixes: line (and also oppose to
backporting that commit to stable).

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--zqa4narnp7crhw3w
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmNYfIYACgkQwfwUeK3K
7AlyLgf/YkGLez5MHyWUIejRu61RzZY1NzxVQGROeC0xwLP7sM+/JycpjB5g9gfO
fwa+xZ2AlcgpQeGViWCocuphqDfkY41oZyM8vV1amtWFH95SNMLmWaQmaj2Jyju+
4C6fx3HvaEbHeqjGbfWo5vprt4zvM176qbQk3ow4nibPEh5ptm559vUJVe2gvAIq
EzMZcLlUPJCwn1qPtkYAheqvgmkjmZDR3t+PTLzsEvvtNNapMDH191r1cZkklURh
95VFrZdeVgEkN9lD1SD2yEVuSkT0FFe3YZ6VC2HxEfR2xFN7JYOS/MyVP8SJjBU6
Mar58HBgXjfvM8tuXwI4236r5awdsg==
=9s9V
-----END PGP SIGNATURE-----

--zqa4narnp7crhw3w--