Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <cover.60659b549d8509ddecafad4f498ee7f03bb23c69.1664366292.git-series.apopple@nvidia.com>
 <f36153fe-214c-2904-e155-ab9cee8a2a2c@kernel.org>
User-agent: mu4e 1.8.10; emacs 28.2
From:   Alistair Popple <apopple@nvidia.com>
To:     "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
        nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        Felix Kuehling <Felix.Kuehling@amd.com>,
        Lyude Paul <lyude@redhat.com>
Subject: Re: [PATCH v2 0/8] Fix several device private page reference
 counting issues
Date:   Wed, 26 Oct 2022 12:47:15 +1100
In-reply-to: <f36153fe-214c-2904-e155-ab9cee8a2a2c@kernel.org>
Message-ID: <8735bbuyvs.fsf@nvidia.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?W/KvJjU8Xcr3K9y5+iNEFd31gckHzYWsYMxNCUdew/EWdpGTmI6If0kROzhB?=
 =?us-ascii?Q?R3AsQ/0zp9ogDueMXJ/FWrgtbqVskTiX40UNpk/Kpjlik4sruTjvuLBFGiSn?=
 =?us-ascii?Q?FfHnFTBvh5EWGBqQo7NPGsWbl6Q0a/TLKQnf2TiWQRosrAD69iCbKlo1h28m?=
 =?us-ascii?Q?zJJoJjUKW1xEZI5So0bOABqP4lMWYnLlCQaoe5jaSi5OFZ/CLgsOpQ05wQYV?=
 =?us-ascii?Q?a1ZfsVgZbmJbBYN68g7gU2R9gitdS9aa5qcF2YKm0rJlBYUmnb+W3I6E+yh4?=
 =?us-ascii?Q?C1gD06YhdOL11MPBKFuPMQBGu+HBtsUFToIxO6gv5PA/6vQ9FJD8Sy8Dv0qa?=
 =?us-ascii?Q?P4q747BjJm1Uy3rlaCUMCweH6Q5YnLN8xim2HkA5QphSbB1S6U+tjG0/SW68?=
 =?us-ascii?Q?xGgfSWfMnrXce5dcO2cQsCMEA/4OqdnXBRQmDwI2qPRyO1GMWrG0ttRbF3VV?=
 =?us-ascii?Q?zonnzGaqEYqHCQW8n4s1TfHjTxmjgGH1/IiI+6xHy9KqNv81GTy9gt+iCyJj?=
 =?us-ascii?Q?7rp97dr21usS3RfwOQZJ4t6g0fdL/8bINxUutUJ17G+JNU5P2I55442tsDQx?=
 =?us-ascii?Q?b6B8og4QlRvbwpQFY8HH7APChOa17WEgPtpDwgSX1Bj0RoN1e8Judt3he6vE?=
 =?us-ascii?Q?EQvJTZj50uT2zEIXXrhzzusSJg82u9NPKuoMhKZnTJHRTFLz7aJAA7Ogkfxb?=
 =?us-ascii?Q?tR5aqC70eOygkh7DBjZeioHrrPDXIZMOdfZ+3cwYpP9TX7Iv5FHm4qMyb3yZ?=
 =?us-ascii?Q?0OhhRTAFLvKsmUpAfBRvF3wcZkLAaGrb6iEByYvVvuawoS/lXZ+SAgLHNOCE?=
 =?us-ascii?Q?5u8XAlGVDzVkdyg8PQ1a7JNe8CH61AL638FUXqt/DcTNWmyUHl5TJ6fYpFaV?=
 =?us-ascii?Q?UL2xR2n3eav/biNjZRKo0Ko1Kufv0KXAOFQp8HyO1TO9yxhX9W6ziOWKKAeL?=
 =?us-ascii?Q?TxfBRo0tDcWmPI6PrhPBmiCKQtVEuR96/Gt8y8EovMKaGNEF4+4+20FFS2kr?=
 =?us-ascii?Q?MZXhS120rABE7P/uRNMPrx/9e5kl4v9jNviwjOPBBI03XtS3HzsRjTQpzmQz?=
 =?us-ascii?Q?J9LfiK572nWPBw6IFGAQ/fiXfNAwq6WKLIY2t9VEu3d0x1DgjzFmh24TjHnu?=
 =?us-ascii?Q?jDAHe4aj0DQQtgXPp2WhxtmJmulW9TRUqlISmOIQ7k/owpJoRMTE8/HnID90?=
 =?us-ascii?Q?GXEkoMz9WCptFShtBjkj+yb8MTvbujbsvFFo/TIF7674oHGMPZUsn2LfKV4M?=
 =?us-ascii?Q?zZYbCRsDMCR5i9S9aU/uuCmo0BqHgGh1kskHWmwuRgkxTjGk42jJHhnNRjHg?=
 =?us-ascii?Q?TYXAvB2NBTTvTjlRRFfZcAFDrnL9pNsvSw4v5hyvKWgrVh2qi7T9dL2ft0Gp?=
 =?us-ascii?Q?HrTq+ySpaxlAeUTxgFaNaO+pgagM97BVMOLCkE5u8NZnyQj5sKX/y5tbLNJm?=
 =?us-ascii?Q?K6UtqvBuIlg8WiQb/AmtRBn58XCUnP4u4aWcPEKAvI5nsKK7/QEGb+YlL8WC?=
 =?us-ascii?Q?Kxj79ObVRrIzarqnSgHVvmZqUkInqGk9o2M3ncWB4w1A2PIs3/J57s5smd9E?=
 =?us-ascii?Q?roqUFjQjMOyQK/jxcRdrO69aE4A01w2wkpWh3irj?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd0b2f76-67fb-47ca-9222-08dab6f5f83d
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 02:01:17.5936
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t1E0MOgD32ewC5kgOK/uMg5IX5cNHGnXPfKqXFSQd6E2QOn2UIwnVTABKgvKrlX/Sy8og1+WeUyyeUTtaq0LHQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5449
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


"Vlastimil Babka (SUSE)" <vbabka@kernel.org> writes:

> On 9/28/22 14:01, Alistair Popple wrote:
>> This series aims to fix a number of page reference counting issues in
>> drivers dealing with device private ZONE_DEVICE pages. These result in
>> use-after-free type bugs, either from accessing a struct page which no
>> longer exists because it has been removed or accessing fields within the
>> struct page which are no longer valid because the page has been freed.
>>
>> During normal usage it is unlikely these will cause any problems. However
>> without these fixes it is possible to crash the kernel from userspace.
>> These crashes can be triggered either by unloading the kernel module or
>> unbinding the device from the driver prior to a userspace task exiting. In
>> modules such as Nouveau it is also possible to trigger some of these issues
>> by explicitly closing the device file-descriptor prior to the task exiting
>> and then accessing device private memory.
>
> Hi, as this series was noticed to create a CVE [1], do you think a stable
> backport is warranted? I think the "It is possible to launch the attack
> remotely." in [1] is incorrect though, right?

Right, I don't see how this could be exploited remotely. And I'm pretty
sure you need root as well because in practice the pgmap needs to be
freed, and for Nouveau at least that only happens on device removal.

> It looks to me that patch 1 would be needed since the CONFIG_DEVICE_PRIVATE
> introduction, while the following few only to kernels with 27674ef6c73f
> (probably not so critical as that includes no LTS)?

Patch 3 already has a fixes tag for 27674ef6c73f. Patch 1 would need to
go back to CONFIG_DEVICE_PRIVATE introduction. I think patches 4-8 would
also need to go back to introduction of CONFIG_DEVICE_PRIVATE, but there
isn't as much impact there and they would be harder to backport I think.
Without them device removal can loop indefinitely in kernel mode (if
patch 3 is present or the kernel is older than 27674ef6c73f).

 - Alistair

> Thanks,
> Vlastimil
>
> [1] https://nvd.nist.gov/vuln/detail/CVE-2022-3523
>
>> This involves some minor changes to both PowerPC and AMD GPU code.
>> Unfortunately I lack hardware to test either of those so any help there
>> would be appreciated. The changes mimic what is done in for both Nouveau
>> and hmm-tests though so I doubt they will cause problems.
>>
>> To: Andrew Morton <akpm@linux-foundation.org>
>> To: linux-mm@kvack.org
>> Cc: linux-kernel@vger.kernel.org
>> Cc: amd-gfx@lists.freedesktop.org
>> Cc: nouveau@lists.freedesktop.org
>> Cc: dri-devel@lists.freedesktop.org
>>
>> Alistair Popple (8):
>>   mm/memory.c: Fix race when faulting a device private page
>>   mm: Free device private pages have zero refcount
>>   mm/memremap.c: Take a pgmap reference on page allocation
>>   mm/migrate_device.c: Refactor migrate_vma and migrate_deivce_coherent_page()
>>   mm/migrate_device.c: Add migrate_device_range()
>>   nouveau/dmem: Refactor nouveau_dmem_fault_copy_one()
>>   nouveau/dmem: Evict device private memory during release
>>   hmm-tests: Add test for migrate_device_range()
>>
>>  arch/powerpc/kvm/book3s_hv_uvmem.c       |  17 +-
>>  drivers/gpu/drm/amd/amdkfd/kfd_migrate.c |  19 +-
>>  drivers/gpu/drm/amd/amdkfd/kfd_migrate.h |   2 +-
>>  drivers/gpu/drm/amd/amdkfd/kfd_svm.c     |  11 +-
>>  drivers/gpu/drm/nouveau/nouveau_dmem.c   | 108 +++++++----
>>  include/linux/memremap.h                 |   1 +-
>>  include/linux/migrate.h                  |  15 ++-
>>  lib/test_hmm.c                           | 129 ++++++++++---
>>  lib/test_hmm_uapi.h                      |   1 +-
>>  mm/memory.c                              |  16 +-
>>  mm/memremap.c                            |  30 ++-
>>  mm/migrate.c                             |  34 +--
>>  mm/migrate_device.c                      | 239 +++++++++++++++++-------
>>  mm/page_alloc.c                          |   8 +-
>>  tools/testing/selftests/vm/hmm-tests.c   |  49 +++++-
>>  15 files changed, 516 insertions(+), 163 deletions(-)
>>
>> base-commit: 088b8aa537c2c767765f1c19b555f21ffe555786