Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Oct 2022 07:28:26 +0200
Message-ID: <87pmefp30l.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Mark Brown <broonie@kernel.org>
Cc:     wangkailong@jari.cn, perex@perex.cz, tiwai@suse.com,
        lgirdwood@gmail.com, motolav@gmail.com, cezary.rojewski@intel.com,
        mkumard@nvidia.com, pierre-louis.bossart@linux.intel.com,
        kai.vehmanen@linux.intel.com, peter.ujfalusi@linux.intel.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA/ASoC: replace ternary operator with min()
In-Reply-To: <Y1gWbN2/Tbf1jeL6@sirena.org.uk>
References: <3d74bcaf.5.1840fa4d439.Coremail.wangkailong@jari.cn>
        <Y1gWbN2/Tbf1jeL6@sirena.org.uk>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 25 Oct 2022 19:01:32 +0200,
Mark Brown wrote:
> 
> On Tue, Oct 25, 2022 at 10:56:11PM +0800, wangkailong@jari.cn wrote:
> > Fix the following coccicheck warning:
> > 
> > sound/soc/soc-ops.c:817: WARNING opportunity for min()
> 
> >  	kfree(uctl);
> > -	return err < 0 ? err : 0;
> > +	return min(err, 0);
> 
> I don't think this is a good warning, while I'm no big fan of the
> ternery operator the new code is less clear about the intent than the
> old code.

Agreed.  That use of ternery is a standard idiom.

If we have to eliminate the use of ternery inevitably, it'd be better
to introduce a new macro for clarity instead.


thanks,

Takashi