Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a600b0e3-19ab-47df-4315-48b8554cb12f@norik.com>
Date:   Wed, 26 Oct 2022 08:38:32 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v2 2/3] dt-bindings: watchdog: fsl-imx: document suspend
 in wait mode
Content-Language: en-GB
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        linux-watchdog@vger.kernel.org,
        Alexander Stein <alexander.stein@ew.tq-group.com>
Cc:     wim@linux-watchdog.org, linux@roeck-us.net, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
        linux-imx@nxp.com, Anson.Huang@nxp.com, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20221025072533.2980154-1-andrej.picej@norik.com>
 <20221025072533.2980154-3-andrej.picej@norik.com>
 <ca484809-07e4-44ca-0ab3-26947bda7fa8@linaro.org>
From:   Andrej Picej <andrej.picej@norik.com>
In-Reply-To: <ca484809-07e4-44ca-0ab3-26947bda7fa8@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 25. 10. 22 15:48, Krzysztof Kozlowski wrote:
> On 25/10/2022 03:25, Andrej Picej wrote:
>> Property "fsl,suspend-in-wait" suspends watchdog in "WAIT" mode which
>> corresponds to Linux's Suspend-to-Idle S0 mode. If this property is not
>> set and the device is put into Suspend-to-Idle mode, the watchdog
>> triggers a reset after 128 seconds.
>>
>> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
>> Reviewed-by: Fabio Estevam <festevam@gmail.com>
>> ---
>> Changes in v2:
>>   - add a commit message,
>>   - add a list of devices which support this functionality
>> ---
>>   .../bindings/watchdog/fsl-imx-wdt.yaml        | 22 +++++++++++++++++++
>>   1 file changed, 22 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
>> index fb7695515be1..9289de97859b 100644
>> --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
>> +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
>> @@ -55,6 +55,28 @@ properties:
>>         If present, the watchdog device is configured to assert its
>>         external reset (WDOG_B) instead of issuing a software reset.
>>   
>> +  fsl,suspend-in-wait:
>> +    $ref: /schemas/types.yaml#/definitions/flag
>> +    description: |
>> +      If present, the watchdog device is suspended in WAIT mode
>> +      (Suspend-to-Idle). Only supported on following devices:
>> +        - "fsl,imx25-wdt",
> 
> You need to define such allow/disallow in allOf:if:then, instead. Like
> example-schema is doing for foo-supply, just disallow it for some types
> or use "if: not: ..."

Sorry missed that. So something like that should be added?:

> allOf:
>   - if:
>       not:
>         properties:
>           compatible:
>             contains:
>               enum:
>                 - fsl,imx25-wdt
>                 - fsl,imx35-wdt
>                 - fsl,imx50-wdt
>                 - fsl,imx51-wdt
>                 - fsl,imx53-wdt
>                 - fsl,imx6q-wdt
>                 - fsl,imx6sl-wdt
>                 - fsl,imx6sll-wdt
>                 - fsl,imx6sx-wdt
>                 - fsl,imx6ul-wdt
>                 - fsl,imx7d-wdt
>                 - fsl,imx8mm-wdt
>                 - fsl,imx8mn-wdt
>                 - fsl,imx8mp-wdt
>                 - fsl,imx8mq-wdt
>                 - fsl,vf610-wdt
>     then:
>       properties:
>         fsl,suspend-in-wait: false

And I'm assuming I can then remove the supported devices list from 
property description.

Are you fine with this, so we don't have to split the compatible list 
like Alexander suggested? Basically we have the same list of WDW 
supported devices in the driver.

Thank you for your review,
Andrej