Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221026020200.29222-1-zhaoping.shu@mediatek.com>
In-Reply-To: <20221026020200.29222-1-zhaoping.shu@mediatek.com>
From:   Loic Poulain <loic.poulain@linaro.org>
Date:   Wed, 26 Oct 2022 09:50:44 +0200
Message-ID: <CAMZdPi-bAw293XWBQL0wZS-nO_COD=ZOBduBVicof87HyEmS3w@mail.gmail.com>
Subject: Re: [PATCH net v1] net: wwan: iosm: fix memory leak in ipc_wwan_dellink
To:     "zhaoping.shu" <zhaoping.shu@mediatek.com>
Cc:     m.chetan.kumar@intel.com, linuxwwan@intel.com,
        ryazanov.s.a@gmail.com, johannes@sipsolutions.net,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, srv_heupstream@mediatek.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        haijun.liu@mediatek.com, xiayu.zhang@mediatek.com,
        lambert.wang@mediatek.com, "hw . he" <hw.he@mediatek.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Zhaoping,

On Wed, 26 Oct 2022 at 04:02, zhaoping.shu <zhaoping.shu@mediatek.com> wrote:
>
> From: hw.he <hw.he@mediatek.com>
>
> IOSM driver registers network device without setting the
> needs_free_netdev flag, and does NOT call free_netdev() when
> unregisters network device, which causes a memory leak.
>
> This patch sets needs_free_netdev to true when registers
> network device, which makes netdev subsystem call free_netdev()
> automatically after unregister_netdevice().
>
> Signed-off-by: hw.he <hw.he@mediatek.com>
> Signed-off-by: zhaoping.shu <zhaoping.shu@mediatek.com>

Could you please add a corresponding 'fixes' tag.

> ---
>  drivers/net/wwan/iosm/iosm_ipc_wwan.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wwan/iosm/iosm_ipc_wwan.c b/drivers/net/wwan/iosm/iosm_ipc_wwan.c
> index 2f1f8b5d5b59..0108d8d01ff2 100644
> --- a/drivers/net/wwan/iosm/iosm_ipc_wwan.c
> +++ b/drivers/net/wwan/iosm/iosm_ipc_wwan.c
> @@ -168,6 +168,7 @@ static void ipc_wwan_setup(struct net_device *iosm_dev)
>         iosm_dev->max_mtu = ETH_MAX_MTU;
>
>         iosm_dev->flags = IFF_POINTOPOINT | IFF_NOARP;
> +       iosm_dev->needs_free_netdev = true;

Look like we have the same problem in mhi_wwan_mbim driver, would you
be able to submit a change for it as well?