Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Oct 2022 16:00:13 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Aneesh Kumar K V <aneesh.kumar@linux.ibm.com>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        "Hocko, Michal" <mhocko@suse.com>, Tejun Heo <tj@kernel.org>,
        Zefan Li <lizefan.x@bytedance.com>,
        Waiman Long <longman@redhat.com>,
        "Huang, Ying" <ying.huang@intel.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Hansen, Dave" <dave.hansen@intel.com>,
        "Chen, Tim C" <tim.c.chen@intel.com>,
        "Yin, Fengwei" <fengwei.yin@intel.com>
Subject: Re: [PATCH] mm/vmscan: respect cpuset policy during page demotion
Message-ID: <Y1jpDfwBQId3GkJC@feng-clx>
References: <20221026074343.6517-1-feng.tang@intel.com>
 <dc453287-015d-fd1c-fe7f-6ee45772d6aa@linux.ibm.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <dc453287-015d-fd1c-fe7f-6ee45772d6aa@linux.ibm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DdaApELdfEJ/5r1JPtJ0uJK3Aru8ObMVQhnkM4G8Sy9qGN2rrZBwCZytiwc6?=
 =?us-ascii?Q?6YwkSExUAqZkYo3AMzIJGKCm4pzfPPe0k7eG9g9ZQWxyxpHzzhKXOeMD20lR?=
 =?us-ascii?Q?Ercw2HtWJG/cZTkmSRzIRkuz5YbWUhXT2QJ72WDVi0wRS9EguuBuJ1bGiof2?=
 =?us-ascii?Q?4I/J5OVeo2+Oi4Tf4YUuqYACCfpgWMMPJv34MY4vUFyRgr+TB9NJAb4UAQxG?=
 =?us-ascii?Q?zHpmdtm3JG4/ZgRAeabxc2nccpP7bTJFO1pCa1Kb7UyDfMwr76w0WdcAMYzm?=
 =?us-ascii?Q?ky4aq/0Y0dEchAAxNr3H7T4U1F12d8lZKypO3RJUWO8aBwYJQpgoRBD0O1sT?=
 =?us-ascii?Q?RrlUU4P7heV2h5u85+CxKfomlZm0+ukd/2kKcvVMqSNToWq9cySEzUKURZEW?=
 =?us-ascii?Q?s1b7K5EQcF5I0Du5U6T8L9wSjMuspgphba1mzbkTuZll9OTUw1DpVcPdshGr?=
 =?us-ascii?Q?QmSDRasbY9kxre6HgchHlDLTnOaITU5dpar0Jc/gRTifTEQuF7wV38l832Oz?=
 =?us-ascii?Q?jI10cpi1b2Gb/fUyUVA3SdqDPQB6S6W5ZBpNrAmXCfUwRzPZD6ZSNvpmrjsc?=
 =?us-ascii?Q?T0DORkyCKFgUx+5u1JyebmCeYMFFRksfXdGc/zgYV+xItZtLI+SiwtGbxsSv?=
 =?us-ascii?Q?dPDj0Bo3FkqTtq9R6BdRCQ3OayEAUItG5Q2/qCS5gR16UTEskrk/hZfyhs/v?=
 =?us-ascii?Q?ElvjJ+BZr65SZmnOrgQaHYaya36rXeTgACQDb5HNhaKKJkn/QA/cFbJNnvZT?=
 =?us-ascii?Q?splOQzWHmnhj3ZiL0o/oFZNBjGAKeS5DvvydOjh3ISh/+WJmPGmkqQ7kq3it?=
 =?us-ascii?Q?LpudKNjoPzPpilKG/6j3Y/MdcgLPY7m++YRvA8nXQ1/fFh9HJQGwwiwN7XOX?=
 =?us-ascii?Q?0k03Ebzpia+QwyPvO3aehLkwaE8WjPFFZDeDz73VHL2aiPSktngY2T4cVfQe?=
 =?us-ascii?Q?gzedyGSOBIUpSM3pqDtyd9jFc95MhFqDWz5TCWcKjn054qswv5xkqQMK6tCQ?=
 =?us-ascii?Q?b+AcFzEzxcF3n7rcdNKcQeJlZ65ZNia+pviVL8LJDc18D4y5BhH7ZFu2jPaE?=
 =?us-ascii?Q?9OsTvpTD9LGXV7hG8SZYUNyNuANR+2FII/NDYhipOmwKJCR8RLeC9IcIqcEn?=
 =?us-ascii?Q?JmxrSyZTIzhjC722DjHl/0AirOdRTNHZB0BAkjr1iB+yPITvIyTjNgEETHlw?=
 =?us-ascii?Q?ZB3UXkl1mirRP67b8+f6g0gUFz2+lucTSc5qHKdnWoGFMhIc3PSTl1tan1LZ?=
 =?us-ascii?Q?daKLwu2EuDZzBOKKIeKUVk0pTghKKNRRamrWtF5fo7lqgEtBpIbBfA5BH/TX?=
 =?us-ascii?Q?SOcNU1zzgvdb7ILb9pWcK2e9mGNPv+9fWR85TrgfKN2t29rwREio8G2RLesC?=
 =?us-ascii?Q?7KaucQtzJ6vfulcCKSJ+LEM6bqieqdGifsafgoBlImnqQH9vqL1bULbP03z5?=
 =?us-ascii?Q?FLbP9EY3wGILikLHA8tfUwAV1VU6BcClFIf7VbsDHenWDF3vZautVCuhNfff?=
 =?us-ascii?Q?QtKgrbPUe3CWcSBNc8OmEfUW+nobHqjG20ElDN+7u0hXQvZtKQ7oXgOUBazo?=
 =?us-ascii?Q?cJW7eW8499V89anrLS9s6VYpRKMRjDrTxzBqMoJV?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 918417b0-e5af-4ab0-ae87-08dab7282340
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 08:00:24.5455
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LzV3lum1mKtlB5ef3Jib6iIPNlS+HtQO1FA6dGeyzWDRik3MYl+kZz2dlyvDXGs6NvYQvDE2yBKwV0HZ1G/4Kw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7562
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 26, 2022 at 03:49:48PM +0800, Aneesh Kumar K V wrote:
> On 10/26/22 1:13 PM, Feng Tang wrote:
> > In page reclaim path, memory could be demoted from faster memory tier
> > to slower memory tier. Currently, there is no check about cpuset's
> > memory policy, that even if the target demotion node is not allowd
> > by cpuset, the demotion will still happen, which breaks the cpuset
> > semantics.
> > 
> > So add cpuset policy check in the demotion path and skip demotion
> > if the demotion targets are not allowed by cpuset.
> > 
> 
> What about the vma policy or the task memory policy? Shouldn't we respect
> those memory policy restrictions while demoting the page? 
 
Good question! We have some basic patches to consider memory policy
in demotion path too, which are still under test, and will be posted
soon. And the basic idea is similar to this patch.

Thanks,
Feng

> -aneesh