Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <65ed2576-55a4-fbf1-010b-a51e92389062@suse.com>
Date:   Wed, 26 Oct 2022 10:02:32 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v2 1/2] usb: serial: add support for CH348
To:     Corentin LABBE <clabbe@baylibre.com>,
        Oliver Neukum <oneukum@suse.com>
Cc:     gregkh@linuxfoundation.org, johan@kernel.org,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        neil.armstrong@linaro.org
References: <20221021133758.1881904-1-clabbe@baylibre.com>
 <20221021133758.1881904-2-clabbe@baylibre.com>
 <135c51e3-56b6-cdf0-3499-cd354f43601d@suse.com> <Y1jlTP7HuH1FQbpk@Red>
Content-Language: en-US
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <Y1jlTP7HuH1FQbpk@Red>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXdtUlNwRS9WZkdpOUlKNzBQVmdLL0o1dVR5a3RiN3dSajYwaHBDRGFCVnBP?=
 =?utf-8?B?bXJuTzA0elNwZk1DMHZCdTdqckpVYU81blMxamxuYkl5OHpOR2c0alo3a3FH?=
 =?utf-8?B?djhEUHFvOFludVJuOTZ1TGRIWkh0OGVadklQOFptc0NSbUpmVDRsdUYvZ2sy?=
 =?utf-8?B?UGhmdHNtWDBvbFVIMitxVVQvSlpEVDNkbW8yZmE2ZTVUUTZGMEljcjBFUHI1?=
 =?utf-8?B?amlkNnZ3bHc2L1ZqbC9YaTljS3ZUOUVaeEZrcmk3WXVjcGFsclN2ODdoOUdE?=
 =?utf-8?B?SG5TbzMvRlNrMmkzd0RzTGc0VVpOUlJGc25wK0o3Tzg3ckNkWHZHZzloYzk3?=
 =?utf-8?B?WStySUl2OEdZUjBiV05HRndGdTY2NFRJUmpITWFhNll1WmE1U0l1dkhFUzg0?=
 =?utf-8?B?ekZBUXo2czFvWUxEWWJWdzZhTHhhbFRjZklLQlZXNHRyWjhLV2dyYUxqdjZO?=
 =?utf-8?B?bE1DMW5ycTZBTVZvTXh5aDRaMDVmTE5wMVNJdXF5anB6RkE2NjFlNkQ4UHNT?=
 =?utf-8?B?cThEdWplZDZyY2VpN3EzaHNsTkpZRFZ2R1NXZFZybCtXWFpaOElraG9uS3ZX?=
 =?utf-8?B?OHdJV3QrcGhTa0J6UTUzSE4yRGtqWWQ5SHZhYjArOUh0aVRjcU9NbFpVNWFO?=
 =?utf-8?B?MzFRU3R3dW5lY2hIbDNDRXZGdGlwY0tLSWpCd25MRHNqN3RSeUNYSGJSL3Jn?=
 =?utf-8?B?VnhSaHlxM3pnT0RMVHgzVS9XL1dYNWhJUElsVzdjZUphZE13YzJEZjhNQzVI?=
 =?utf-8?B?V0JnS0l6VDBzcVBIRGNrem5WcWd0NGdacGg2YlR3aE9wcktLTDNHZ1VEM3Az?=
 =?utf-8?B?SG53d25rdFVxUXhpYkJ4cjFuQkpWY1hNTGg5L2ZMRGsxdGd6OWVNY3N0R3FM?=
 =?utf-8?B?RmpKUmVDK096UGpHWmtWdW9OY1JTYWpYT1ZvNVN3UkQxaG5DMThtcHUwQnYy?=
 =?utf-8?B?T004MXgwQmNXalJ5azlKRjZHMTZuM2R0QjRGc3VNMU5IY1BFQjNXWmhoRjZF?=
 =?utf-8?B?eWs1c1g2OUZyaHN6eXNtZmdZMitvK3RDZDUrekdwQjZpMW4yU2J1R3k4bE9X?=
 =?utf-8?B?WFp4Y2dDTXNaWXgxc09vaXR2WWNOQzFEdWZoL1hkbU1TcVphYUpDcWJhMHR1?=
 =?utf-8?B?cU9leFJ2a2Z6WVczOGZUYmswZWZSblRCK0NLL2owOVpiMDZjSVZONWMrQ1dx?=
 =?utf-8?B?ckkxL2NqRHUxYmVCM2l6R1k4NGhXdDJoUVNTd2tuVWl4dXpxOGJlcS9aY25V?=
 =?utf-8?B?SjJqMUNid0dYNWRRNXFxT0lUNUlndTNnakp1N0treGU5VUZkZ3VySU9PNXY4?=
 =?utf-8?B?Q21oc3FpdXVCWUh0OXJ3c2ZkTDJwNnZJRVFFK1JyMmxsZm9ydVk5VysvUzkx?=
 =?utf-8?B?UU1PSFpBdmRGUTYrMXJpRkpTaHYwMkhjd2k5Tzk2OTJ4N1FVU3k0YW1tNlN2?=
 =?utf-8?B?cFFlUzlVY2I1OXJIdG9YZkI4U2NRd3pHNWVGTlIxRnZvWHcvckJNVHQ3ZGFk?=
 =?utf-8?B?TXFuZmF1bHZnbmZpSXJ1RUVRbkhUdE51UGlkSmR1NGp0UDVtTDM0dG9QaGhJ?=
 =?utf-8?B?RXdXaEhyb0plYlo1TVBKUEdST2ZUUC9mazlrSTZrU080VmhWS09VRXZSSFhB?=
 =?utf-8?B?QWtick5ZZkRqM0lpRk9DdFZaV2l4ZUsrM3BRb2ZNODVjczl3MWtvdVNmTDA0?=
 =?utf-8?B?T25QSXk1RWNUQ28wZFM5UVJncXFFNmh2aHdUTk1vMTJ0bFkzZkhEaUxGRURH?=
 =?utf-8?B?clJ6TmN1U2JabUtEUjlmVitaQXh0bHhLakZOWko2UEc2U0g4WWdrb21sNFg2?=
 =?utf-8?B?SmgvR3k1YVNnY2F5YVlvK2lKL200dVByZS9PMmk0SHJFN2dLUk1jQkxDUjFw?=
 =?utf-8?B?N3RyVUJYQ3JFQm56QjZJSmVTMmtRaEdCTE8zY2U3d0ZuczQ0ZFV2clJYS3dj?=
 =?utf-8?B?SEpQcGdPUU9zd2hFOU5lWW9pVkNGczQxVmZxWkdKSGUzbDBnVitkcHN6QlVY?=
 =?utf-8?B?dTRxcjQ2OUYrSS91UVBuRGJBQmJaNmlCRktDYUFDZUNLTVNHc1NoeWJ0L0Rx?=
 =?utf-8?B?czZSYjZlMUx1S0R1STVlM3doR0tWaHJOd2ZEc0pZUy9VeC9HeWhibEZUa2pC?=
 =?utf-8?B?Vld3bE1VK2FRMlRxMUJjY3BWdlhFTnMzZi9zb1ZGTURHcGxMSFpDMXNkbnRT?=
 =?utf-8?Q?EVOtcyRW7O/k5JmtHiksx16yvSnaG+ficcaJlzbSZ7kP?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a456b9fa-0998-4a64-643d-08dab72870cf
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 08:02:34.6967
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yujjDh2ZMWHbR/oD3LJFY/O1/74uQ1xHXyuoL+hpyTye3BHW4aFToqQFDZEzdTYwBgJl0C6iXSKrwqrJ9Y6MAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8846
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 26.10.22 09:44, Corentin LABBE wrote:

Hi,


> 
> Thanks for your review, I will fix them all.

I am happy to point out issues.

>> [..]
>>
>>> +
>>> +static int ch348_fixup_port_bulk_in(struct ch348 *ch348, struct usb_serial_port *port)
>>> +{
>>> +	int i;
>>> +
>>> +	/* Already Initialized */
>>> +	if (port->bulk_in_size) {
>>
>> BTW, shouldn't these be unsigned int?
> 
> I dont understand what you mean here.

bulk_in_size as a member of the structure is defined as int.
As a size cannot meaningfully be negative and this takes no
error reports, I was wondering whether it should be declared
an unsigned integer for the sake of cleanliness.

	Regards
		Oliver