Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Oct 2022 16:37:02 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     "Yin, Fengwei" <fengwei.yin@intel.com>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        "Hocko, Michal" <mhocko@suse.com>, Tejun Heo <tj@kernel.org>,
        Zefan Li <lizefan.x@bytedance.com>,
        Waiman Long <longman@redhat.com>,
        "Huang, Ying" <ying.huang@intel.com>,
        "aneesh.kumar@linux.ibm.com" <aneesh.kumar@linux.ibm.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Hansen, Dave" <dave.hansen@intel.com>,
        "Chen, Tim C" <tim.c.chen@intel.com>
Subject: Re: [PATCH] mm/vmscan: respect cpuset policy during page demotion
Message-ID: <Y1jxrv5/4PxrEt+F@feng-clx>
References: <20221026074343.6517-1-feng.tang@intel.com>
 <22f86189-76fa-61ab-4e80-9c2740ec8e8a@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <22f86189-76fa-61ab-4e80-9c2740ec8e8a@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rY53g+eQ+nDiMs7T7SVNWAXnjSqn97WbQzidruaR0Kq8133io6mbd1j8Gyx+?=
 =?us-ascii?Q?NM6PmQ1K98kpIROcr6MJqlChvk9qPJLNVk9JY4yhBrgMZHBJ0p1QVdo1KgL0?=
 =?us-ascii?Q?ji4zPjDpgdJ7N59tIXbMOxZbW7O68rtc8qV7EvB+YBZDpA86SyNEgYFoshot?=
 =?us-ascii?Q?N9UJbGAFoThGQ0Dh7zcITeje9ZENXyWCX6FH2iBpxt8KsgMN+KCtFCeVcXhd?=
 =?us-ascii?Q?ds1RmDbxDabW+M5G/SW2fm2qxisSntAYAxbghG7gPR0jIzNKlU5+OEKOKBrB?=
 =?us-ascii?Q?UUnt+TFxCI7ss00/CYF+iYwSTCNzPF/l5F82lkIW0i6C5Ox7SFPFon+v9myc?=
 =?us-ascii?Q?mkBSzOHAyV2j2fc8np8N5Pb30TzFqoWryQFt8lD6qXgflzNsYGWHjUXpX2vB?=
 =?us-ascii?Q?Z2tFqQ1qGdlx0LIa63iztl3rqh+0de6Ihi8B8lUjWXHUZtE9c1Pj6zmj+eu6?=
 =?us-ascii?Q?h5tDKDYqdE3cMdA/irydGSv4lb5Zz/JbE0MQQN+NxfWPNrsKoTJ1RcjqwcD7?=
 =?us-ascii?Q?JqXWKePfqfttXM98Oo8EF7V99zVU3JThTAM87purKiV4Ny2TxZYDXJcP4T2T?=
 =?us-ascii?Q?TSZNmSF2Vr7AKta2VP1m06ceDhm+iJJDTzn/ZTGztY89WL/IehmBQr94s036?=
 =?us-ascii?Q?XoeCTU+B3Rf4KVeWuS9Xbokdx156RaxCrThFNITkJZ7WG08HQFSNvSEPL5Kn?=
 =?us-ascii?Q?WegR8607ILo4rCSHuWaq8VyZptg0R+Klrxnafp5EuUbNGn1IM4wZ9AGCUWvb?=
 =?us-ascii?Q?MCTKmGXMpoundWbYvVCsXwIaLspux/86qY8M4YgUQ9ORjzKwyHEyORim8l53?=
 =?us-ascii?Q?gKtcjUb7FqaQEXgJTvEgcZbqg/QjH+G8gAGKnEIEDKWohPEJ7k2glMJ46h4U?=
 =?us-ascii?Q?cQT9htQgUn+7xH80M2E9I0PjdJ4LbaTA668uhvwjA3j63yPrK6jjTxw9PNUm?=
 =?us-ascii?Q?OuX5BfS8TjT8xcfUSce2Mq6iIosgl+5EpLzIZzATLJLwYlLtVFvxjjsR075R?=
 =?us-ascii?Q?kMjl3t4GTRHgxDom6u1HTOpqRJj/xRpTR7RVjezFra+lY59X5ppOE8Hg7nOM?=
 =?us-ascii?Q?ypAlKrP6dpoOk690SyRzKnyCJ2oLfcl2+GQJWv03UIHWQRLHIpHSfG10iqM3?=
 =?us-ascii?Q?dfGn3m7mHddc0I9rHXJs6XMAOAvhxZitRWTquntAfucjmn7h0b7YjtyRGIG7?=
 =?us-ascii?Q?R34Ajyg7uiPGAlZ7c1VMjzBG5B1T08mlyq3orpISP8oPxF16xDFxZJU+tc2f?=
 =?us-ascii?Q?vcpGHVwcdST/3Rd1DU3MP8k1dcOid/WTYL5pjb2bDCI8ckwYvUPKR6e/Dedx?=
 =?us-ascii?Q?AgngbChHJDHsrYnt3iMd7r9orUX4AzIkAB6iKteXXMXrxnOqDylLMKuo4+I4?=
 =?us-ascii?Q?d+ULm+pqn75wyYkACoyzt2QlKDc5CYNXpMScIsaV70+J1amrl+0YhhCCqAxI?=
 =?us-ascii?Q?kcH/J2uTqQkx6vITXSIb3Yph6PMCY1lB7WJz/o7wA9+quyUFWJySWtFa7crJ?=
 =?us-ascii?Q?2PbiAG+CvjQZ6sluoZk7YbqAKC+vCl6ezSGigs1AprEi/MPMvVi4oPYqdKz8?=
 =?us-ascii?Q?eqJQGBUyRoBjrOhJnVQHEsojO4hw8c5W3zhvJ8kj?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a80dbdc-22c5-4038-61a6-08dab72d47e6
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 08:37:13.4975
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Y6wdwkAzEiFPQN4WtOr0FuQqUyxDb+X302VrnkDoKOPR8OPWMrU5FhT2KFgWuqV/+KKt1iW0au6j1To/FhKogA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5679
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 26, 2022 at 04:26:28PM +0800, Yin, Fengwei wrote:
> Hi Feng,
> 
> On 10/26/2022 3:43 PM, Feng Tang wrote:
> > In page reclaim path, memory could be demoted from faster memory tier
> > to slower memory tier. Currently, there is no check about cpuset's
> > memory policy, that even if the target demotion node is not allowd
> > by cpuset, the demotion will still happen, which breaks the cpuset
> > semantics.
> > 
> > So add cpuset policy check in the demotion path and skip demotion
> > if the demotion targets are not allowed by cpuset.
> > 
> > Signed-off-by: Feng Tang <feng.tang@intel.com>
> > ---
> > Hi reviewers,
> > 
> > For easy bisectable, I combined the cpuset change and mm change
> > in one patch, if you prefer to separate them, I can turn it into
> > 2 patches.
> > 
> > Thanks,
> > Feng
> > 
> >  include/linux/cpuset.h |  6 ++++++
> >  kernel/cgroup/cpuset.c | 29 +++++++++++++++++++++++++++++
> >  mm/vmscan.c            | 35 ++++++++++++++++++++++++++++++++---
> >  3 files changed, 67 insertions(+), 3 deletions(-)
> > 
> > diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h
> > index d58e0476ee8e..6fcce2bd2631 100644
> > --- a/include/linux/cpuset.h
> > +++ b/include/linux/cpuset.h
> > @@ -178,6 +178,8 @@ static inline void set_mems_allowed(nodemask_t nodemask)
> >  	task_unlock(current);
> >  }
> >  
> > +extern void cpuset_get_allowed_mem_nodes(struct cgroup *cgroup,
> > +						nodemask_t *nmask);
> >  #else /* !CONFIG_CPUSETS */
> >  
> >  static inline bool cpusets_enabled(void) { return false; }
> > @@ -299,6 +301,10 @@ static inline bool read_mems_allowed_retry(unsigned int seq)
> >  	return false;
> >  }
> >  
> > +static inline void cpuset_get_allowed_mem_nodes(struct cgroup *cgroup,
> > +						nodemask_t *nmask)
> > +{
> > +}
> >  #endif /* !CONFIG_CPUSETS */
> >  
> >  #endif /* _LINUX_CPUSET_H */
> > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> > index 3ea2e836e93e..cbb118c0502f 100644
> > --- a/kernel/cgroup/cpuset.c
> > +++ b/kernel/cgroup/cpuset.c
> > @@ -3750,6 +3750,35 @@ nodemask_t cpuset_mems_allowed(struct task_struct *tsk)
> >  	return mask;
> >  }
> >  
> > +/*
> > + * Retrieve the allowed memory nodemask for a cgroup.
> > + *
> > + * Set *nmask to cpuset's effective allowed nodemask for cgroup v2,
> > + * and NODE_MASK_ALL (means no constraint) for cgroup v1 where there
> > + * is no guaranteed association from a cgroup to a cpuset.
> > + */
> > +void cpuset_get_allowed_mem_nodes(struct cgroup *cgroup, nodemask_t *nmask)
> > +{
> > +	struct cgroup_subsys_state *css;
> > +	struct cpuset *cs;
> > +
> > +	if (!is_in_v2_mode()) {
> > +		*nmask = NODE_MASK_ALL;
> > +		return;
> > +	}
> > +
> > +	rcu_read_lock();
> > +	css = cgroup_e_css(cgroup, &cpuset_cgrp_subsys);
> > +	if (css) {
> > +		css_get(css);
> > +		cs = css_cs(css);
> > +		*nmask = cs->effective_mems;
> > +		css_put(css);
> > +	}
> > +
> > +	rcu_read_unlock();
> > +}
> > +
> >  /**
> >   * cpuset_nodemask_valid_mems_allowed - check nodemask vs. current mems_allowed
> >   * @nodemask: the nodemask to be checked
> > diff --git a/mm/vmscan.c b/mm/vmscan.c
> > index 18f6497994ec..c205d98283bc 100644
> > --- a/mm/vmscan.c
> > +++ b/mm/vmscan.c
> > @@ -1537,9 +1537,21 @@ static struct page *alloc_demote_page(struct page *page, unsigned long private)
> >  {
> >  	struct page *target_page;
> >  	nodemask_t *allowed_mask;
> > -	struct migration_target_control *mtc;
> > +	struct migration_target_control *mtc = (void *)private;
> >  
> > -	mtc = (struct migration_target_control *)private;
> > +#if IS_ENABLED(CONFIG_MEMCG) && IS_ENABLED(CONFIG_CPUSETS)
> > +	struct mem_cgroup *memcg;
> > +	nodemask_t cpuset_nmask;
> > +
> > +	memcg = page_memcg(page);
> > +	cpuset_get_allowed_mem_nodes(memcg->css.cgroup, &cpuset_nmask);
> > +
> > +	if (!node_isset(mtc->nid, cpuset_nmask)) {
> > +		if (mtc->nmask)
> > +			nodes_and(*mtc->nmask, *mtc->nmask, cpuset_nmask);
> > +		return alloc_migration_target(page, (unsigned long)mtc);
> > +	}
> > +#endif
> >  
> >  	allowed_mask = mtc->nmask;
> >  	/*
> > @@ -1649,6 +1661,7 @@ static unsigned int shrink_folio_list(struct list_head *folio_list,
> >  		enum folio_references references = FOLIOREF_RECLAIM;
> >  		bool dirty, writeback;
> >  		unsigned int nr_pages;
> > +		bool skip_this_demotion = false;
> >  
> >  		cond_resched();
> >  
> > @@ -1658,6 +1671,22 @@ static unsigned int shrink_folio_list(struct list_head *folio_list,
> >  		if (!folio_trylock(folio))
> >  			goto keep;
> >  
> > +#if IS_ENABLED(CONFIG_MEMCG) && IS_ENABLED(CONFIG_CPUSETS)
> > +		if (do_demote_pass) {
> > +			struct mem_cgroup *memcg;
> > +			nodemask_t nmask, nmask1;
> > +
> > +			node_get_allowed_targets(pgdat, &nmask);
> > +			memcg = folio_memcg(folio);
> > +			if (memcg)
> Doesn't check memcg in the change to alloc_demote_page(). What's the difference here?
> 
> > +				cpuset_get_allowed_mem_nodes(memcg->css.cgroup,
> > +								&nmask1);
> > +
> > +			if (!nodes_intersects(nmask, nmask1))
> If memcg is NULL, nmask1 will have an uninitialized value. Thanks.
 
Good catch! Yes, it should be initialized to NODE_MASK_ALL.

Actually I was not sure if I need to check 'memcg == NULL' case, while
I was under the impression that for page on LRU list, it's memcg is
either a specific memcg or the 'root_mem_cgroup'. I will double
check that.

Thanks,
Feng

> Regards
> Yin, Fengwei
> 
> > +				skip_this_demotion = true;
> > +		}
> > +#endif
> > +
> >  		VM_BUG_ON_FOLIO(folio_test_active(folio), folio);
> >  
> >  		nr_pages = folio_nr_pages(folio);
> > @@ -1799,7 +1828,7 @@ static unsigned int shrink_folio_list(struct list_head *folio_list,
> >  		 * Before reclaiming the folio, try to relocate
> >  		 * its contents to another node.
> >  		 */
> > -		if (do_demote_pass &&
> > +		if (do_demote_pass && !skip_this_demotion &&
> >  		    (thp_migration_supported() || !folio_test_large(folio))) {
> >  			list_add(&folio->lru, &demote_folios);
> >  			folio_unlock(folio);