Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp499653rwi; Wed, 26 Oct 2022 03:50:01 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6UeMHEUYb0hU8yGrD13Pu13xbNOW/wlUj3obT0Trt0j0wtEj/dkZKP76dp07sIjvwvOxmn X-Received: by 2002:a17:902:cf01:b0:186:810c:d994 with SMTP id i1-20020a170902cf0100b00186810cd994mr25988507plg.151.1666781401261; Wed, 26 Oct 2022 03:50:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666781401; cv=none; d=google.com; s=arc-20160816; b=GQJNAMj1aCtSr4rHEEVxip7GYrjgqfBwXp7ymCNMQ1mgQzbDCefXps31ICOOkJ6nms iofmCGL+yM4Qe71Xb5ijXV7tgR1fRyGb8tbyaZHugR1n+0lIkgEF20e6dLIuv6hEUJ6y HV3PYl7zLBg9HhuNktnDlaNGVpRJdp6rDaCTxS47K+L59dSjQ7WC+BNWxpasfFSkVsYy 4xIw7C+MoUt9REcf9nkK0h1IngqBasb04KIgZwgtnCOC/khkCFfrOxoW7X/Wqshs0hdC vCJDCZIfLdLSbVgipTwzVJ37Gn26OGIMMxeLjaECIH8S7+FjpvyH0buw3rsRW5UxG1dD 93eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=f6Wz1A4CW5P5+RVQ39/cNozpWA6Bx+Md7zjb4gIkf3c=; b=L15c0WBK5NoDP1H4/UMCQcTxv75Ch27FnXX0hNJ81vCfwbcQxXnEpGWIcwBqKGZtu+ JyaD56XPIevJLbn4twGVnUamdiKNNn01vm3P2UJW0Ucj+1gbjia9k4jwFrOk+CWwPlTq ZZupFeUJsAtfRiu2KEz6+fM7ylVi6NFrDcwOCDpNr1u9mFRK1J1eht87kGqLRxXCvnEJ r2Dl1TBrdyV3xMESwlAmSb/gzBThZIveY0Bp0KAXY9GQRAQgmfNr2V4bI+5PsTREM9bY LKuGLyhJah68tOWzlpvPYT1Dq/a50RVuu7DWdztnmwr/aJqQbSgE0Qvf8kDhgLhivS+h RLwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ionos.com header.s=google header.b="g8zEnq/b"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ionos.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ob14-20020a17090b390e00b0021306464b66si2364751pjb.28.2022.10.26.03.49.49; Wed, 26 Oct 2022 03:50:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ionos.com header.s=google header.b="g8zEnq/b"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ionos.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233317AbiJZKgS (ORCPT + 99 others); Wed, 26 Oct 2022 06:36:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233056AbiJZKgQ (ORCPT ); Wed, 26 Oct 2022 06:36:16 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D745BA3470 for ; Wed, 26 Oct 2022 03:36:15 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id be13so27663559lfb.4 for ; Wed, 26 Oct 2022 03:36:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ionos.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=f6Wz1A4CW5P5+RVQ39/cNozpWA6Bx+Md7zjb4gIkf3c=; b=g8zEnq/beTWN8RH2dXBmBuLwvlw2SmWEhU3NftmPP+qUNz9DXCf6yGvqeo8+t1ws59 /JN55dHJqv4E+MueD1DVKO7hbvKudFvJz1Xi4DBpXYiYk5gdvEXsNPxBjzrEMlX+fNgB XnpCDxGgMHs/PBBGk2HQE5zO1niWkY6NHT3PwSHjJD+t0xpgLABG61YwFn0gbKEhM07S SSfVNx74D+Mc2sjJFwUVCopyAq2YEGjwE6Ybk8Qw2fukrqYhqacRu8oc8s4kweFBSJ9a RnMocn1g0OH6cY73RIqV7+603ABG1xU0c39i7oZGBh910Opg7Ie1t9tr9rvHcFwlDaNp Pobg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f6Wz1A4CW5P5+RVQ39/cNozpWA6Bx+Md7zjb4gIkf3c=; b=hJ4zPmGAGg/hO1WA2fLuhgDIE+dnXRgeDRBBV6blQwmCWvyv9gw1DnhZvN83fRjj1g pgQzfAFwdpsaUumJe1nVF7BhcTLO1qG1M265fIqZHqlJ3qFRkq5VNuyAvYS5aHwgg6n+ wirwkK8WVpe9tn4TcrtXYBsWCWIUiGjSkUxu1eo+om95Hn53JYFfbA4x8T795LsKTmSS Mof6B3xOVFQMvC/A3ZAfWnv5yliSfFHyw6NIKjc/h/cM0BTTKi35yIjQ0oJEyqt7X3l7 k2aAA+WzK81gOX/tC8BNQmdgrv+mpxeeuHYMcAqtIlqj2FeXPjqKuNE19qOP4WbrKqgd opjg== X-Gm-Message-State: ACrzQf1nSRF5nVNyqrzgrVuYb1y7j5FJ+ResSjBPwBhyRfzpwSd6osbS ptckJZQY40HuEE2SM9MvuhIvBc4IQsYY3JRTQUJCT2AKLLo= X-Received: by 2002:a05:6512:298d:b0:4a3:371d:6cc3 with SMTP id du13-20020a056512298d00b004a3371d6cc3mr14788177lfb.422.1666780574194; Wed, 26 Oct 2022 03:36:14 -0700 (PDT) MIME-Version: 1.0 References: <1666781764-123090-1-git-send-email-john.garry@huawei.com> In-Reply-To: <1666781764-123090-1-git-send-email-john.garry@huawei.com> From: Jinpu Wang Date: Wed, 26 Oct 2022 12:36:03 +0200 Message-ID: Subject: Re: [PATCH] scsi: pm8001: Drop !task check in pm8001_abort_task() To: John Garry Cc: jinpu.wang@ionos.com, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, damien.lemoal@opensource.wdc.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 26, 2022 at 12:25 PM John Garry wrote: > > In commit 0b639decf651 ("scsi: pm8001: Modify task abort handling for SATA > task"), code was introduced to dereference "task" pointer in > pm8001_abort_task(). However there was a pre-existing later check for > "!task", which spooked the kernel test robot. > > Function pm8001_abort_task() should never be passed NULL for "task" > pointer, so remove that check. Also remove the "unlikely" hint, as this is > not fastpath code. > > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: John Garry Acked-by: Jack Wang > > diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c > index 2359e827c9e6..e5673c774f66 100644 > --- a/drivers/scsi/pm8001/pm8001_sas.c > +++ b/drivers/scsi/pm8001/pm8001_sas.c > @@ -979,7 +979,7 @@ int pm8001_abort_task(struct sas_task *task) > u32 phy_id, port_id; > struct sas_task_slow slow_task; > > - if (unlikely(!task || !task->lldd_task || !task->dev)) > + if (!task->lldd_task || !task->dev) > return TMF_RESP_FUNC_FAILED; > > dev = task->dev; > -- > 2.25.1 >