Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp602181rwi; Wed, 26 Oct 2022 05:08:34 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5ncuuJbjuHjVHLHU0o6Vpnf/VtgmLXIk/9BRXLJeseIAJAh/QlGoka6IU0X1YAyC+8p3nv X-Received: by 2002:a05:6402:5191:b0:45c:dea0:2c7 with SMTP id q17-20020a056402519100b0045cdea002c7mr39818415edd.239.1666786114241; Wed, 26 Oct 2022 05:08:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666786114; cv=none; d=google.com; s=arc-20160816; b=O/CB322paA1T4qgEt0jrlDxuZJubiuyAWbo+RSsDOOfx734JMBmmulD6DUyCUhLD1q mzIKaT7KugHCWkh4BZYKKf0ohLoB72RhdKCi8IaHIUqN9wcH+M33nMspJ50SE6sxjHZ8 nk/CxIhqoi205EWIafqAvveiIvhxJV+dLbw1P+BlJvdnPLmV0UdgEBPo95TdTM5bKAbx /v4Wo954CMhn91ahWHMv/C4F8F13hInUIZSiVzRcr5h1op5SwSMea5QHAd031gipeeu2 4S9da3Cz9ObgcOGjzJBCF5kcJ42odb8rWHZUYAYN3WsRczTCSkyeXfMvDTte96pwgEIA RVuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=7irqz/NvTW4iXVUnlld6jTYNf6TWqWwg41go+5KxLrs=; b=E6VLYPEjhLyqTHNUtZEYughNwKm+jCtHDRDEDQOAu4MCz6yPbVlUDmvCCQApajfChV h1TmofxKQMweVzne4DHARMgS0bmiLZ4M7ddkYheE08nf2jflW08OG9E9mP2FQZAc62Xw Lvbj0EnVCBXPWL/kRr2OXhH9+EgDld6Vn+ba2UrKer+Did47X/qwdpZiVF9OGUzkVJCw jcKp4P0Iii8pZEokCVQr0R9qUT+wYUJrArthPIqyXcT4I/M2kQWKksLuYb9IvGuD/UsB 7p/empFzPJ7UIavA7ohI/EEb7N349ocm7PKGdiAR++oLA0DCMuWOi/zcoETR+9M9r16f afyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UL5xJdTU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g11-20020a056402090b00b00461e870df81si6352475edz.620.2022.10.26.05.08.08; Wed, 26 Oct 2022 05:08:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UL5xJdTU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233641AbiJZLn3 (ORCPT + 99 others); Wed, 26 Oct 2022 07:43:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233675AbiJZLnE (ORCPT ); Wed, 26 Oct 2022 07:43:04 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B0255A170 for ; Wed, 26 Oct 2022 04:40:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666784412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7irqz/NvTW4iXVUnlld6jTYNf6TWqWwg41go+5KxLrs=; b=UL5xJdTUes6ei5Lrczq9XbpZVmUS5dIs4aMaClcOQ01m4ovxD3AbMptKkfQrnQDBIHy9Sw ARkB7KwVtEeg66f6I48u6CLIXxne0sjOkMkGBeZyAnDsEHWQez8p/tWR913TnNAkLjlijj G+RTgzxvw7c//gcSNQCK885EXYM3N7Y= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-102-KmQNtQqdOsez-P3wdPT1Ug-1; Wed, 26 Oct 2022 07:40:09 -0400 X-MC-Unique: KmQNtQqdOsez-P3wdPT1Ug-1 Received: by mail-ua1-f71.google.com with SMTP id a15-20020ab0494f000000b003e052aec9b2so6692455uad.1 for ; Wed, 26 Oct 2022 04:40:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7irqz/NvTW4iXVUnlld6jTYNf6TWqWwg41go+5KxLrs=; b=tPjzodSwK5e9t6H648qC8kI3gbS1Hg03GsGzf2YO5riQIZVjj6csJt5AW0JyXCGnBf zcxZJsavsGFJ5WUi1gJyx3cUyRHXeqBGp0cszmfjHkVttrn8VsbhFNzmR2PSPhcwFlGR RYR3UrHULqy9KFtxP8B6brBnh+P1DEAFPmmJ3rmPOjhyXbqeD0vw25ca/kUD7Ij0FWeN 2ZKgGDxkvLlGqcd12HLJJe/BSO6+mzFTZuhN/ke3AQqkDXBzRpfnSnPovg9j6ZsMPBRz UdA+OSue3Aax+Amp3PShvHh2t3tmEDtgCx1oWdiMcUtz1kMjyN1d1TGsPx681DgJdUvL zM2g== X-Gm-Message-State: ACrzQf3GCHRyrhQPJe2tZ/GEAmPfavC1itYYnCfG5Ka0EcizuajLHdXQ cnOOJ+n5VSm3eVmC8A1KmeTHqbtP55xCEma14TknIzYoEjWWMeiEfjkCM5rr8yj4XbVQW9Owi3q twX3fAMxZvpI+LueIdMLotWPszuBhu5pkJ4oSPIFC X-Received: by 2002:ab0:1c52:0:b0:401:762b:f888 with SMTP id o18-20020ab01c52000000b00401762bf888mr12114987uaj.57.1666784409110; Wed, 26 Oct 2022 04:40:09 -0700 (PDT) X-Received: by 2002:ab0:1c52:0:b0:401:762b:f888 with SMTP id o18-20020ab01c52000000b00401762bf888mr12114979uaj.57.1666784408893; Wed, 26 Oct 2022 04:40:08 -0700 (PDT) MIME-Version: 1.0 References: <1666780513-121650-1-git-send-email-john.garry@huawei.com> In-Reply-To: <1666780513-121650-1-git-send-email-john.garry@huawei.com> From: Ming Lei Date: Wed, 26 Oct 2022 19:39:58 +0800 Message-ID: Subject: Re: [PATCH v2] blk-mq: Properly init requests from blk_mq_alloc_request_hctx() To: John Garry Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, hch@lst.de, bvanassche@acm.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 26, 2022 at 6:04 PM John Garry wrote: > > Function blk_mq_alloc_request_hctx() is missing zeroing/init of rq->bio, > biotail, __sector, and __data_len members, which blk_mq_alloc_request() > has, so duplicate what we do in blk_mq_alloc_request(). > > Fixes: 1f5bd336b9150 ("blk-mq: add blk_mq_alloc_request_hctx") > Signed-off-by: John Garry Reviewed-by: Ming Lei