Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: enetc: zeroize buffer descriptors in
 enetc_dma_alloc_bdr()
Thread-Topic: [PATCH net] net: enetc: zeroize buffer descriptors in
 enetc_dma_alloc_bdr()
Thread-Index: AQHY58z/UOKKnjnr/UCCCxbobVhRlK4fxFEAgADVDQA=
Date:   Wed, 26 Oct 2022 12:14:25 +0000
Message-ID: <20221026121424.2r3ul2bzve5sbxns@skbuf>
References: <20221024172049.4187400-1-vladimir.oltean@nxp.com>
 <20221025233152.idxmtikicu3kmedo@skbuf>
In-Reply-To: <20221025233152.idxmtikicu3kmedo@skbuf>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1CkwFdFIWHff1+nRBlIdDDqoCnu8dyGDgC6I0WMf1M7k+WM86biEJVzArkIQ?=
 =?us-ascii?Q?u+7Sa8ldDxvYS/Wuzw7f4GjWxMjQM1QlkSMfFxdLxrU9LudMbbDt/jDS6FeL?=
 =?us-ascii?Q?leNVHScSlEraRYmElTufw4jYjy/L64hSJ5m7p6jVGdQmm5FYx5f0axdInyxv?=
 =?us-ascii?Q?rqqHj/lCMo6mXn8Mz2PRcempypCWcg79kkZ/xGvIabLIg39r+1jMnhujWxhj?=
 =?us-ascii?Q?ntroe/7bI4rVHqYs+wH2vez9ucYF0SybUWamRU4ZHjop4nkaxROSSp1vimFO?=
 =?us-ascii?Q?d3WWYsUwf5bwzVHOnRxp60uzDb5UV7EE5qD/5TxhqM3LFvVlFCntSJnBQW+d?=
 =?us-ascii?Q?5vl0Oh681df+eUkyTeoPKP35+t7q0e456W8LocsYK3zXnRBcYPhgqoL0vgC7?=
 =?us-ascii?Q?vncWxOd5vBPXaXOrOGtFG5QRHHjdATudK3JFZNdKmj/ANy/CTCdiR85F89eX?=
 =?us-ascii?Q?JrZBxU2VK+BaA58+cpV1y657GdXAN4ddzZ0Y8AbJ2F52N1PgDFqeNj9Lk/ft?=
 =?us-ascii?Q?zJtCibARIBLU+48RnjqHR4264JSdgmd42ME/B3WZMcxFsO4dZ11bGyEKezLA?=
 =?us-ascii?Q?ErYEu0ZXf/NA1C5IPrPRrNUM5KR2h8j7NBeztmTfoqgn/L6JmOhvLiu8cW99?=
 =?us-ascii?Q?eCwCe1fUwXn50EtfsVcTLnynUpse4eMpcvPzZ6QN/1VwDy8+NQQ5eZDpXKIr?=
 =?us-ascii?Q?BaNGbaw1xvZe4d94JkiqWexUxtBt3Fa933sIhJE5phMiRF3kMuvG0EuhB6XJ?=
 =?us-ascii?Q?OXTk1E4RABZM7pHZPLGZ7lixJKKeLW3XcSzR/Pr7IPqJtaYgopatcZOooDkm?=
 =?us-ascii?Q?RGiYWhtWvk0teW/BuTeikEgKeTtFPX2eGsBLLwhnIEvX7A9YJWEXV80Go+UC?=
 =?us-ascii?Q?Ske3C8u9hbJXUo53RRtByoqAh9VHO+0rypxvtrVq1u+rzBBP+1I1FY+v311t?=
 =?us-ascii?Q?x0aIuyIQHUWSfVP3vpdrNe8W26JuGw5K/pH4Xvjixi7ZSLDoihKn4YJAh341?=
 =?us-ascii?Q?j3mB31LMiV0ZOr3tM2+3c5jYHKTS9hlQRE+WLH/+YW5wU7DhQJ5buoxe4SbA?=
 =?us-ascii?Q?NZDhgaqFjyJXqhysr+K05TlKheqZ0B2wj7SDrDscGFOOb02fqMBtlqU/6FDb?=
 =?us-ascii?Q?zQ4TSrTHKhdzwd9OGRWydNEHzfuwiircP3NTh2pk8/bgW+nPcWhCjzEEkh49?=
 =?us-ascii?Q?fBxreJLKZhTx/KFhj2+K27v8zT2LggUvWOt/OjeT8LQuWAPXCLIM7HFyZ7lm?=
 =?us-ascii?Q?48dUlzn2j1uvij8LuSUCWJayV97yPYlr/sDLAey8TqssEAPh/O/ez5MypO/C?=
 =?us-ascii?Q?A03v37cqy/dfR1gUB1TNU4USP12H5pInbdpYL0xtEr8Xj4vcptydILqiCdpI?=
 =?us-ascii?Q?/eHtwU094lXnim5IWNQ8LtOGUAnZwkb8bcU7X8njYQYFvmS3VUuG0YX/mP8v?=
 =?us-ascii?Q?XPScaHx+LW1uLFN+XYwtn7FYCPSzVQd9J9lKLB9OanKewg1wemyeqGSh74tJ?=
 =?us-ascii?Q?mS67ViVWY9vyb9oLHrWP4ubIC7MX0a5KZvWabRFVm2It7/ZPq+KTfpl3SncO?=
 =?us-ascii?Q?7HDxQ0z/GFL5aEn2aSaV/GAe6CW2nSmaDj+0nrAodiq5ohXDmxXzgNnJpnXg?=
 =?us-ascii?Q?Gg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <02C93D536D904E498CCF09B37C647A7E@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01b71782-364e-45fd-7807-08dab74b9fd3
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2022 12:14:25.7587
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xaYsGRqDs0OKX5rOAwB6uYJensNGOBNMH5Qw7VhWMiQciux7Ztk1kSlUoXqdZWlCxggSnAetJP/fIG+ZNcu49A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7109
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 26, 2022 at 02:31:52AM +0300, Vladimir Oltean wrote:
> On Mon, Oct 24, 2022 at 08:20:49PM +0300, Vladimir Oltean wrote:
> > Under memory pressure, enetc_refill_rx_ring() may fail, and when called
> > during the enetc_open() -> enetc_setup_rxbdr() procedure, this is not
> > checked for.
>=20
> Please don't apply this yet, I'm still investigating a crash which has
> the symptoms described here, and I'm not sure why the patch didn't fix it=
.

Superseded by v2:
https://patchwork.kernel.org/project/netdevbpf/patch/20221026121330.2042989=
-1-vladimir.oltean@nxp.com/=