Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <dec2d423-9f22-e172-abe7-29a9dad8cf12@kernel.org>
Date:   Wed, 26 Oct 2022 14:31:07 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH 2/3] tools/rv: Add in-kernel monitor interface
To:     Steven Rostedt <rostedt@goodmis.org>,
        linux-trace-devel@vger.kernel.org
Cc:     Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <cover.1666776642.git.bristot@kernel.org>
 <d52a15b93acb15142551b8e84ff4bcd934de22ce.1666776642.git.bristot@kernel.org>
Content-Language: en-US
From:   Daniel Bristot de Oliveira <bristot@kernel.org>
In-Reply-To: <d52a15b93acb15142551b8e84ff4bcd934de22ce.1666776642.git.bristot@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/26/22 12:44, Daniel Bristot de Oliveira wrote:
> Add the ability to control and trace in-kernel monitors. This is
> a generic interface, it will check for existing monitors and enable
> standard setup, like enabling reactors.

Oops, forgot to add spaces before #

> For example:
> 

 # rv list
> wip                      wakeup in preemptive per-cpu testing monitor. [OFF]
> wwnr                     wakeup while not running per-task testing model. [OFF]

 # rv mon wip --help
> 
>   help:
> 
>   usage: rv mon wwnr [-h] [-q] [-r reactor] [-s] [-v]
> 	-h/--help: print this menu and the reactor list
> 	-r/--reactor 'reactor': enables the 'reactor'
> 	-s/--self: when tracing (-t), also trace rv command
> 	-t/--trace: trace monitor's event
> 	-v/--verbose: print debug messages
> 
>   available reactors: nop printk panic

 # rv mon wip --trace
>           <TASK>-PID      [CPU]  TYPE       ID                    STATE x EVENT                    -> NEXT_STATE               FINAL
>               |   |          |     |        |                        |     |                           |                       |
>               rv-3613     [001] event     3613                  running x switch_out               -> not_running              Y
>             sshd-1248     [005] event     1248                  running x switch_out               -> not_running              Y
>           <idle>-0        [005] event       71              not_running x wakeup                   -> not_running              Y
>           <idle>-0        [005] event       71              not_running x switch_in                -> running                  N
>       kcompactd0-71       [005] event       71                  running x switch_out               -> not_running              Y
>           <idle>-0        [000] event      860              not_running x wakeup                   -> not_running              Y
>           <idle>-0        [000] event      860              not_running x switch_in                -> running                  N
>     systemd-oomd-860      [000] event      860                  running x switch_out               -> not_running              Y
>           <idle>-0        [000] event      860              not_running x wakeup                   -> not_running              Y
>           <idle>-0        [000] event      860              not_running x switch_in                -> running                  N
>     systemd-oomd-860      [000] event      860                  running x switch_out               -> not_running              Y
>           <idle>-0        [005] event       71              not_running x wakeup                   -> not_running              Y
>           <idle>-0        [005] event       71              not_running x switch_in                -> running                  N
>       kcompactd0-71       [005] event       71                  running x switch_out               -> not_running              Y
>           <idle>-0        [000] event      860              not_running x wakeup                   -> not_running              Y
>           <idle>-0        [000] event      860              not_running x switch_in                -> running                  N
>     systemd-oomd-860      [000] event      860                  running x switch_out               -> not_running              Y
>           <idle>-0        [001] event     3613              not_running x wakeup                   -> not_running              Y
> 
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Daniel Bristot de Oliveira <bristot@kernel.org>

I will fix this log to in the next version.

-- Daniel