Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Daniel.Machon@microchip.com>
To:     <petrm@nvidia.com>
CC:     <netdev@vger.kernel.org>, <davem@davemloft.net>,
        <maxime.chevallier@bootlin.com>, <thomas.petazzoni@bootlin.com>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <Lars.Povlsen@microchip.com>, <Steen.Hegelund@microchip.com>,
        <UNGLinuxDriver@microchip.com>, <joe@perches.com>,
        <linux@armlinux.org.uk>, <Horatiu.Vultur@microchip.com>,
        <Julia.Lawall@inria.fr>, <vladimir.oltean@nxp.com>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [net-next v3 2/6] net: dcb: add new apptrust attribute
Thread-Topic: [net-next v3 2/6] net: dcb: add new apptrust attribute
Thread-Index: AQHY54eplZCAOpJ79E+/+KGuQyJoL64ghtyAgAAUtQA=
Date:   Wed, 26 Oct 2022 12:10:23 +0000
Message-ID: <Y1kmBMXluPI1Wmu/@DEN-LT-70577>
References: <20221024091333.1048061-1-daniel.machon@microchip.com>
 <20221024091333.1048061-3-daniel.machon@microchip.com>
 <87zgdizvfq.fsf@nvidia.com>
In-Reply-To: <87zgdizvfq.fsf@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?F5NlBlF1gRoZo7RN8FsOBNwIR0ftd1DP+uYFoYeE1KNMH4lPCP+b7CPkjxbb?=
 =?us-ascii?Q?qcCeU5deT17HdqC4V9ezcmZlClZP7yNA8uMSMQdFzdPMEtds1mDLX+DJ6tL2?=
 =?us-ascii?Q?+DwnwqrNZMufgODi72YFO7Zc3HM0+qT1Hp2EbiIuM52eBvoWleu12XmrKf9X?=
 =?us-ascii?Q?CBOkb+TdQ0uVjjpDeO9YdKRqXI2xRNcRv2JUrjrFLQ/w4zGTQuAc3GadsP7K?=
 =?us-ascii?Q?SKRHbGL4Ye9hP6SxOD1Htr6tzw2qZFqjQX6sy6HPGIrwkV5Jl2SnpjWnMbiQ?=
 =?us-ascii?Q?KKX1W9ioPJL9IfBWvwZ9bQ8OZlzERDLj5woeXRlC39fP4IvniV1d0KwWryZb?=
 =?us-ascii?Q?ae9En298Usg6D/vzZAdHgZto12NJ4AJtvVRbWFJDMS3/w+lWl2UgxyZQk/Kg?=
 =?us-ascii?Q?j5Kv62MqeJmrtsmBzApBKvLj/N/smAjiCtGASbKwK4sSmYWgihasmFGaIxGz?=
 =?us-ascii?Q?A7TcYViqHCXh29Mbwp7C5U70JAkUxqlNDgDm+pTyUC6POs/SsZujgK5L+FJO?=
 =?us-ascii?Q?5VR1cVls8L+mvxeWCLaPOwIxjsfFZLZ9EWnpgqwPPjR9OcF3tuhqwGi0mD5j?=
 =?us-ascii?Q?53HXBk3TJmVj/h43ltOMxKBFJWvCU2AQ8ywKtROtLJETL5bIYP+uKUvWyPvL?=
 =?us-ascii?Q?HStfMuPJ7YFfYBcHOR0xJzxdTPVW7kJyyi3dqmVogocPqbwRWmcsRT62cP8F?=
 =?us-ascii?Q?htnTtJw/+czo6VebCmZ9DNjBN9keSz+KZaJV8sBNuMIqBZ18r1WPGU80kpcN?=
 =?us-ascii?Q?y54rBBQAjJYkiJw5S8RMBi/QVu+N4L52IQg4O/9sEawc6zetAc0rKcel4+fi?=
 =?us-ascii?Q?cZj3gl4+xZOJNX5adSDCripJnfZofANbGVnRoE1e+qVk9+z0ETQpUugNfZDM?=
 =?us-ascii?Q?0dShuv2pMsb4d46XYf7J0D3c52eYrUeq33DIW3NkKh+XontbITXg017/MAfB?=
 =?us-ascii?Q?nUFnuunKZ7Bph2Emc72y38DL10A04F1knu2RCDJ7+SW+MSupYI+0EziHoJTA?=
 =?us-ascii?Q?hobbYdcudVZiMvLZJuB42OJBKmuJlU1gygre/RG6SONNpcUzoRDP07xYcd//?=
 =?us-ascii?Q?5r6mDnsnk8bVTQvNI+scpQie86ABXjGWT0+P7VdzF+YMZU4ZSw8Fhl9I7nYR?=
 =?us-ascii?Q?PQYTZBPKI7h7uQE5CPbt0UowYFHFrcgwAIdDezTyVARJqILjq6zERosan5rs?=
 =?us-ascii?Q?23VCmHxMsEnUQoESoXuqXo1iy5SnEWCb7neO/3DV1QhAPxeEmkhVOQgWeTrd?=
 =?us-ascii?Q?NKLX2waRx/qvik3D7AUKjd0I1WlG9w8X73mSRSziPp9ssuvEY9ErhtpxPZ0B?=
 =?us-ascii?Q?P0BEvEQKa/MBO9XC7Hvo3khs8A9yoIeRr6CoxttN6FLqyH2BA1L8Z8Cr4Ddq?=
 =?us-ascii?Q?zKPrivr1EsA5V5HLFE7TMJkREHnSjTLQFOlAixweSO7mSXoQEU1LbVh4ed3r?=
 =?us-ascii?Q?khNlcCZAwuGx7kiJgp0Zr5TIgfVFwmlOamZsThstr1tUY5cCxRZCatCJ1mjG?=
 =?us-ascii?Q?0aQGyjIbnKALN+WrM9XZylrTuWbjqdrJokKzwkvLW8ZSLtFbSbZKSEZ1+hzE?=
 =?us-ascii?Q?KsF+YG0c9JhKciqGI4VPajZgQEVe71g1Ddoh2o67dfV3NQ0zwu/ZlQm7YDXr?=
 =?us-ascii?Q?ejhDY+qS5vnIxD5vknVgmTg=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <43C2229516C31245BCF1DA520B6ED02B@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5569.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 827e83db-abec-4fe3-9bbc-08dab74b0fb1
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2022 12:10:23.9606
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0mAxMlDTa1m64XG8YaD2bb0kBG91b42eS8rkVKkr+o2hbG9L5pNKrmhvyq/kSshXvwlDCULOQjplsvtMfv8S48HDF2mztTDMw21ptpMePX0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6495
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > +     if (ops->dcbnl_getapptrust) {
> > +             u8 selectors[IEEE_8021QAZ_APP_SEL_MAX + 1] =3D {0};
> > +             int nselectors;
> > +
> > +             apptrust =3D nla_nest_start(skb, DCB_ATTR_DCB_APP_TRUST_T=
ABLE);
> > +             if (!app)
> > +                     return -EMSGSIZE;
> > +
> > +             err =3D ops->dcbnl_getapptrust(netdev, selectors, &nselec=
tors);
> > +             if (err)
> > +                     return -EMSGSIZE;
>=20
> This should return the error coming from the driver instead of
> -EMSGSIZE.

Hmm. The question is whether we should return at all if dcbnl_getapptrust()
fails, or just continue to fill whatever other ieee information is availabl=
e?
Seems to be like the rest of the code in ieee_fill() just ignore that error=
.

>=20
> Also, it should cancel the nest before returning.

Ack.=