Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp746135rwi; Wed, 26 Oct 2022 06:48:45 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7fP8YQAUStxVbG8SSA9HfKFXSK9f+SymVL8mdYDV1RO4gow7svzWC08wW2RmN+pou5QN3z X-Received: by 2002:a17:906:8a4b:b0:7a7:3e17:7f91 with SMTP id gx11-20020a1709068a4b00b007a73e177f91mr15482734ejc.331.1666792125329; Wed, 26 Oct 2022 06:48:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666792125; cv=none; d=google.com; s=arc-20160816; b=WZoGhwLsSgbyIdm0LK9DPfhntNtkzVu9gMJ/EdMhHiKq1M7GHhKufLapO9AwC4IxfF rolVnQZiohc6LeE+QczbmYha4Cec1q2RzGR4E9wqImvIjzeORYXa5cYo2eOM5kD0InAt w5Xr02qOC3lXD+rSRXfdWcAIRj0TD3Jowyjnnvca0gzVHUXyaOWCubpYR6xEH6UKZypn QkX38bFZV9yf3l2hK93iAekES2mZpXRAsqP7o5/2f2E6tIMXIe6PliGBCXYtjC/xknkG BzZ1vZ7lFwa1cIT8Fv+ZK4ehmEyt5fOqjq5FX4V4TsWqBTHSIAwBse4WaDdSdArIdGcM /X4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ofX3AGRlQ+s/axUX8VCWfH/CRxZOBUGZ7kUmvUAH1a0=; b=GeI0STfwgbdXID4QTlve5L0v9PzjbOzcEig9rzyqyujX2MCtHM4k4iv4xLitkTvs7j Y3U+0LVRV/RxLDcI0qrBrd8ISzgGjDxU/lB0lAxYLmvijMHBsWIotBE6mgQYreMw9gEx ZB/pbre9lpRKVo8r79RvTan3YN8IY0mMIuVG4D9e3AwOvcA98rw4YRqkqj+0XMqCIGNF OI2O72auvKJUE67WjMpw4LInKWxvW4BsAMNLGQ53wUklOAjZG1bFv+iXkG2KphhVj3Lj DMHQMzqVZaXCdo3tmYJ/9wU97rE+MEMZLA60JpIaEzFfRzTXuf9GJvVOzz4L3YLNoG8X VAvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HBFwanhX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ji19-20020a170907981300b0078219af8361si6724181ejc.883.2022.10.26.06.48.17; Wed, 26 Oct 2022 06:48:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HBFwanhX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233509AbiJZNgm (ORCPT + 99 others); Wed, 26 Oct 2022 09:36:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233449AbiJZNga (ORCPT ); Wed, 26 Oct 2022 09:36:30 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 072A15FDD8 for ; Wed, 26 Oct 2022 06:36:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B8302B82247 for ; Wed, 26 Oct 2022 13:36:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E93BC433D6; Wed, 26 Oct 2022 13:36:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666791384; bh=268dyf9pA9pqhHEN/I5mygwM/5Z2FSEBiLT8yOe9VS8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HBFwanhXZE58bOQdoei4BJa9TIjTaY8dei+H0cEySfgnTwIOEDpo7ekWB+F+p/H0M rZckrpZblABsddPsy1a4b1J5TtdVuPDC07qj/wd2AUDANc8FDPQ+jmJl0rqoELtWR8 fBGF5CZ9IhdLMJka+arvMLRz1e1QpEnd7qvTl7XFRulZvkQQs+Ngmc+C99qLkwnmKl O5f22YEGfBwA0KCQWr8BXwtMQcldDeJa0WLCSsRij8H3vH05rfNXsNeyUgV99xNAIj vDTp+PclwBABA2xMhkK9vTHYv/oxaxGPyYM9lu8VgeatZn5gJb0fmgXjfzp4ym2Mpy 4UcO2sOg1N9Zw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1ongZj-0001dC-Se; Wed, 26 Oct 2022 15:36:07 +0200 Date: Wed, 26 Oct 2022 15:36:07 +0200 From: Johan Hovold To: Mark Rutland Cc: Sudeep Holla , Johan Hovold , Lorenzo Pieralisi , Ulf Hansson , Dmitry Baryshkov , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware/psci: demote suspend-mode warning to debug level Message-ID: References: <20221024143417.11463-1-johan+linaro@kernel.org> <20221025115355.26zrhmaudigumivn@bogus> <20221025132655.4kddpdod5czw3vts@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 26, 2022 at 02:24:58PM +0100, Mark Rutland wrote: > On Tue, Oct 25, 2022 at 04:32:52PM +0200, Johan Hovold wrote: > > Trying to inform every user that a warning during boot is actually > > benign and nothing to worry about generally seems backwards to me and is > > not something that is likely to scale. > > It's not *entirely* beningn; we still have to bodge around this not being to > spec, and there are things that won't work (e.g. if we kexec to a kernel that > expects the FW to actually follow the spec it claims to). > > I agree with Sudeep that we should log something here, but I do appreciate that > argumetn that for 90% of users this is not interesting. > > I would suggest we make this: > > pr_info(FW_BUG "failed to set PC mode: %d\n", ...); > > ... so that it's always logged for those who care, but as it's INFO rather than > WARNING, it'll easily be filtered out of logs (e.g. for users booting with > "quiet"). Adding FW_BUG will also make this clear we're complaining about a FW > bug rather than this being a kernel-internal error. Sounds good. I'll respin. Johan