Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Oct 2022 15:55:01 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Deepak R Varma <drv@mailo.com>
Cc:     outreachy@lists.linux.dev, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: rtl8192u: remove unused macro definition
Message-ID: <Y1k8NWuTxOf6z5zL@kroah.com>
References: <cover.1666754500.git.drv@mailo.com>
 <b7053d8737c048d6a878609f0ec24d66b18c5abd.1666754500.git.drv@mailo.com>
 <Y1kyr/hWqbKCzaaR@kroah.com>
 <Y1k5y5PVT6t0+OIS@debian-BULLSEYE-live-builder-AMD64>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y1k5y5PVT6t0+OIS@debian-BULLSEYE-live-builder-AMD64>
Precedence: bulk

On Wed, Oct 26, 2022 at 07:14:43PM +0530, Deepak R Varma wrote:
> On Wed, Oct 26, 2022 at 03:14:23PM +0200, Greg Kroah-Hartman wrote:
> > On Wed, Oct 26, 2022 at 08:58:44AM +0530, Deepak R Varma wrote:
> > > Pre-processor macros that are defined but are never used should be
> > > cleaned up to avoid unexpected usage.
> > >
> > > Signed-off-by: Deepak R Varma <drv@mailo.com>
> > > ---
> > >  drivers/staging/rtl8192u/ieee80211/ieee80211.h | 2 --
> > >  1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> > > index 00c07455cbb3..0b3dda59d7c0 100644
> > > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> > > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> > > @@ -230,8 +230,6 @@ struct cb_desc {
> > >  #define ieee80211_unregister_crypto_ops ieee80211_unregister_crypto_ops_rsl
> > >  #define ieee80211_get_crypto_ops	ieee80211_get_crypto_ops_rsl
> > >
> > > -#define ieee80211_ccmp_null		ieee80211_ccmp_null_rsl
> > > -
> > >  #define free_ieee80211			free_ieee80211_rsl
> > >  #define alloc_ieee80211			alloc_ieee80211_rsl
> >
> > These #defines are a mess, please look into unwinding them as they
> > should not be needed at all.
> 
> Hello Greg,
> I would like to know what you mean by "unwind them". Is there a documentation or past
> commit that I can review to understand the expectations better?

Look at them and try to figure out why they are there, and then work to
remove them entirely.  A define like this is very odd in the kernel, it
should not be needed at all, right?

thanks,

greg k-h