Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Michael Kelley (LINUX)" <mikelley@microsoft.com>
To:     Anirudh Rayabharam <anrayabh@linux.microsoft.com>,
        KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "wei.liu@kernel.org" <wei.liu@kernel.org>,
        Dexuan Cui <decui@microsoft.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
        "daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
CC:     "kumarpraveen@linux.microsoft.com" <kumarpraveen@linux.microsoft.com>,
        "mail@anirudhrb.com" <mail@anirudhrb.com>
Subject: RE: [PATCH 0/2] Fix MSR access errors during kexec in root partition
Thread-Topic: [PATCH 0/2] Fix MSR access errors during kexec in root partition
Thread-Index: AQHY6UGlSxecIa3tCUqtnwUn6w6xFa4gwWeA
Date:   Wed, 26 Oct 2022 14:57:58 +0000
Message-ID: <BYAPR21MB1688DBC9CA80E03BDC7643E2D7309@BYAPR21MB1688.namprd21.prod.outlook.com>
References: <20221026134715.1438789-1-anrayabh@linux.microsoft.com>
In-Reply-To: <20221026134715.1438789-1-anrayabh@linux.microsoft.com>
Accept-Language: en-US
Content-Language: en-US
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=edc789b0-4bdb-4268-bcf6-837b60eb2193;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-10-26T14:48:06Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=microsoft.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR21MB1688:EE_|SJ0PR21MB1870:EE_
x-ms-office365-filtering-correlation-id: c2b7b51c-f28a-44cb-6ee3-08dab762789f
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: LiO+8KgY8kA9gmq+5QlVsEieRGvsAZRvtGlQMEFE65djiPrp+ZT/kCz8BwUIkFmRUWc2Svs7tbjxg1zJE2zleuY1OVt99Z0Y+kqYVkr7s6MFK4eYRJEqRI7KupEyTsdb51DaYqJfGtPwXsJTwawDclQdAIPGw0iOjuXCcXz2a/vnwqwgfBe33AvwlhkGn7vReHrOYmkqFsSC7ZEFUvdPY9O+QVLmm5z5dVuQxeeFYumhMUna4BTj6QYE5Q53TW3iVG7TELLmxlQCkZRTFEYHV+5EpACbYGslnrZ9Yg1RAKAvHWG0/8+/BlcRUa/t5/YZF1GKyT38oKq0ZsWhWQw3X4yYQ/Wa345hFD6/xAphj4a9H3ufhrMiMBtHmy3kPsa9uX/mOwyubm8aPgaXYV56B3E1kJ04oFxBOWD/q7/A5UTQ5+HTO05jHsdw6WPLSOwNZfOB8uGt0JPMXsDRfqPeEuktNFPyM/sGyy6dIttV0vTQE6/gu2aTlmHi60gUS8MCCpI7xyaH2HgD9y9s2+0eLEl8dX8tolXi4JiZNdTz94+k2RMZuM+AqhFJedPybSTYbDO6Pr8SfmRhUvHWhp2YbAk99Zm2isPkS+sQTjAy0oCIFG2+mdf7f84P3K0uG9LtTwInhLOsUa3pmAFmkETh7KNPAODUlIxWURZa9cg40/6+FKFCi3rOD97qduBJvR9EqaWHjssCJUMhL6INU4Jhi/x2zZLsD9IM+AXZiZEwIbzjgIKyTT0f0eLqRp0X4A5Q9FUFzLb9HM2HcmOL+4JmSKfwmxoVnw0a+SYWJzDxGv1UpxHaHubbyTw56grOYppdQWbuLw1ewAHIFbBndF5IvA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR21MB1688.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(39860400002)(376002)(396003)(346002)(451199015)(2906002)(6506007)(38070700005)(186003)(66476007)(66446008)(5660300002)(38100700002)(41300700001)(52536014)(66556008)(921005)(7416002)(122000001)(4326008)(33656002)(86362001)(8676002)(26005)(7696005)(110136005)(8936002)(64756008)(66946007)(8990500004)(82950400001)(82960400001)(55016003)(54906003)(478600001)(71200400001)(76116006)(10290500003)(316002)(9686003)(83380400001);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hcDXCjmxA8NSnyf1af2LW2gORTq6g30BiEia6VVwhzzDG+YUqgAFH3y8rq32?=
 =?us-ascii?Q?FT/kuKbzL3UUrG+ko7z0hpvHKYz9ZvkOQcNG4IAKyUdxqdREsXTOmoY24R8V?=
 =?us-ascii?Q?HZSLD30HvB1+67UuLm/dOy4dG6nKW+p6YCQu1S9S0CPvTfqWNCzG6jlEENJB?=
 =?us-ascii?Q?mlwKxQ5FqaEtYHY+Rf5Lzvoh6MjjocFAF+h/d8uAwe4TUQ2V3n+ou+7959tJ?=
 =?us-ascii?Q?4d/FG7RzRw8oaW68nsfTeNm5hVNiH9od1E476E6MiRzaShROmRWIXSAOE8tJ?=
 =?us-ascii?Q?CDdvMX7czEB8ss5I0Fv3SdKbKAJ6+fBrzUlAqiuYP4bvB8KEEVlVLkVQkGuI?=
 =?us-ascii?Q?9NubeQkPauS2T6RG9ccJunXXk80/HWb30+5uHfnP/9L4Kmi/OR8/H3J3ICPb?=
 =?us-ascii?Q?jfAbhYaqWlLLPQby9VLRyn6O8fPZnrj3w5kPnE/4Fbg4OpZdrTyGV3JJBQhu?=
 =?us-ascii?Q?UhQnvvE5s6xX/AbXbb+xk4IAx7+3UkZjh6ng64darMvOnrzqDlUsubPiAOuw?=
 =?us-ascii?Q?ZKkO2y8kWe3n9T+l1bvrraloTR8fCICgKTfmGmNVw8AWC484651Phpoo7LJ5?=
 =?us-ascii?Q?kEly8eyVmnYu2XG30tPawAHfdu29KoIhElGehdyYc5AVQT+bfMyj4JlIDFg9?=
 =?us-ascii?Q?h+AIfvGf03ZOUe/TeH7yCrlUuyci9Qw99q4Ohwy+7WrpYlYvl7lw8vxUqmgd?=
 =?us-ascii?Q?yS8eFx78WU2NkC3ZzNdTsdJHmXm0NY5mnDDUGB0Zu6X79cA/xHK50w4/B139?=
 =?us-ascii?Q?QYy8AdR9ntR59arc6bH6J1jdh0cCFqwbOUoXQQ939y4UZ7OIwT1mc5bMKT0X?=
 =?us-ascii?Q?fvluIVgrQCPpbJhTz0SbZfMr6l6jHjsCe4ttauI0+8CP6pN8SVNHS4MJ7cna?=
 =?us-ascii?Q?0g/t+dURVK0hf2boMvwdyiSISdewpH0oxnO20lfWTPr5cGf1rCJDt2ivpz+V?=
 =?us-ascii?Q?jfEZGcmPvxdsz0g4K0Q5rbrJaxKjao+LyqO3WFoiZowRXdLJaBpBBfCVij+c?=
 =?us-ascii?Q?gkdRBIHEiL5HPa5nmxY0VzA8fmHnGWfsI3LGp8pcmQYOTgGhYYSvDtUfSH38?=
 =?us-ascii?Q?tIPo59OPfePjLkTR5TZ0i8HUYzOzVA6Q3e/Lfg3wrM3p1TanF+GtRWzQjGp8?=
 =?us-ascii?Q?gAafcGQT0v5W3fWc7Y8W2am/MwDqf2m7QpB0FdhSqh5MKtc7E4SjvkSwtIgy?=
 =?us-ascii?Q?aWqA4Ljv/JB8vgarIdnVnRRVpw1tsz0gfAMZqNtkj5PQIH9SzcqiRcb85Sir?=
 =?us-ascii?Q?tyo7wfa3/BqRIIkCRz1+y2yUa7AEWKIM3Nfh+cIbGizmDmmDNKDugiYwZJns?=
 =?us-ascii?Q?pBWuYQydZtiADO/YqZyoVxEzPa4RW5aaOuonoURCg7MSRgsjQMmWCPxKyTii?=
 =?us-ascii?Q?YJMQXIUDQHEcUAn6V6lksRc4dFbc3WrLmM7kEUvl0qbR9Tupj5PA+N25OAOH?=
 =?us-ascii?Q?dNg/cWl2I40W4dQmo1m4aDOo5jTX32rNDrQfHZKG3x2suQKb4I/3ShPo5nf0?=
 =?us-ascii?Q?WaWm/LW7ZUzg8d08OmUuk50RoXRawmBRkFcnu6Q7Mn6Yj+KrWhwN9hoUpU5o?=
 =?us-ascii?Q?2RV+REs6OFeMtEHLDwV1mONo4qlBFESVRFs8RiJTLO8dz12zAMoUtW9/7suF?=
 =?us-ascii?Q?Tg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR21MB1688.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c2b7b51c-f28a-44cb-6ee3-08dab762789f
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2022 14:57:58.4270
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TmAGfCHSUU/L4lx1QhMr8euiQI6Gbt7NQehrokIkTrE8UpQzqNhcREM5MCcU329XARGqypxxjoMYo9RvPmsjK5jd8d8psgk6fMiTgFlovV0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR21MB1870
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Anirudh Rayabharam <anrayabh@linux.microsoft.com> Sent: Wednesday, Oc=
tober 26, 2022 6:47 AM
>=20
> Fixes a couple of MSR access errors seen during kexec in root partition
> and opportunistically introduces a data structure for the reference TSC
> MSR in order to simplify the code that updates that MSR.
>=20
> Anirudh Rayabharam (2):
>   x86/hyperv: fix invalid writes to MSRs during root partition kexec
>   clocksource/drivers/hyperv: add data structure for reference TSC MSR

Could these two patches be sequenced in the opposite order, to avoid the
need to change the TSC code in hyperv_cleanup() twice?  The new
data structure for the Reference TSC MSR and clocksource driver changes
would be in the first patch.  Then the second patch would update
hyperv_cleanup() and could use the new data structure.

Michael

>=20
>  arch/x86/hyperv/hv_init.c          | 11 +++++++----
>  drivers/clocksource/hyperv_timer.c | 28 ++++++++++++++--------------
>  include/asm-generic/hyperv-tlfs.h  |  9 +++++++++
>  3 files changed, 30 insertions(+), 18 deletions(-)
>=20
> --
> 2.34.1