Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.200.110.1.12\))
Subject: Re: [PATCH] Periodically flow expire from flow offload tables
From:   Michael Lilja <michael.lilja@gmail.com>
In-Reply-To: <Y1kQ9FhrwxCKIdoe@salvia>
Date:   Wed, 26 Oct 2022 19:36:22 +0200
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Jozsef Kadlecsik <kadlec@netfilter.org>,
        Florian Westphal <fw@strlen.de>, netdev@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        netfilter-devel@vger.kernel.org, coreteam@netfilter.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <25246B91-B5BE-43CA-9D98-67950F17F0A1@gmail.com>
References: <20221023171658.69761-1-michael.lilja@gmail.com>
 <Y1fC5K0EalIYuB7Y@salvia> <381FF5B6-4FEF-45E9-92D6-6FE927A5CC2D@gmail.com>
 <Y1fd+DEPZ8xM2x5B@salvia> <F754AC3A-D89A-4CF7-97AE-CA59B18A758E@gmail.com>
 <Y1kQ9FhrwxCKIdoe@salvia>
To:     Pablo Neira Ayuso <pablo@netfilter.org>
Precedence: bulk

Hi,

I will look to use the flowable netlink interface. I have not yet, but =
does this possible give the option of doing something like this:

flowtable ft {
	hook ingress priority filter
	devices =3D { lan1, lan2, wan }
	flags offload, timeout
}


I would say the above it the most flexible, I just didn=E2=80=99t =
explore that, it would kinda be like with =E2=80=99sets=E2=80=99 where =
you can specify a timeout on when the entries should expire?


With regards to the IPS_OPPLOAD clear in flow_offload_del() then I added =
that because I saw some weird timeout side effects due to =
flow_offload_fixup_ct(), but I can re-investigate, it could be that it =
was early in my investigations and some of the other changes I made has =
made it obsolete.

Thanks
Michael