Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761430AbXHBVIz (ORCPT ); Thu, 2 Aug 2007 17:08:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761911AbXHBVI2 (ORCPT ); Thu, 2 Aug 2007 17:08:28 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:54726 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761815AbXHBVI0 (ORCPT ); Thu, 2 Aug 2007 17:08:26 -0400 Date: Thu, 2 Aug 2007 14:07:15 -0700 (PDT) From: Linus Torvalds To: Cal Peake cc: Chuck Ebbert , Gabriel C , Frank Hale , Kernel Mailing List , Kernel ACPI Mailing List , len.brown@intel.com, Thomas Gleixner , Ingo Molnar , Andrew Morton , Andi Kleen Subject: Re: ACPI on Averatec 2370 In-Reply-To: Message-ID: References: <5ebbd9b50707291105w316f98e5h3fa17204c9119a2f@mail.gmail.com> <46ACD8DB.2020108@googlemail.com> <46B22BDA.8090604@redhat.com> <46B23E08.4070106@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1340 Lines: 38 On Thu, 2 Aug 2007, Cal Peake wrote: > > Figured I should have sent that right after I hit the send key... > > processor : 0 > vendor_id : AuthenticAMD > cpu family : 15 > model : 72 > model name : AMD Turion(tm) 64 X2 Mobile Technology TL-52 Sadly, this doesn't show the "extended family" stuff from cpuid. So it doesn't show any of the bits we actually care about. Sad. That said, the "AMD Turion(tm) 64 X2 Mobile Technology TL-52" _should_ be a REV-F CPU afaik, and it should have thus fallen through to the "ENABLE_C1E_MASK" logic. Afaik that's broken. Cal - can you (a) test that forcing a "return 1" from that amd_apic_timer_broken() function fixes it for you. (b) make that function print out the values it uses for debugging (ie the xtended family and model numbers, and the MSR_K8_ENABLE_C1E MSR values)? Andi, can you check with your AMD contacts that those bits are correct.. Maybe the "Mobile Technology" things *always* have the broken "Enhanced Halt State", regardless of any MSR settings? That would perhaps be what makes them "Mobile". Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/