Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: /5xjH2xzZOuaS4i6wS+aQbz2Ael3EQG5YeICI38nsRO8P6IsufQ8uEkn+lXfmVdRiIQ/E1zMnn
 +7Ze9WbbHBEqnOZ9pGHj/oQYuhtp4QcubmpMy2Tg/zBX1+279a3y2v81dBR8SSHWDSePKQRflL
 5gtInonZrCf0KFfftrA0h2d1LLa8TI6SZ9q3nyLYG+uzlnNcb7e6BW02JxuWSfxVbIWW9PoHgi
 3l9Vn+1U2H/poVWkhyZQj6O73cYtJoJ/NJjKCkzxJQ0lWLrBQM3Yx5tPsjuTpRPELfTKkkDUAw
 tj0a2lmZx1Qn5eOAzG03aU5P
IronPort-SDR: LzAdDNRHO6tAxoUU5Eb2rQeGNrOfnmuWhdo7QITEj1fWZLS/+C595UeQHTjIBgPBd6KltiHKFO
 3U8YJlHNDTHdOAzgDOmcDavepJfTxs5y0+6LeL0aeLkrxXNpRbZJa9koL1BTg4YWyTIjHGYd+w
 j2vU7FQ56yRSA1caBKfdzXhQyUFCdMicik16wCMiqlGloGikq8Vi/lV3deiC73tZcBJ/W2ky14
 ee7cNff2J7oaNB7iD8yCxMXiY/1Ms0xrglHE0UsfCi+1Rjn52FkiDG+6f/y+hgQXGwdUwN5gHm
 87g=
WDCIronportException: Internal
Message-ID: <23b7b1f7-94c1-9c01-e1c8-c0a30a4aa06d@opensource.wdc.com>
Date:   Thu, 27 Oct 2022 09:30:52 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH] scsi: pm8001: Drop !task check in pm8001_abort_task()
To:     John Garry <john.garry@huawei.com>, jinpu.wang@cloud.ionos.com,
        jejb@linux.ibm.com, martin.petersen@oracle.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1666781764-123090-1-git-send-email-john.garry@huawei.com>
Content-Language: en-US
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <1666781764-123090-1-git-send-email-john.garry@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/26/22 19:56, John Garry wrote:
> In commit 0b639decf651 ("scsi: pm8001: Modify task abort handling for SATA
> task"), code was introduced to dereference "task" pointer in
> pm8001_abort_task(). However there was a pre-existing later check for
> "!task", which spooked the kernel test robot.
> 
> Function pm8001_abort_task() should never be passed NULL for "task"
> pointer, so remove that check. Also remove the "unlikely" hint, as this is
> not fastpath code.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: John Garry <john.garry@huawei.com>
> 
> diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c
> index 2359e827c9e6..e5673c774f66 100644
> --- a/drivers/scsi/pm8001/pm8001_sas.c
> +++ b/drivers/scsi/pm8001/pm8001_sas.c
> @@ -979,7 +979,7 @@ int pm8001_abort_task(struct sas_task *task)
>  	u32 phy_id, port_id;
>  	struct sas_task_slow slow_task;
>  
> -	if (unlikely(!task || !task->lldd_task || !task->dev))
> +	if (!task->lldd_task || !task->dev)
>  		return TMF_RESP_FUNC_FAILED;
>  
>  	dev = task->dev;

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

-- 
Damien Le Moal
Western Digital Research