Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     John Garry <john.garry@huawei.com>
Cc:     <jinpu.wang@cloud.ionos.com>, <jejb@linux.ibm.com>,
        <martin.petersen@oracle.com>, <linux-scsi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <damien.lemoal@opensource.wdc.com>
Subject: Re: [PATCH] scsi: pm8001: Drop !task check in pm8001_abort_task()
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1ilk6romi.fsf@ca-mkp.ca.oracle.com>
References: <1666781764-123090-1-git-send-email-john.garry@huawei.com>
Date:   Wed, 26 Oct 2022 22:23:27 -0400
In-Reply-To: <1666781764-123090-1-git-send-email-john.garry@huawei.com> (John
        Garry's message of "Wed, 26 Oct 2022 18:56:04 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?na3zeQpwYY52SEC9UJUYC8MAUbBs1XzmM1BMDzLeSLQ97VUS/xAZZvvgNGvx?=
 =?us-ascii?Q?njKzZQ2ID0/OAmmXu6BXIXZuiJuNwVDcnuLdg/sVNhImkQZMI5rx4qHeXI1q?=
 =?us-ascii?Q?DlJKrmwsiMyClPzloGlX5qHBCE2jQF9DHavsEG2+pzosKwWQ10058ISX0e6h?=
 =?us-ascii?Q?I7yMW2mAOZHybBs9Zlu84Exah/ePKSaxF4c6MwRFdxj1fWgMHJzZr5WIbSKu?=
 =?us-ascii?Q?Q9XpNyk7SCPusoKOwl49a4BqfJzwlxqn8NmmrQsxXI+X1COzWxaetdyjKMx6?=
 =?us-ascii?Q?I/TRhfu3s2KdIY7NiS6Ccoajhis+aPb0R0awEgEOJfO8WiIlW33KmGNBO9o9?=
 =?us-ascii?Q?0LiARCySgX1Ohjxb0VZN/yDNwxgae6L1nqpolkqZMkElPbs4SUCmBdSHMEVx?=
 =?us-ascii?Q?iGqacXjnVhZDd/j5Op55mEiobZaBEr0SyM1ydk/txu0H6KyrMUY78dHhp+At?=
 =?us-ascii?Q?FCnzWYg9xLhFab+aXotyhU+y8fcIS5OEDFqlmbUFueBnkfEGWFANdd3PMn6E?=
 =?us-ascii?Q?tOqXgGc3HvckU3rVzIyl4OC1MW0QCmaTS9z6xK8Gc0zflfmgkcFmbvqsoDa3?=
 =?us-ascii?Q?oxM4aFhuTWB8xXua95J+DDpdoTCilNPUZ4dMyVoOk/dHkjYAYlDDCa6VQSOC?=
 =?us-ascii?Q?k/iNrNa4CkMVIbdarD4TfgC+7FjwuLGJyfQJp+W9M4UUUG1+YrUcigSdprvj?=
 =?us-ascii?Q?k4ZraJEZQXs6F3OhIpz6lKTDk1ngD/My15/EcaRcv5L98rbsxnp4QcXbMHE2?=
 =?us-ascii?Q?SdhNEJjxHeVOfEGKw71iHoo8qa1YFqJNL/PrWkThiI08/MgUfbJRRaI1990v?=
 =?us-ascii?Q?e2HyGViGs8CWcL1bv9dxhRtklKtdqy0rqDKxBqJHMVCIEjOd7lmGNwovXVFe?=
 =?us-ascii?Q?hmG1v6W0ZSVmH6RKKRNShdwLvzzaq9R8azkU1ChRM6VcenAt0V1mgNtfnxE4?=
 =?us-ascii?Q?I187ZZ+dPRWiDmr6WhLRgF+fyzoRJyrAYamTxND3hyPNbzyW7ijXWNOeC3SF?=
 =?us-ascii?Q?xNBYQzzoGHNZceioWhkVyYo2X5EgqpXTWgliLBOJQ440xVfFi6X5AEI7vYWg?=
 =?us-ascii?Q?7j3dVmy5ZLBvub5OfqQlTLUFi6UoR+NBLV9Xtm1NYd+w7xUj6ZM2uF12de3h?=
 =?us-ascii?Q?KaV/Sum4NZDPw9CrO2Qr/Fex2tTuGGJn7Nsi2Dz8sL7pf7sVH2DWtF/YM8zO?=
 =?us-ascii?Q?uB8BTnNty1urOJFL1ym08xJ2b/F6wTgczcVC3LxzPD3Kzd62EtBBjYTaD+vw?=
 =?us-ascii?Q?9h9uRU5qU3hOKNLM2ci26ibz4rAVviybbHgakhiKus7WjunMDb5Ujs5eF+d5?=
 =?us-ascii?Q?n22rOYqT8501Vn97k5Uke3lWsbnANYhb0Hkdne5vjR0RNsGBWmqxz1ol7NpF?=
 =?us-ascii?Q?SbUjWMB8/MyBq2LIr54g1COwxdX4csZgkkIWg1aDDmYIZM70dktfsN0/8ZE/?=
 =?us-ascii?Q?gaAJr44oA2GW9JRSKLS2RqErIB8LzDxSoCNhc6j/NuR2/BE0syiNzQQ3/JLe?=
 =?us-ascii?Q?NJN4dU03quYef2/fea8YLRUjgTQ73TzqtZNeAXtYa/tZ5JhSN5/mNBNPZf/3?=
 =?us-ascii?Q?j6S4jqpLQr4DxI/t8tJdE/V9gOVHzKKcZWlJsjhRYUa2Zp84U6qjcbVH07KE?=
 =?us-ascii?Q?fQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b4893c57-49f1-435e-d299-08dab7c23ced
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 02:23:30.1666
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2Z28ZATvrJp89hdvwxPXkJuPrChUg6XFRFKbfpvU86bsnV+m08e/n25FjgG5MjZMa9yBw5R3h77UkvCkheeadaiq+UY1QkmYRxKUTlQrqmc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR10MB5955
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-26_10,2022-10-26_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 malwarescore=0
 phishscore=0 mlxlogscore=780 mlxscore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2210270012
X-Proofpoint-ORIG-GUID: -kIVUmHwHYyM_IYkm-A9iANltQSUM5aw
X-Proofpoint-GUID: -kIVUmHwHYyM_IYkm-A9iANltQSUM5aw
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


John,

> In commit 0b639decf651 ("scsi: pm8001: Modify task abort handling for
> SATA task"), code was introduced to dereference "task" pointer in
> pm8001_abort_task(). However there was a pre-existing later check for
> "!task", which spooked the kernel test robot.
>
> Function pm8001_abort_task() should never be passed NULL for "task"
> pointer, so remove that check. Also remove the "unlikely" hint, as
> this is not fastpath code.

Applied to 6.2/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering