Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Oct 2022 19:44:46 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Rob Herring <robh@kernel.org>
Cc:     linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        John Crispin <john@phrozen.org>,
        Sean Wang <sean.wang@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        =?utf-8?B?bsOnIMOcTkFM?= <arinc.unal@arinc9.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Vladimir Oltean <olteanv@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Lee Jones <lee@kernel.org>
Subject: Re: [PATCH v1 net-next 3/7] dt-bindings: net: dsa: qca8k: utilize
 shared dsa.yaml
Message-ID: <Y1nwnhjhb06mg0F/@euler>
References: <20221025050355.3979380-1-colin.foster@in-advantage.com>
 <20221025050355.3979380-4-colin.foster@in-advantage.com>
 <20221025212114.GA3322299-robh@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221025212114.GA3322299-robh@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?18Qax4U0NE+s0VmOiLzrRffrOPUjj4cZYm+bb9MAuTpj8TcjU5k7kaHDbiml?=
 =?us-ascii?Q?cFYpfW87SlxvgeeNeOwv1aRV5YqVt/8L3KEL3MUHYzIo4HhtbCe1pNuPfEaE?=
 =?us-ascii?Q?9d7o5FBXwNsNb/y2Vb4FzAxEnX4j5T/zGCha7avoGKsIBPtNRGQkBhQ727Rw?=
 =?us-ascii?Q?+5Pw25zDxN8aXK47Q9sfVIvMP8noegIM3FSFvhgaZrx5+Q5Fg1R/LILP42cC?=
 =?us-ascii?Q?mbdPD4fPKPz0CzktUlLorz5Qr89QrTLPcG8B0kkTWUPen7qcNB0pp5brhRmr?=
 =?us-ascii?Q?vgEoGGrSrr7rZSiuqOYxdEYtGqX92/iTZ+aiL4Q0BX8uqtYeZ+rsTJ84Nplv?=
 =?us-ascii?Q?l/MvZYZsxDSJL7tP+PJmXXOJ2hYiSqVjl5LQTCC1s+ulH5BWSjTy4RQCBVNg?=
 =?us-ascii?Q?/tXie1Ggr6SyKy4PZOwv0a7Inwth9KXh1VDON9oDjyWnFmwJuZY0oZmlWt2G?=
 =?us-ascii?Q?MjkWxard1KtFYM0TLsOfBySsny8z6XeNXv1LFD9NE8nyLicIFhCD8hunb0cq?=
 =?us-ascii?Q?AkjB7yEKg3e3UNq7jfIEE3WTK/afklNRAIedz05ujq70ieVs/m8e5Ui0caDT?=
 =?us-ascii?Q?lACgNpOubjS1lY+TB7/QgrWuA367q563VdfHuYiJFp3c3vWosBXRq4DLsV6z?=
 =?us-ascii?Q?gRXiq2hmTVNVGtXptwrM3WfylHtvTzUeq+kXClq7yHIP3kvrWMwhLYtNizC6?=
 =?us-ascii?Q?PiCF0aovYFbmjFAzouWEW74zOvvNpSf380aesNIQcbGVBh2nMw/a+A9UNtlE?=
 =?us-ascii?Q?1pD34St+M7r14OthqqR+HE8WJmaJeva9+JukKC9veVr13vCcDUeXun7FBeV0?=
 =?us-ascii?Q?R0gEdD7zhsILcShxLq/z+e/DtN2FbqhuYSTPyt08kFBcpuf4CHcpfXDnojHu?=
 =?us-ascii?Q?GE4g5dUJ+nLF/ZO2q0XnU9SXTx4DjJ1nh2VAPR6qXdO/rFHut/elfRMu2tkK?=
 =?us-ascii?Q?EtLVDhZuLBDCtPlhjisT+9OX/vc/2/IhKtOXQnU6dxJVnk1NTbU95OheDZCk?=
 =?us-ascii?Q?Gm1U5cmafYAqGkeORcxb78rvs+cblafWhHbYxHyQkdovZCZ2h9vU80+vOG8U?=
 =?us-ascii?Q?U9mqgA5BDa7g6TOrweKdJipixcVwVh5gl8KnNJkS0Eibimd+2OrqIXgEIBX/?=
 =?us-ascii?Q?QxuHQm+vhwZWtQPyA+ph6pOhRE9qqx1MCAXo+L4+ZOsOiK6rFGhFEgLyNWyD?=
 =?us-ascii?Q?YPUq9QTmzN8JdVQjA1MdA30b+4jAvLc9rB2Ni2VKjj9ERrsOalMrNEomg+Zl?=
 =?us-ascii?Q?NmbG+fCdUMhF3Pk4foyGyoTwaBMJVgBiYW3QLg/Rhj+ows5ITmC+l5I3hrtJ?=
 =?us-ascii?Q?Jcnm6g0GZ781ajmb0wT/9tsm9cBc8R0qbneJs+KqtUJVtCuj14gAI3epE5+O?=
 =?us-ascii?Q?0BfGtt9/aMiZxy3fh6YTLnFrNb/xNNm6yz0ttEEhf/XPe+wxwcIJtpBlp+5B?=
 =?us-ascii?Q?9319VoXLL2ca7zogtl/gCn7yNhMsaA/fUs7DXpGOU5s7w4K7IdliWtDEcB5Z?=
 =?us-ascii?Q?tM77S5uRer1wfFIStI6KwQqx8ZnpUq7pPYPN5rH0oVefD7p1IuYawT4VLEiu?=
 =?us-ascii?Q?VJYFEDFIp0cgjN+Fix94WiM1vuJ/eCCG5UBlBsdVSmi4/1KTUjzDmNIuck7a?=
 =?us-ascii?Q?gA=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e73aa49-c3f4-4764-e491-08dab7c53856
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 02:44:51.1442
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C3oXzabisqZUq1Yc49WMctuVeqYayjRrb2XelgQt05l3J2yu2tnRmNzvu/D0gvRYRXTV5FnSmLPw9ucgrSlqhN0risrCyhUvTydaVnZ7t1o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6609
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rob,

On Tue, Oct 25, 2022 at 04:21:14PM -0500, Rob Herring wrote:
> On Mon, Oct 24, 2022 at 10:03:51PM -0700, Colin Foster wrote:
> > The dsa.yaml binding contains duplicated bindings for address and size
> > cells, as well as the reference to dsa-port.yaml. Instead of duplicating
> > this information, remove the reference to dsa-port.yaml and include the
> > full reference to dsa.yaml.
> 
> I don't think this works without further restructuring. Essentially, 
> 'unevaluatedProperties' on works on a single level. So every level has 
> to define all properties at that level either directly in 
> properties/patternProperties or within a $ref.
> 
> See how graph.yaml is structured and referenced for an example how this 
> has to work.

Thanks for pointing me to this. I didn't know about
https://github.com/devicetree-org/dt-schema until now, so I'll take a
look. I was primarily reading the schemas in net/dsa/* to try to get a
full understanding of the DT schema nuances, so these types of nudges
really help me.

And I see that Vladimir Oltean has responded to other parts of the
email, so I'll leave this as a simple "thanks" and keep that context
going forward.