Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp88105rwi; Wed, 26 Oct 2022 21:07:53 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7aq7bCbEpvx9lrs2G29pKBQPi9Hu/XuIz9Rby9wb1c31JjvhNRf7WXj4b6ZJ6OZAJFlt7m X-Received: by 2002:a17:90b:3e88:b0:213:6442:5614 with SMTP id rj8-20020a17090b3e8800b0021364425614mr2181737pjb.58.1666843673721; Wed, 26 Oct 2022 21:07:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666843673; cv=none; d=google.com; s=arc-20160816; b=DyApIgLGCcwNEDiILnpb/Zkhv1WbHdVoVYbJfvllZTyHYEHkm1ckIUobl8EZlM7PdB pcgkka5AELj4ejkFcPlVaAMCr1umOOxsjwm96CcSygF37CUAz9aSyxXvmXXRWq0hRBZA gHAurY7CSd/mjjcUydkVfGnZRo9YYD4IeYmTVHhN7t5IotdW7fwYTVx4mH7dx+46QfLy YefBPM7pIfgyT8fncV2u9DSHRU97HlUfyH3g7ANnVB+aE00W9LiDRnaTy4UdcEtBtlC5 LlBOFN4KLxcQgWCisr5agu/bmFn4I77slOhBGe/1tIsRQi6h+OCTiDJxYYToFpdNAJT/ dLcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=E3umHsRF7moTRvOdQRgtkq59qZwZ82yKFNHkpQpaq9U=; b=SCISosHQwj9lpjMoBZpeSZOfuHkfhWIPPSCMGrxutqNpmN1vtXc+9PfqYsl9ihNHR6 eEM42ekDAr1eimXKD3O8WadG6gHWm7FDfyJ8A4Egdas1jZ6s3W/afGOdNFYeqZXbKYJV +NITEjDihZpzQX54buPjMvfGWVL3D3T8k4tIlUaE5scC4NeZEiZCO+RVLvEv8lEzIDUS x9QjDtvFvuVa3zxdh097Y4x8S0iXVB7fyFmGeOaPDCbx5pfSEqzmqsa4dXpM00l3kR51 oXPg8EuXca4jroXYINJ2ouF7jUYDFD9lFoINAx6CCrEs2ww7CwWTLSn/fxktghNoobq5 jj+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=U63FD2C3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l70-20020a638849000000b0045ceb2c2eb7si172764pgd.760.2022.10.26.21.07.42; Wed, 26 Oct 2022 21:07:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=U63FD2C3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234402AbiJ0Dkl (ORCPT + 99 others); Wed, 26 Oct 2022 23:40:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234471AbiJ0Dk0 (ORCPT ); Wed, 26 Oct 2022 23:40:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8C3E2CCA2; Wed, 26 Oct 2022 20:40:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 608E262157; Thu, 27 Oct 2022 03:40:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5531AC433C1; Thu, 27 Oct 2022 03:40:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666842018; bh=GyIfj4IMk1Z0HBO58cMK4cGISzPvw+zc6MisDvaFk9w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=U63FD2C3f+mnxAKh3hmd8a/fk7vemt+nCfPUkcwTmluNTTYDZ7bHp8AzkAfV6woPP wsNubL1QFMGF/2xOixBO4rPTPYw6ngwwUokk4Do/487B1s6Z10IgsaTCHEZo9KLgG+ EWGhGwoHIxoRzcwsWUq59pzDIncTDLriTgs3+cffVTF5F92kTjXb/2d1msfyJYB2yy 04xlO61IbgysK8TBX9qB13YXRmjQXuYrYItjiIkIYQrTgwwq4ZOJhQtqr132TKcKey YXwfSXfQvkzK4pbos3J4CtlYG/dib7VAGM2v0RIj/+BV0HA+jrwK8HIzwadaZvG/2A OIA2ys4fPDhuA== Date: Wed, 26 Oct 2022 20:40:17 -0700 From: Jakub Kicinski To: Alexandru Tachici Cc: , , , , , , , Subject: Re: [net v3 1/1] net: ethernet: adi: adin1110: Fix notifiers Message-ID: <20221026204017.0a0afff5@kernel.org> In-Reply-To: <20221025075227.9276-2-alexandru.tachici@analog.com> References: <20221025075227.9276-1-alexandru.tachici@analog.com> <20221025075227.9276-2-alexandru.tachici@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Oct 2022 10:52:27 +0300 Alexandru Tachici wrote: > + int err; > + > + err = adin1110_setup_notifiers(); > + if (err) > + return err; > + > + return spi_register_driver(&adin1110_driver); What unregisters the notifies if spi_register_driver() fails, now?