Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0887669d-fc6a-1382-a272-e231014a196f@os.amperecomputing.com>
Date:   Thu, 27 Oct 2022 10:39:36 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [PATCH v9 8/9] mfd: Add Ampere's Altra SMpro MFD driver
Content-Language: en-CA
To:     Lee Jones <lee@kernel.org>
Cc:     macro@orcam.me.uk, Bagas Sanjaya <bagasdotme@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Jonathan Corbet <corbet@lwn.net>,
        Derek Kiernan <derek.kiernan@xilinx.com>,
        Dragan Cvetic <dragan.cvetic@xilinx.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Thu Nguyen <thu@os.amperecomputing.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Open Source Submission <patches@amperecomputing.com>,
        Phong Vo <phong@os.amperecomputing.com>,
        thang@os.amperecomputing.com
References: <20220929094321.770125-1-quan@os.amperecomputing.com>
 <20220929094321.770125-9-quan@os.amperecomputing.com>
 <Y1aHiaZ1OpHZIzS9@google.com>
From:   Quan Nguyen <quan@os.amperecomputing.com>
In-Reply-To: <Y1aHiaZ1OpHZIzS9@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGR6Z2ZUTDR6dDdOMStUdkw1Um1sZ1dWQllYMGJpR29UQWsxWFZLeVh3Y2sz?=
 =?utf-8?B?V05QLy8vaGV2MEF4Wk5vdFljR2NXZkpHNXZMRkcxeFp3bGJPNW1jbWFKTmFz?=
 =?utf-8?B?U0xRYUNjd3VmSllkZU11SlBvbEM5cnRGVjQwd2FWdnhtalZTV21NQ3VoUXR5?=
 =?utf-8?B?Y1ppR1NHa0pkeEFrVHI5K1htQjJGbDhCWjQwTitlK21UNkZLREJQaitsVEIz?=
 =?utf-8?B?b1JTcS9obDcxaS9wbzB6aGEyMFBHMTFlWU5qT0wvNEV6K1N6YXRueWU4bTVX?=
 =?utf-8?B?MzdTQkZTQ0hkMkJSM0NrWTlBVWNLV3JpYVR1SndlU1hlTGlwV2krM0VNdmpi?=
 =?utf-8?B?c2tVaFZCU29iUXNXamdDRGR0K1RRVW45VUNsTVYybGpIcFJEU25DbW1aTnJx?=
 =?utf-8?B?VHNHemZ1cWFWMHphZGh1eHh2MUNTNkQ1TE8rbnNuNkVVV2U4bDFic0IxUGQr?=
 =?utf-8?B?V1ZLeFFsYzNsOG4vSDdJTWQzZmNCZWZpTEFXVDgwbW1WL1dYcTNtdG0vbjBB?=
 =?utf-8?B?U3NLNlpkcU9ENk5kOC9MbHpBeUw2dHpFb1lpcHFlb0VIMTM5ak84Q0d2L2hH?=
 =?utf-8?B?Z1BDZnd3WkZmR0N3ZVNIOWdnd2RVdXdVaDlHQkx5UWM4U0lkYnlvbWlaRS9n?=
 =?utf-8?B?OXFYNCtKOWM5cjl5eWhwaldIYWlJb3pDTTAvVGVwVjRnek0rV0svTkZsdFNW?=
 =?utf-8?B?azI1ODJRdVZJbHJXZUVsYUY2aVQrZVhzYzlua3pUTlJXRXhLNGlPYWFMSmM5?=
 =?utf-8?B?WnJteHlBb3Z4NUlHL05JMjl4MWFsUGE1UGE3SER3TzJuL3ByWkxZTXJuMVVQ?=
 =?utf-8?B?eDJET09ZWEgwdFhaa3Y5SGZrU2tmUFI0TFltZnVrUHRDWmF0Y09pUGpHbGdH?=
 =?utf-8?B?WFlhMzFzY3pvMTE4SlZPbjRCL09tNnRXOUQvTUdEOVRxdGdEUEtLQUlIcTNT?=
 =?utf-8?B?RVhDNFZGMmxBYzNqTHJkdTFGUEJ3elhKRW5Ic0ZUWUQzWk8zZEFOZ1huNm0x?=
 =?utf-8?B?S0V6UHJhMXlKMHJlbDlFZzdxdlduNGxxeEpNK2ZFcHJmYWZsRzI1bmtRQUp2?=
 =?utf-8?B?M2tPL0d2MTZwNytBZmdTUmNpZFRvU1BrTTVZc3BaYkFvdFplUTYybDZZVDF3?=
 =?utf-8?B?OEl0TlZiTDJkVXMvWW1ESysxZDh3b0VlSm1RUzBIUFVUcTllWTZSMVl3SzU2?=
 =?utf-8?B?ekoxWkhxZ24yNVRIU3JKd1VxdW8xM0ViWFZqSEZqbXR0V0p2N3RvR3J4RzRu?=
 =?utf-8?B?TG1ndTJFaVllZjFMWHV3NTBGWUhmYXRYaUsybGxpQkxVRXBhai9Nb1kzZFpo?=
 =?utf-8?B?Y3pKcFdaa2lQQ0c4YVFxbENTbkpvVllmaFMvMm5id29tOE5PeWRwQ1ZoTGhY?=
 =?utf-8?B?eTJvZXdJVHBRay9Ca1hXQ1YxQjlXeWh4MjlrZGpqU3NxSlVEY1BzQitpZDVH?=
 =?utf-8?B?WlF0NytEZVRjMkNyWlhGVlBiOUxDODljRzR2cmxHUzFvRldQVXpKTjZRWmVT?=
 =?utf-8?B?SmNPVzQvOGFZMVYyZnlVeC8xNHNISzJ4eGJHZmRQUGZGU1dUQyt0cnFicHd5?=
 =?utf-8?B?MHZUQUs2K2kzSVlzRUs0ZHNEdmw3QkZ6K3NNNHVnYU1Sd0lDNGFWNk1KWGtU?=
 =?utf-8?B?R1BsVFB3Z2Y5YUkwMGpxR3NYMk5hVW0vV1ZFeGRZVVFWZWJIVWN0QmFIcEph?=
 =?utf-8?B?STdTTnAraHJSL1pITHJqLzFZTXRnS0ZjT1pFamlEc3k1K1R4U3d5akZKSkZs?=
 =?utf-8?B?WUM2ZDI5RDVQVzdmVzVycituck5YT1JhS0lVcTVmV3hwOUtYMVI2OGVxV1h6?=
 =?utf-8?B?ck1IalR4aWZGb2NUbVpQMUdRMlpvbTdIeVVOdlRTOFE2akxaNHJIT3RxNXBQ?=
 =?utf-8?B?L0RvZytmWFdnamh1K3FHbENJVVFUSE55Y3RoS2ZXVzE2ZmxBakhoTkpRaDBo?=
 =?utf-8?B?MFVvSmd4L290K0U1WmFkbW1Ua2NobWxzRkdIVVhBeFhOTDljRmJQOGJKcXFt?=
 =?utf-8?B?SVlBM0QzNXY5TkVyRFcvM29wZFRQVjZkOFdtM05UUVUxTUUrZCs5ajJIMllr?=
 =?utf-8?B?V3FEREczaDVXRlBlaFRQUkpsMU9wOXNrN0RWWlBQZTRpVjJ0cVJ2WmtMODBj?=
 =?utf-8?B?UGZHcFpkNDhMTnV3TVR5ZkFUenZYQkFuVTNiSktiSmR5Rmx2UElHb2F3VHF2?=
 =?utf-8?Q?PVRw/z0MTMVv4Ce+PlbRotk=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ec6b9c9c-6df5-4ad0-6380-08dab7cce5f8
X-MS-Exchange-CrossTenant-AuthSource: SN4PR01MB7455.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 03:39:48.8181
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5ZJrdj4Ze/Qylcn+Lmn4ZX+vY/HKJuuE+u4KWuMkzHeCfxPZqlZgqVcEdULN9jxcXi/8/RQ01sN2+tGoefuZrvowXg0Xupmk3Sa4fXeLMwY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR01MB4992
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 24/10/2022 19:39, Lee Jones wrote:
> On Thu, 29 Sep 2022, Quan Nguyen wrote:
> 
>> Adds Multi-function devices driver for SMpro co-processor found on the
>> Mt.Jade hardware reference platform with Ampere's Altra processor family.
>>
>> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
>> ---
>>
>> Changes in v9:
>>    + Rename smpro-mfd.c to smpro-core.c                   [Lee Jones]
>>    + Fix include files in alphabetical order              [Lee Jones]
>>    + Add defines to avoid using magic numbers             [Lee Jones]
>>    + Return -EINVAL if device does not match              [Lee Jones]
>>    + Remove unneccessary comment                          [Lee Jones]
>>    + Refactor error path handling in smpro_core_read/write()   [Quan]
>>
>> Changes in v8:
>>    + None
>>
>> Changes in v7:
>>    + Smpro-mfd now significant changes in compare with simple-mfd-i2c
>>      driver, remove the copyright note about simple-mfd-i2c    [Quan]
>>    + Install bus->read/write()  to handle multiple types of bus
>>      access.                                                   [Quan]
>>    + Update license to MODULE_LICENSE("GPL")                   [Quan]
>>    + Add others minor refactor the code                        [Quan]
>>
>> Changes in v6:
>>    + Update license part to reflect that this driver is clone from
>>    simple-mfd-i2c driver [Quan]
>>
>> Changes in v5:
>>    + Dropped the use of simple-mfd-i2c driver [Quan]
>>    + Introduced drivers/mfd/smpro-mfd.c driver to instantiate
>>    sub-devices. This is to avoid DT nodes without resource issue [Quan]
>>    + Revised commit message [Quan]
>>
>> Changes in v4:
>>    + Add "depends on I2C" to fix build issue found by kernel test
>>    robot [Guenter]
>>
>> Changes in v3:
>>    + None
>>
>> Changes in v2:
>>    + Used 'struct of_device_id's .data attribute [Lee Jones]
>>
>>   drivers/mfd/Kconfig      |  12 ++++
>>   drivers/mfd/Makefile     |   1 +
>>   drivers/mfd/smpro-core.c | 138 +++++++++++++++++++++++++++++++++++++++
>>   3 files changed, 151 insertions(+)
>>   create mode 100644 drivers/mfd/smpro-core.c
> 
> Applied, thanks.
> 

Thank you for picking the patch.
- Quan