Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8d806632-aef7-a56f-9934-c07a0defdc5f@os.amperecomputing.com>
Date:   Thu, 27 Oct 2022 10:39:26 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [PATCH v9 1/9] hwmon: smpro: Add Ampere's Altra smpro-hwmon
 driver
Content-Language: en-CA
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     macro@orcam.me.uk, Lee Jones <lee@kernel.org>,
        Bagas Sanjaya <bagasdotme@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jean Delvare <jdelvare@suse.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Derek Kiernan <derek.kiernan@xilinx.com>,
        Dragan Cvetic <dragan.cvetic@xilinx.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Thu Nguyen <thu@os.amperecomputing.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Open Source Submission <patches@amperecomputing.com>,
        Phong Vo <phong@os.amperecomputing.com>,
        thang@os.amperecomputing.com
References: <20220929094321.770125-1-quan@os.amperecomputing.com>
 <20220929094321.770125-2-quan@os.amperecomputing.com>
 <20221026150001.GA2545504@roeck-us.net>
From:   Quan Nguyen <quan@os.amperecomputing.com>
In-Reply-To: <20221026150001.GA2545504@roeck-us.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTVXV2xkRC9xTTdIaVdmVkRXZmcrYmRYdExtMkY0VWZTNHAxYTVEYk5hNmNO?=
 =?utf-8?B?NjBFNEJwUnYvakVpRHpVbGNiZmUreGpmVE5HV1VCVG9TcmJCTGhzY0tjbE5y?=
 =?utf-8?B?WWVsWXNMeXhQYzNFNTNxeEpBNGtKdXBGSWxrdlROYXF1YWp3Qm4xT09abXUy?=
 =?utf-8?B?SENYeHcySDhVM0hEc2VUUkhxSmFXTlpGMitTY0Y4OGNpT2JPOWIrNGZzUFlk?=
 =?utf-8?B?TmdVSGtMUlJLa1JvUzJadHE4d2ZUbUdVc25YRnlIbFVPblRJenQrbnR0VVN3?=
 =?utf-8?B?L0p1MTBPL3E1dDZiZklzU1NKS0ZZU1M3ZzVORTExUUV1cjFkN3B3QS9LQVVG?=
 =?utf-8?B?cEw0Z1p0VHVtMmRBTC8vSHlndktVNjJiSllaYkRXenpJR1VnTDQzRTVvZ0tX?=
 =?utf-8?B?ckgxM1lGZk9DS0hXbTBhaW94QmNUTmIyWC9CbnhzTHZaeUxjKzAvNEpuQnhp?=
 =?utf-8?B?bEdCT2x4N3ByeWVmRThLekNRcXVmRmNPV0g2TVNWQ2E4T1ZCblc2UVlNT3cy?=
 =?utf-8?B?dGR5Z3dBNWI4Q3A3UzFiUzNhbzVKRTNsckxFQzZBMDhwUG8vSk9PU3paOGRF?=
 =?utf-8?B?VHFMUlFkSGE4VHNqSGZYKyttdHUvQjNWMmc1dnBPcmRoQVVEUUVJYWpoQlAy?=
 =?utf-8?B?ZzRzTG9sMlhmWXhFVmxMY1AvMTBkRFZJRS9QSzB6RXFkeG50Qmh3UmcyMExs?=
 =?utf-8?B?Q2xnYXByODdMaHpJaWZvYTZibitrUURkT1FOK1YzTk9pbDJpOS9mQ2xmVnpl?=
 =?utf-8?B?MHhhV212blBZN1dnSzNHOHpTSTRDNHIwYlhsd0J3VCtQWXJQN0pmYlZSSWda?=
 =?utf-8?B?Ty9DV3MvQlJSODcvcnp1ZC8wMXppSmJJQ1FrUjA0TXJNRDdQMWZBMVFucWho?=
 =?utf-8?B?T1lTTnFtWUpPNGFZRXJxT1VWS0NlMTExc0FaaUZJU2hQK2tLK0pCc0J1UnpF?=
 =?utf-8?B?dWlmWkhrTGpwenhkNHdVdGM5R2J6TWVrZlliR2xaL1hyOXdlWDMzbWZDUzJW?=
 =?utf-8?B?aUVST0hlMWcrcktzTW9YZFRxWFlaWWF1cFprWnlGbkdYaHFaOHlFUHVmdFJq?=
 =?utf-8?B?UCswYnd4Ym5CbWdVTDNoLzhnOU9mNU9qZ1owOGNwVFd3Q1I4dkpaMXJKRHBJ?=
 =?utf-8?B?aVJ1NXM1ZlB3cXBiWDJSWUcrNlQwcGJMN1dYbS9Xc1FONmMyMDhMTFZiSUxw?=
 =?utf-8?B?bHBjKzFCT1lzSjdBVjQ3ZDdTek1PcnhuSVNhcHZxRHd0aUtWdjBzR2dzWnMz?=
 =?utf-8?B?SHZ5My8xUG9LdFVHdyttNGFRWjR3bTYvZlFHT1BGV3RBWGZpbDVFZERWRHMz?=
 =?utf-8?B?eHZleEpubm1WTU5KRzg4OEUwVzM3NjErQnh5TThwdlp1R0NnbGxub0h4NEhE?=
 =?utf-8?B?Mm5Sclc2ckJHbDRWZFVYZEx6Q3VhUGNBNmRJSWVjZ1RnZmdIcCsxWWM4ZVpR?=
 =?utf-8?B?QUZJSEJ5YS9TdldTaldJTkxQbzZoYWtId0hWdWM0RjVtcGQrSUdVQUlTOWNn?=
 =?utf-8?B?RGVQYTdkTENydEVYR0NJbmNhSVV6c3JDYnZyZnZJeEZmQUdQRE0wdEcyWWV5?=
 =?utf-8?B?MEVaNDJFR0ZOVjFXeTRSYWQzWEdSQ3Z4SWxsSmJ4QVhCdTM0QVFIVmE2UkN3?=
 =?utf-8?B?OEZkZlAwbWEzcUwzd0EzbzR4VnpoVHJSbHIySGhjMS9iNUphVFh6cklPbzBs?=
 =?utf-8?B?L2tPMDVJVUo4RnNwMzMwbWFpcHkzcnB1SnBlVTVMaVpRaVlVS1o3NklnM2tm?=
 =?utf-8?B?OEprV0Uza1h2TCt4eE1sYVZneVhIaFNaV2tEeUgvaGdHT3hCSkxYeXRROEVD?=
 =?utf-8?B?ZmYxcGdNSS9QcC9aU0poUXhQMnlzZStBTGJDN05Ib09qZVNwekk1N25QWDdL?=
 =?utf-8?B?ZWVST3hNYjFwVjQ2M3ZoTTk0V2ttVG1BSTRnZVpXYjFEbUxmSWkxOWdyOW9K?=
 =?utf-8?B?ZXFoTHdYWm5ZQVVDdFFjcFJvRnBCL0Nla09udWhMUTNkNEdVZ0lvN1hmRDU5?=
 =?utf-8?B?VldDZUpXa29EMjA4OE1vWU5iVnNmcHFPeXBDWWZDeWZqMUwzMW1XeEZiVnN0?=
 =?utf-8?B?MVFVdllUaVBJUW1ISWY1cHJDVmRZSllBeGJ5SXdWdGIydkhVZkdTTkhpNjky?=
 =?utf-8?B?R25CT0h0WStwZWx3L3ROVDJ4ZU5XT2k3LzNJMjVvMXNPSWdORkxpL1I1RGZV?=
 =?utf-8?Q?VCmlpEcE+qU+6H+B5e/770s=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33d8c37b-66d1-4497-3ead-08dab7cce2cb
X-MS-Exchange-CrossTenant-AuthSource: SN4PR01MB7455.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 03:39:43.6902
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ODJ6NL2VPUrru9cd6WNLyas4qMcGlMsLh4kalpNP1r/9bAIoofqJz8zYQ3ADA8dOXaoOuhl8+ZaH7h30xjsJCsxz5l1T0O54F3SWV45H+vA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR01MB4992
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 26/10/2022 22:00, Guenter Roeck wrote:
> On Thu, Sep 29, 2022 at 04:43:13PM +0700, Quan Nguyen wrote:
>> This commit adds support for Ampere SMpro hwmon driver. This driver
>> supports accessing various CPU sensors provided by the SMpro co-processor
>> including temperature, power, voltages, and current.
>>
>> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 
> I see that the mfd patch was accepted into the mfd subsystem,
> so I'll apply this and the next patch in the series to hwmon-next.
> 

Thanks Guenter for picking the patches.

There are two issues found by Bagas [1] in document format and kernel 
test robot [2] on smpro-hwmon.c. I'll fix them in separate patches.

[1] 
https://lore.kernel.org/lkml/Y1aHiaZ1OpHZIzS9@google.com/T/#mfea2167b99384486a1b75d9304536015116c1821
[2] 
https://lore.kernel.org/lkml/Y1aHiaZ1OpHZIzS9@google.com/T/#mc86afb1ae9d332f152e0fb0d1908dac667519871

Thanks,
- Quan