Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Oct 2022 20:57:02 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Rob Herring <robh@kernel.org>
Cc:     linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        John Crispin <john@phrozen.org>,
        Sean Wang <sean.wang@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        =?utf-8?B?bsOnIMOcTkFM?= <arinc.unal@arinc9.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Vladimir Oltean <olteanv@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Lee Jones <lee@kernel.org>
Subject: Re: [PATCH v1 net-next 7/7] dt-bindings: net: mscc,vsc7514-switch:
 utilize generic ethernet-switch.yaml
Message-ID: <Y1oBjtQeZlzwMfoD@euler>
References: <20221025050355.3979380-1-colin.foster@in-advantage.com>
 <20221025050355.3979380-8-colin.foster@in-advantage.com>
 <20221026174704.GA809642-robh@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221026174704.GA809642-robh@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3mrh1udW5gb2LUvNBbAJ1ggPglZMsXt4vZLKwKUPczkrP0W9V4++b1SaAqp2?=
 =?us-ascii?Q?Gj9GI2LAp75YfS0xdyxl9ojT5RMW62VGdtTkXCKCsm6Ep6bRU+eJh8T7Bkeg?=
 =?us-ascii?Q?suMVAvUmzaZGK0XY64fPNo6jb6IGExmV+q8acZEy+HXXQjFdQ5uFAoNWV0+U?=
 =?us-ascii?Q?QjhtqwFzKaaax2QuIBNsTHsgByPBnfc1iLz5Os2Ip/nToxxeXlAwc81cLGjW?=
 =?us-ascii?Q?TAYaD4nUq5fi8eG7rTmiIRCFYTHdYhNZut+B9y3HKEzZW+jv+r7gQak324Vo?=
 =?us-ascii?Q?kSP5BlvEuFadfGejaO7bJvmfUG4J/JvycjF5/+tCXksiVB87Y2UsJRdOPIy9?=
 =?us-ascii?Q?kikB7pDby+c2ri7nx3gvMm+lWAZOYUeXmPEntDjvSc8NKoSlh474beENwpan?=
 =?us-ascii?Q?9aF7ej5JiPNcj9Df9P66XOZJmdSh6P3mEnBdcRVeVcrFV8N5/320wBmXLKJd?=
 =?us-ascii?Q?gBpnixcYGTRHNmV8RfURnvUqkPo5vtUsdA+DfwKfW7v2G0Zfa4NfbymSZLyN?=
 =?us-ascii?Q?hbypj3UF85j5safJ+tC2pTFTTfIVs+0nGXHJjCbcWC+TbfG2mpw//ioLKu/o?=
 =?us-ascii?Q?2jVyCqzOwxSURSPzEaYWevhi9G+ikU3ZakeyAfncaNdAT/XV+/HfZyJp7pXX?=
 =?us-ascii?Q?bnFcF4RD44BH7TGAkAYZSAvW/zmYj1Q6R1xSVuvnx4QzBF08EjdL39+3EzN3?=
 =?us-ascii?Q?+PdKPadAt9AvAPVB9Ntn6KvVWVR69oldQeKR1tazRZ4/9G0+5LWNLdbVaLCz?=
 =?us-ascii?Q?dB0uvL+k1hjiDLgSzOebk2T6uWYRZd1VoWsQEQEITNxQB9WZYQh4L1POR1i4?=
 =?us-ascii?Q?JLYYRvjPvrKwKDA6Wsk2vTZ1+UeA82qiOHy09rI+8P5rC4dzExR2KOofcbxg?=
 =?us-ascii?Q?gtIJYZGgGIRajJuiSYoqUeAaVO/2tVUnTFRSZQwH49qcsRSs25xoAvZ7l+xL?=
 =?us-ascii?Q?Eo5k7j5kpyxSHhVXWOki7Wcda/wwWaM7JSOlB3K7j5C0fHi9dcPmrQqBLHkp?=
 =?us-ascii?Q?I2DySD4GBNKfXXPYuTP00GvjgnbZrGgLA6KXYzixTjVf7fzcoDQjXfA9eMIk?=
 =?us-ascii?Q?nH+u/5GGzeAMxEpRNpenfl26An2GqW16UAdlxqtvLcBbvrS0CZijSNNZnp1B?=
 =?us-ascii?Q?bCwWo7i5MZHwSGgMysEGhcuGcD4C6e/ES3Ky3DfVvAGXU4aQw9PDcg1kGj5i?=
 =?us-ascii?Q?5m+puriguDyqCJR9LPvvepn6esJv90975uZyKRMSKHlDVejyCMP8K5sjP1UQ?=
 =?us-ascii?Q?AYe3ghr4hxMr1VKavwgrwuAAsb93+ZVrGgpVQzreI3jwxncyrV3Q6JxoWrL7?=
 =?us-ascii?Q?4hgOEfGR6ID47OpDQYWM6frUBED1073cBRIAEeFSQyri2KS+PS7tRmo0hnnZ?=
 =?us-ascii?Q?uFgKpY7/Mwrp+1BBZ3UDozhVQ88/v0tCyfuL9l6XMl6C/cdtGS4oG+TqDYPN?=
 =?us-ascii?Q?ru9/mpG0ucuNnm9dbVodsVbM/qecIR45u4mIAtVW/7QBZz56WO+TaHn6maX0?=
 =?us-ascii?Q?8TGAiPsc+uSRUY67TY6Gc1x7BvbimAFIw7C+Ao9mwcHT1wMXQ72iXbAF4BOX?=
 =?us-ascii?Q?aNYWPeB69sY/BlBIxLfifq+L9pm5mQ7xU0uzdeasfF6LlnS8cNZJyzaozUA9?=
 =?us-ascii?Q?JaSk5DeoJor6biUgWv5/SxY=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e61922c1-d781-48b6-1db8-08dab7cf4fd3
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 03:57:09.2473
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +aqkp3kNrPyO1Ga3d2WbblIq+AEMaDPoea3ZWhQwNYcadxmP8eABXjTb3DIx0jQn20tJ4s+YKO9wBtbWk+JqU+3BmqMTvGe5guFPchZTkBo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5631
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 26, 2022 at 12:47:04PM -0500, Rob Herring wrote:
> On Mon, Oct 24, 2022 at 10:03:55PM -0700, Colin Foster wrote:
> > Several bindings for ethernet switches are available for non-dsa switches
> > by way of ethernet-switch.yaml. Remove these duplicate entries and utilize
> > the common bindings for the VSC7514.
> > 
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > Suggested-by: Vladimir Oltean <olteanv@gmail.com>
> > ---
> >  .../bindings/net/mscc,vsc7514-switch.yaml     | 36 +------------------
> >  1 file changed, 1 insertion(+), 35 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> > index ee0a504bdb24..1703bd46c3ca 100644
> > --- a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> > +++ b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> > @@ -19,11 +19,8 @@ description: |
> >    packet extraction/injection.
> >  
> >  properties:
> > -  $nodename:
> > -    pattern: "^switch@[0-9a-f]+$"
> > -
> >    compatible:
> > -    const: mscc,vsc7514-switch
> > +    $ref: ethernet-switch.yaml#
> 
> ??? 'compatible' is a node?

I need to look more into this. The compatible string should remain
mscc,vsc7514-switch, but I think the pattern properties should
probably be updated to "^(ethernet-)switch@[0-9a-f]+$" to match
ethernet-switch.yaml.

I didn't think the ethernet-switch.yaml could be at the top level for
the 7514, but I must have been mistaken. Either way - not under
compatible as you're pointing out. Much appreciated.

> 
> Rob