Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Oct 2022 21:06:08 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Rob Herring <robh@kernel.org>
Cc:     linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        John Crispin <john@phrozen.org>,
        Sean Wang <sean.wang@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        =?utf-8?B?bsOnIMOcTkFM?= <arinc.unal@arinc9.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Vladimir Oltean <olteanv@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Lee Jones <lee@kernel.org>
Subject: Re: [PATCH v1 net-next 6/7] dt-bindings: net: add generic
 ethernet-switch-port binding
Message-ID: <Y1oDsKfRKHC1Mok9@euler>
References: <20221025050355.3979380-1-colin.foster@in-advantage.com>
 <20221025050355.3979380-7-colin.foster@in-advantage.com>
 <20221026174421.GA794561-robh@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221026174421.GA794561-robh@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XAJd07R2z0whrU2wi6PSvHz+fn8emWYsvL9wRwfUa3NXjOB6M3MHdyiAZDdN?=
 =?us-ascii?Q?n6Wd3otWcaklP3uXIRyXQ5yzGsI8arxV9IE7nzWj+rBGkX2CX1y+UF6itMU8?=
 =?us-ascii?Q?aJ4IdQyHUucVFAxCFVGVDupSUTEYmw4sFPig2U+NsGfchXj0+vgJgzn4SRDc?=
 =?us-ascii?Q?2V6I0G4Sge/6hMzvYQxbOrD3tTe7HvqzozVr6h502z/5MBdRHtb/pWz5x5AQ?=
 =?us-ascii?Q?ofCST+tvVRVkcisphT6vEtYoiakCIlfnerLMgwknV8rsvY8Y0PWAOocXtRY7?=
 =?us-ascii?Q?uECWENxdlReu6IF5D75WUTD+nTzE6fJXk3iKWAwDcdetj43Vd3lpzO9UgS9a?=
 =?us-ascii?Q?FnUtvDNKqeUKQoo2jipPfI6Jn9mwAm6LCuNHzX+ZjTJkltn9CuqZgoy1IfX/?=
 =?us-ascii?Q?vG35xsx8yVbtSX0XGDGYp5qoQfd8k8hB9lRsbvk6JwSKizdwWonKKV86+Feb?=
 =?us-ascii?Q?UalfxtVsKNe/DA42rEIaHUZOvjKzx15CqyGN+2TDLen2bzPLbE9j1ystZgpL?=
 =?us-ascii?Q?F6om4+JwHXHut5WarQeXH0J1YX3F/ihKzDOAn3OHvMcGq+uF4kP+7La8bD0e?=
 =?us-ascii?Q?idVrmAERhCax4UQghvC40cVJNzToZEWFCAfFt0Ik6eYHpJLTNlybN9TwC7HU?=
 =?us-ascii?Q?nlLHcLkCQE9xWOcP/5LzITPe6Flwjwg7PYqqaRYZIJpQeQMAuNgvrteEF203?=
 =?us-ascii?Q?5bRm9GYu0u88u0wss4FLy2fmODTIr9P+LjqrJWYpXmfD0Q8naT2O2JszgWQV?=
 =?us-ascii?Q?gGx4tRUl7fONexMtr4UD5Yklsdx9w4r144+Y6E8v98YB9l+dH+THr+E4beCn?=
 =?us-ascii?Q?ajgNk9udIZ9YocacKZsfraIcr24qjq3KU8hmGM258D3TfFkNBG8lSiFcAd++?=
 =?us-ascii?Q?ErAZmgSgbISys71KIuFCwBJsONOjzrfHNB3RdBBj2gP3YMdgThUwOaMs+r2R?=
 =?us-ascii?Q?HJCrkQUsfJTxA+h9ZiJZsyErrCMLurz4UvXRQEJmGdcnzDhpeWiEg8+X4ZeB?=
 =?us-ascii?Q?w1M+mXcB0DuSlpotHVLCAUfxttAZb+toUtQwNyAcHREgsaFi5EEDQw8FvzKq?=
 =?us-ascii?Q?5OagfkcMUwhBjscCvl4DYULnBY/ny05VGhX4zwCVRvRPT1UHjnevEfJh+sPb?=
 =?us-ascii?Q?ENmLjLVFzld9CqrMcQunjQAqu7slU/lID36hsYJCH0HPi77+782R64Cf45uN?=
 =?us-ascii?Q?TMF/DoF/JzscxR6X581HeRZvAY8h/JE4oR0K11cfZEMpHy3cOVagRdMRNmV+?=
 =?us-ascii?Q?m1Z+8OuzJ1vU2u+KFMn+VJQuasKJkWZFNKYn46rLOdPCG5IFPR2k0Y44fb08?=
 =?us-ascii?Q?QmDPt7czvimtNz3iM2E5VmYsDXnTvQT9pz1gvye4zuc3M17hXmmCD4nB7dIw?=
 =?us-ascii?Q?RYvOBVpmXUvbYUNGLeiijbDJPLTaNC/HyIWuyOTym7C1PcqITwwGjVyuyuzF?=
 =?us-ascii?Q?HeMDFm1XYHefjZmLlAhMfL/YQaj7ewVLtsSLbnD0JFQ8hh+rtrnv23Ae7Aia?=
 =?us-ascii?Q?7Ue/wLcCHxF5aiLJIDGuEAqAmkZvsyOVUJxUPEGusWfUsrZkJDQBkKGAbNeb?=
 =?us-ascii?Q?EZbP0MHF/dytb+sv8G1OXhepttDMGaMSTDY07xnjXeo/TwBM1Zj0nOazXw2n?=
 =?us-ascii?Q?CfW829WNHtF0942IM+L656E=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ee4f566-e50d-471c-c269-08dab7d0966a
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 04:06:13.4599
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JQEFHzdZQqgl7a107pewH+9AG88HuU+2OucNVqk6Lt3zIyLzZNf2+i98KzNbWLbDfzI+32PaPJzhuUxnSioOqPE0GNzPaIy5xxUTHT9+rIg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR10MB6138
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 26, 2022 at 12:44:21PM -0500, Rob Herring wrote:
> On Mon, Oct 24, 2022 at 10:03:54PM -0700, Colin Foster wrote:
> > The dsa-port.yaml binding had several references that can be common to all
> > ethernet ports, not just dsa-specific ones. Break out the generic bindings
> > to ethernet-switch-port.yaml they can be used by non-dsa drivers.
> > 
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > Suggested-by: Vladimir Oltean <olteanv@gmail.com>
> > ---
> >  .../devicetree/bindings/net/dsa/dsa-port.yaml | 26 +----------
> >  .../bindings/net/ethernet-switch-port.yaml    | 44 +++++++++++++++++++
> >  .../bindings/net/ethernet-switch.yaml         |  4 +-
> >  MAINTAINERS                                   |  1 +
> >  4 files changed, 50 insertions(+), 25 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/net/ethernet-switch-port.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml b/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml
> > index 10ad7e71097b..c5144e733511 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml
> > @@ -4,7 +4,7 @@
> >  $id: http://devicetree.org/schemas/net/dsa/dsa-port.yaml#
> >  $schema: http://devicetree.org/meta-schemas/core.yaml#
> >  
> > -title: Ethernet Switch port Device Tree Bindings
> > +title: DSA Switch port Device Tree Bindings
> >  
> >  maintainers:
> >    - Andrew Lunn <andrew@lunn.ch>
> > @@ -15,12 +15,9 @@ description:
> >    Ethernet switch port Description
> >  
> >  allOf:
> > -  - $ref: /schemas/net/ethernet-controller.yaml#
> > +  - $ref: /schemas/net/ethernet-switch-port.yaml#
> >  
> >  properties:
> > -  reg:
> > -    description: Port number
> > -
> >    label:
> >      description:
> >        Describes the label associated with this port, which will become
> > @@ -57,25 +54,6 @@ properties:
> >        - rtl8_4t
> >        - seville
> >  
> > -  phy-handle: true
> > -
> > -  phy-mode: true
> > -
> > -  fixed-link: true
> > -
> > -  mac-address: true
> > -
> > -  sfp: true
> > -
> > -  managed: true
> > -
> > -  rx-internal-delay-ps: true
> > -
> > -  tx-internal-delay-ps: true
> > -
> > -required:
> > -  - reg
> > -
> >  # CPU and DSA ports must have phylink-compatible link descriptions
> >  if:
> >    oneOf:
> > diff --git a/Documentation/devicetree/bindings/net/ethernet-switch-port.yaml b/Documentation/devicetree/bindings/net/ethernet-switch-port.yaml
> > new file mode 100644
> > index 000000000000..cb1e5e12bf0a
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/ethernet-switch-port.yaml
> > @@ -0,0 +1,44 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/net/ethernet-switch-port.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Ethernet Switch port Device Tree Bindings
> > +
> > +maintainers:
> > +  - Andrew Lunn <andrew@lunn.ch>
> > +  - Florian Fainelli <f.fainelli@gmail.com>
> > +  - Vivien Didelot <vivien.didelot@gmail.com>
> > +
> > +description:
> > +  Ethernet switch port Description
> > +
> > +$ref: ethernet-controller.yaml#
> > +
> > +properties:
> > +  reg:
> > +    description: Port number
> > +
> > +  phy-handle: true
> > +
> > +  phy-mode: true
> > +
> > +  fixed-link: true
> > +
> > +  mac-address: true
> > +
> > +  sfp: true
> > +
> > +  managed: true
> > +
> > +  rx-internal-delay-ps: true
> > +
> > +  tx-internal-delay-ps: true
> > +
> > +required:
> > +  - reg
> > +
> > +additionalProperties: true
> > +
> > +...
> > diff --git a/Documentation/devicetree/bindings/net/ethernet-switch.yaml b/Documentation/devicetree/bindings/net/ethernet-switch.yaml
> > index fbaac536673d..f698857619da 100644
> > --- a/Documentation/devicetree/bindings/net/ethernet-switch.yaml
> > +++ b/Documentation/devicetree/bindings/net/ethernet-switch.yaml
> > @@ -36,7 +36,9 @@ patternProperties:
> >          type: object
> >          description: Ethernet switch ports
> >  
> > -        $ref: /schemas/net/dsa/dsa-port.yaml#
> > +        allOf:
> > +          - $ref: /schemas/net/dsa/dsa-port.yaml#
> > +          - $ref: ethernet-switch-port.yaml#
> 
> dsa-port.yaml references ethernet-switch-port.yaml, so you shouldn't 
> need both here.
> 
> I imagine what you were trying to do here was say it is either one of 
> these, not both. I don't think this is going work for the same reasons I 
> mentioned with unevaluatedProperties.

Oh, that was definitely a mistake for me to reference
ethernet-switch-port.yaml. And that was exactly requested of me when
Vladimir helped guide me down this path:

"""
6. The ethernet-switch.yaml will have "$ref: ethernet-switch-port.yaml#"
   and "$ref: dsa-port.yaml". The dsa-port.yaml schema will *not* have
   "$ref: ethernet-switch-port.yaml#", just its custom additions.
   I'm not 100% on this, but I think there will be a problem if:
   - dsa.yaml references ethernet-switch.yaml
     - ethernet-switch.yaml references ethernet-switch-port.yaml
   - dsa.yaml also references dsa-port.yaml
     - dsa-port.yaml references ethernet-switch-port.yaml
   because ethernet-switch-port.yaml will be referenced twice. Again,
   not sure if this is a problem. If it isn't, things can be simpler,
   just make dsa-port.yaml reference ethernet-switch-port.yaml, and skip
   steps 2 and 3 since dsa-port.yaml containing just the DSA specifics
   is no longer problematic.
"""

I might have been testing to see if this was necessary and since I
didn't notice any dt_binding_check errors this might have slipped into
the patch set. But my intent was to reference both here and remove the
reference in dsa-port.yaml.

> 
> Rob