Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a0f29483-9557-9900-bcb7-ec832dc5d2d1@linux.intel.com>
Date:   Wed, 26 Oct 2022 21:17:36 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.2
Subject: Re: [PATCH 0/5] Parse the PCIE AER structure and set to relevant
 registers
Content-Language: en-US
To:     LeoLiu-oc <LeoLiu-oc@zhaoxin.com>, rafael@kernel.org,
        lenb@kernel.org, james.morse@arm.com, tony.luck@intel.com,
        bp@alien8.de, robert.moore@intel.com, ying.huang@intel.com,
        rdunlap@infradead.org, bhelgaas@google.com,
        linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, devel@acpica.org
Cc:     CobeChen@zhaoxin.com, TonyWWang@zhaoxin.com, ErosZhang@zhaoxin.com
References: <20221027031458.2855599-1-LeoLiu-oc@zhaoxin.com>
From:   Sathyanarayanan Kuppuswamy 
        <sathyanarayanan.kuppuswamy@linux.intel.com>
In-Reply-To: <20221027031458.2855599-1-LeoLiu-oc@zhaoxin.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/26/22 8:14 PM, LeoLiu-oc wrote:
> From: leoliu-oc <leoliu-oc@zhaoxin.com>
> 
> HEST PCIE AER error source information describes the Uncorrectable Error 
> Severity, CorrectableError Mask and other aer register's value to write to the

/s/CorrectableError/Correctable Error
/s/aer/AER

> bridge's Correctable Error Mask register.

Can you add spec reference?

> 
> leoliu-oc (5):
>   ACPI/APEI: Add apei_hest_parse_aer()
>   ACPI/APEI: remove static from apei_hest_parse()
>   ACPI/PCI: Add AER bits #defines for PCIE/PCI-X bridges
>   ACPI/PCI: Add pci_acpi_program_hest_aer_params()
>   ACPI/PCI: config pcie devices's aer register
> 
>  drivers/acpi/apei/hest.c      | 121 +++++++++++++++++++++++++++++++++-
>  drivers/pci/pci-acpi.c        |  92 ++++++++++++++++++++++++++
>  drivers/pci/pci.h             |   5 ++
>  drivers/pci/probe.c           |   1 +
>  include/acpi/actbl1.h         |  69 +++++++++++++++++++
>  include/acpi/apei.h           |   9 +++
>  include/uapi/linux/pci_regs.h |   5 ++
>  7 files changed, 300 insertions(+), 2 deletions(-)
> 

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer