Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chancel Liu <chancel.liu@nxp.com>
To:     lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
        tiwai@suse.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, robh+dt@kernel.org,
        devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
        shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com,
        nicoleotsuka@gmail.com, linuxppc-dev@lists.ozlabs.org
Cc:     Chancel Liu <chancel.liu@nxp.com>
Subject: [PATCH 3/3] ASoC: fsl_sai: Specify the maxburst to 8 on i.MX93 platform
Date:   Thu, 27 Oct 2022 14:03:11 +0800
Message-Id: <20221027060311.2549711-4-chancel.liu@nxp.com>
In-Reply-To: <20221027060311.2549711-1-chancel.liu@nxp.com>
References: <20221027060311.2549711-1-chancel.liu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?D6AdaQdT6bkgIqrp9AzhDYutaVnkzsvi+peQh168yVKKHKXyjxgkwWIsLl/d?=
 =?us-ascii?Q?5wD9BGCoOLm0pgzh7KYgaE9KFg1aILxk/u9A2HYogeyvPCZgmVnNGbuH7FaY?=
 =?us-ascii?Q?uZKKwEcbHI7uaJI3jesStcz1+N856/YvksClxM3kAeFLBFuVrpgQ8OfkD+KC?=
 =?us-ascii?Q?koSSGmif3cIPXHEE6PxpDQ5JPKb5lvGcmFo60q/knHF7/iZmHIOyQtTTsEyB?=
 =?us-ascii?Q?OngV75tpbhBUDUh1iKhiTOOzWYPWhZ4HRNpMe/L68onFelv8xWxmrLmfuUDA?=
 =?us-ascii?Q?+7tRa3/Sj/qnenv52ywxoQytmSAIp9r0mlnrpGAn9WXFNW+i6c+oSfqU39/o?=
 =?us-ascii?Q?fMYCI+XTGDksWr0QHqJR8e/vz7sjy+OciQmptvNW4CRSYgEl8VwayVOmpY6I?=
 =?us-ascii?Q?htYh5JHv/PXTQ6glYjlSLjyjng6YXSBImVPhIvO+AIoyfG6R8G+FexS6WgEI?=
 =?us-ascii?Q?LCipHcJ3mV4LHHFpWig6ljCal/UTuB4yckED7PTTjhvte/T4GMUwI/DzVHfL?=
 =?us-ascii?Q?JruYsf+NNoa2H5O35w3vOMNdBGHiWSuYkrlPd7S65zceNxgkinXLnBjKkCYi?=
 =?us-ascii?Q?2rUTcxL+8AFAWx6tlaVbQTcvtGMknfnnRslnbXwiAJ+8zkH+gWI5z0HvuaNt?=
 =?us-ascii?Q?EIAPU4wa6BOlV5ffxPUiOhrtetehJnQeoGhysCsGrSD1gvASF/nUE74Iq/Cc?=
 =?us-ascii?Q?I+t1tUH7w33k/0PqM3XC5XIYmJHaLbg6wndkIyFZnAW7pHz/ksAX/JxXS6D7?=
 =?us-ascii?Q?mgzMhScUrcwL123xfeOpzn8kj7eoa0rTt2WEh+L7PiqFJRwB8G0/MD3MRBDd?=
 =?us-ascii?Q?D4Da8jz1yW71JigVezQNe9tr7/D7A/MDQqMCkofKPfzjx0MUNqx7Jg70jw+N?=
 =?us-ascii?Q?lA/tNlcU9jpVmcrk/ASB20L7t8xRVP2eZqPjQWN2j5F+h/vkPd62Qop5+TxX?=
 =?us-ascii?Q?pgke90rNDT4lyW2XiGlcy7vQjJkPCQpPfdO+NjoEzow4jP8ctY0UYB4K7YAZ?=
 =?us-ascii?Q?D6S+n2AnXohmJqhpTszFkBeCjhVYfkhsmsv/rVdvwIlclTQ65tUDHdUkx8MQ?=
 =?us-ascii?Q?zzKaFAMYMd7rA0WGrIC+MYr5uSJKspHMGBrdiof5vKc/DNqqxyHJexlXxImj?=
 =?us-ascii?Q?5IxiN7Pi/LV/cSpS4xkZyaYMbhuQak/Ya44bF9TRB5O5gqfmFK8GaEjgNbwE?=
 =?us-ascii?Q?7w23rKh3pnkHLt8zUigIZg1zhQG4jklT+nfJetroFFy1tiVz7RBshu+2vbDr?=
 =?us-ascii?Q?tAIDAazc2baUQYlpO5TU1wSqQI858bq2PLjSlTQMYZ5vFaCsxCBEq49cKBOC?=
 =?us-ascii?Q?Cay2a5YwkfY1P+pWEZzTYMIChY6hjY2cblDFvOFqFtH4SYdetbYtf18jB7dn?=
 =?us-ascii?Q?jXv0i+KP+F0qO/FVWDxkxxqNjSaijr5vlyDWqLwgmKVjzHdAmHMvQOa+pn2I?=
 =?us-ascii?Q?3eN7rOa4y008cXHxPgyX9O6gPpsBH6sGViTbsuC7mQEz1piZEydh68vF4CWy?=
 =?us-ascii?Q?zJrYJrbs3urAC+bGpCwyCKpKe04HfsrGrXwsV0oxpzGLNfmbgpbfA0jyvfk9?=
 =?us-ascii?Q?xA0LHDd7ogUeft7XCPn2xI0ck24lmRQXankb41fE?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f07e1b64-bee2-4e40-e658-08dab7e10fd8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4222.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 06:04:08.9775
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5t8nk18vpx2jo2CzCmblUxT0mpLJaJms6QSmN+1R/nW6Uco/awhEyQBqZhyAmcTo+1lMBDrZYB6y+ROWNbg/5w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7593
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

There is a limit to eDMA AXI on i.MX93. Only TCD that has NBYTES in a
multiple of 8bytes can enable scatter-gather. NBYTES is calculated by
bus width times maxburst. On i.MX93 platform the value of maxburst is
specified to 8. It makes sure that NBYTES is a multiple of 8bytes.

Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
---
 sound/soc/fsl/fsl_sai.c | 11 +++++++----
 sound/soc/fsl/fsl_sai.h |  1 +
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
index 68e1cc4c369a..a0ea27f06997 100644
--- a/sound/soc/fsl/fsl_sai.c
+++ b/sound/soc/fsl/fsl_sai.c
@@ -872,10 +872,10 @@ static int fsl_sai_dai_probe(struct snd_soc_dai *cpu_dai)
 
 	regmap_update_bits(sai->regmap, FSL_SAI_TCR1(ofs),
 			   FSL_SAI_CR1_RFW_MASK(sai->soc_data->fifo_depth),
-			   sai->soc_data->fifo_depth - FSL_SAI_MAXBURST_TX);
+			   sai->soc_data->fifo_depth - sai->dma_params_tx.maxburst);
 	regmap_update_bits(sai->regmap, FSL_SAI_RCR1(ofs),
 			   FSL_SAI_CR1_RFW_MASK(sai->soc_data->fifo_depth),
-			   FSL_SAI_MAXBURST_RX - 1);
+			   sai->dma_params_rx.maxburst - 1);
 
 	snd_soc_dai_init_dma_data(cpu_dai, &sai->dma_params_tx,
 				&sai->dma_params_rx);
@@ -1416,8 +1416,10 @@ static int fsl_sai_probe(struct platform_device *pdev)
 
 	sai->dma_params_rx.addr = sai->res->start + FSL_SAI_RDR0;
 	sai->dma_params_tx.addr = sai->res->start + FSL_SAI_TDR0;
-	sai->dma_params_rx.maxburst = FSL_SAI_MAXBURST_RX;
-	sai->dma_params_tx.maxburst = FSL_SAI_MAXBURST_TX;
+	sai->dma_params_rx.maxburst =
+		sai->soc_data->max_burst[RX] ? sai->soc_data->max_burst[RX] : FSL_SAI_MAXBURST_RX;
+	sai->dma_params_tx.maxburst =
+		sai->soc_data->max_burst[TX] ? sai->soc_data->max_burst[TX] : FSL_SAI_MAXBURST_TX;
 
 	sai->pinctrl = devm_pinctrl_get(&pdev->dev);
 
@@ -1588,6 +1590,7 @@ static const struct fsl_sai_soc_data fsl_sai_imx93_data = {
 	.pins = 4,
 	.flags = 0,
 	.max_register = FSL_SAI_MCTL,
+	.max_burst = {8, 8},
 };
 
 static const struct of_device_id fsl_sai_ids[] = {
diff --git a/sound/soc/fsl/fsl_sai.h b/sound/soc/fsl/fsl_sai.h
index 697f6690068c..197748a888d5 100644
--- a/sound/soc/fsl/fsl_sai.h
+++ b/sound/soc/fsl/fsl_sai.h
@@ -235,6 +235,7 @@ struct fsl_sai_soc_data {
 	unsigned int reg_offset;
 	unsigned int flags;
 	unsigned int max_register;
+	unsigned int max_burst[2];
 };
 
 /**
-- 
2.25.1