Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221026020200.29222-1-zhaoping.shu@mediatek.com>
 <CAMZdPi-bAw293XWBQL0wZS-nO_COD=ZOBduBVicof87HyEmS3w@mail.gmail.com> <7e8434e1fc683de62400dd93ea7a248e28e1efaa.camel@mediatek.com>
In-Reply-To: <7e8434e1fc683de62400dd93ea7a248e28e1efaa.camel@mediatek.com>
From:   Loic Poulain <loic.poulain@linaro.org>
Date:   Thu, 27 Oct 2022 08:28:23 +0200
Message-ID: <CAMZdPi-8dRVioPUWcOABZsT53mQrji1sDjMWnLQzdXKhBd4-rA@mail.gmail.com>
Subject: Re: [PATCH net v1] net: wwan: iosm: fix memory leak in ipc_wwan_dellink
To:     "zhaoping.shu" <zhaoping.shu@mediatek.com>
Cc:     m.chetan.kumar@intel.com, linuxwwan@intel.com,
        ryazanov.s.a@gmail.com, johannes@sipsolutions.net,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, srv_heupstream@mediatek.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        haijun.liu@mediatek.com, xiayu.zhang@mediatek.com,
        lambert.wang@mediatek.com, "hw . he" <hw.he@mediatek.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 27 Oct 2022 at 04:08, zhaoping.shu <zhaoping.shu@mediatek.com> wrote:
>
> Hi Loic,
>
> On Wed, 2022-10-26 at 09:50 +0200, Loic Poulain wrote:
> > Hi Zhaoping,
> >
> > On Wed, 26 Oct 2022 at 04:02, zhaoping.shu <zhaoping.shu@mediatek.com
> > > wrote:
> > >
> > > From: hw.he <hw.he@mediatek.com>
> > >
> > > IOSM driver registers network device without setting the
> > > needs_free_netdev flag, and does NOT call free_netdev() when
> > > unregisters network device, which causes a memory leak.
> > >
> > > This patch sets needs_free_netdev to true when registers
> > > network device, which makes netdev subsystem call free_netdev()
> > > automatically after unregister_netdevice().
> > >
> > > Signed-off-by: hw.he <hw.he@mediatek.com>
> > > Signed-off-by: zhaoping.shu <zhaoping.shu@mediatek.com>
> >
> > Could you please add a corresponding 'fixes' tag.
> This issue was introduced in the first commit of this driver:
> Fixes: 2a54f2c77934 ("net: iosm: net driver")

Ok, fine, then simply send a V2 with that tag.
You can append mine as well:

Reviewed-by: Loic Poulain <loic.poulain@linaro.org>


>
> >
> > > ---
> > >  drivers/net/wwan/iosm/iosm_ipc_wwan.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/net/wwan/iosm/iosm_ipc_wwan.c
> > > b/drivers/net/wwan/iosm/iosm_ipc_wwan.c
> > > index 2f1f8b5d5b59..0108d8d01ff2 100644
> > > --- a/drivers/net/wwan/iosm/iosm_ipc_wwan.c
> > > +++ b/drivers/net/wwan/iosm/iosm_ipc_wwan.c
> > > @@ -168,6 +168,7 @@ static void ipc_wwan_setup(struct net_device
> > > *iosm_dev)
> > >         iosm_dev->max_mtu = ETH_MAX_MTU;
> > >
> > >         iosm_dev->flags = IFF_POINTOPOINT | IFF_NOARP;
> > > +       iosm_dev->needs_free_netdev = true;
> >
> > Look like we have the same problem in mhi_wwan_mbim driver, would you
> > be able to submit a change for it as well?
> We will submit another patch to fix it, since this patch is dedicated
> for iosm.