Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760920AbXHBXGq (ORCPT ); Thu, 2 Aug 2007 19:06:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756327AbXHBXGi (ORCPT ); Thu, 2 Aug 2007 19:06:38 -0400 Received: from viefep18-int.chello.at ([213.46.255.22]:15440 "EHLO viefep28-int.chello.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756290AbXHBXGh (ORCPT ); Thu, 2 Aug 2007 19:06:37 -0400 From: Daniel Ritz To: Andrew Morton , Linus Torvalds Subject: REGRESSION: serial_cs broken by 8250 changes Date: Fri, 3 Aug 2007 01:06:32 +0200 User-Agent: KMail/1.9.6 Cc: Yinghai Lu , Bjorn Helgaas , linux-kernel@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708030106.33917.daniel.ritz-ml@swissonline.ch> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 860 Lines: 20 commit 18a8bd949d6adb311ea816125ff65050df1f3f6e breaks serial_cs badly with an oops, completely killing PCMCIA. register_console() now calls console->early_setup(). which in case of 8250.c (the only user anyway) is serial8250_console_early_setup() which is __init, calling 8250_early.c:serial8250_find_port_for_earlycon() which is __init as well. boom. the changelog mentions SERIAL_PORT_DFNS removal which happens to be commit 7e92b4fc345f5b6f57585fbe5ffdb0f24d7c9b26. but this got reverted by commit 57d4810ea0d9ca58a7bcc1336607f0cede0a2abf. so i'd suggest to just revert the 8250 changes as well. rgds -daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/