Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Oct 2022 10:28:09 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>
Cc:     Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>, noralf@tronnes.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] drm/gem: Check whether object is NULL in
 drm_gem_vunmap()
Message-ID: <Y1ozCWTco6dzIA7J@kadam>
References: <20221026224640.7542-1-dmitry.osipenko@collabora.com>
 <20221026224640.7542-3-dmitry.osipenko@collabora.com>
 <6b37315d-74d0-713a-3544-b8d4c873488d@amd.com>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6b37315d-74d0-713a-3544-b8d4c873488d@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?hIytbyyUacCJdS/CBD2vJR/0t892My8/I4mbgd7nwYl59btZnqaOVTrQSg?=
 =?iso-8859-1?Q?lmiGcrIAqsZqcpoVHpOCKde0vqU6i22rKFKVTi8ilFm09a3Xol1Cr0/Epp?=
 =?iso-8859-1?Q?IFFiY8i6JV/0KTBrrbjRlgSFLNHOB3AzkSiARmRTPmH94TlMd4BcMeSemr?=
 =?iso-8859-1?Q?rqX2iUS3vvgVTlMVLZXBD9dZrZLtqZowXAjivnwG7WzvVhyBxPXYo+6F+X?=
 =?iso-8859-1?Q?mCvpk9b/Rb2Y5Xcroid96gX0n6wC1xh6EDHPkMXME7mtMZJ27geX68emUO?=
 =?iso-8859-1?Q?n8XktlfCjY0gHqsu4kkHbQw4eRVE5bUKwhfV3zLqE1vhnkxkCSXFfbpWfy?=
 =?iso-8859-1?Q?emVSQFcq3xD91YzJCmglP6PPcDmgIhUE0p9Ay3+Jq8KQ/Seigai1Lajp2Y?=
 =?iso-8859-1?Q?UaSH81qtWC01GbP1O2ELf9afCEUewET/mqBfR7j7RJhzLRZFGuORHaDagz?=
 =?iso-8859-1?Q?pfzlddBGir3twB1ARVhLFQyIX3LLV7BLbzWIXpOK0Rcpd9l7pLt89WRw33?=
 =?iso-8859-1?Q?FktdDnPEgcvq755fPQgZ5wR4UwfjOIUVT0YzFfu0cNOwGx+XeQXwzrvnOb?=
 =?iso-8859-1?Q?TKO9aCmNu5EGLCkpmr5Qkfqiu0fruSoTaXAXivXrrqxknzHxw7lg5aeTra?=
 =?iso-8859-1?Q?B5HrpU4Y69GyQ9F7gH5FVW7zNnikJc4/p9EuMky8qtUzRK9kTuiPLYzNOK?=
 =?iso-8859-1?Q?viyX6SiYWC3ISHNLrmBUQO23KVJ4Z+4VhtAc4aKApMYG9lYCMAUu85E3BC?=
 =?iso-8859-1?Q?967Fb2O8FKmrQpSa4xkbnfd3GQ1T1r8BYYNdd+VDqErM9dmx04k44rGL3e?=
 =?iso-8859-1?Q?yIfcR8jCdEIZZsZVKYz2gzs+mtBtYMJXZBNPuNT6fRCTTUPGlKUivYK91W?=
 =?iso-8859-1?Q?9pT3IFkqZH0cRrlrc3djSqsnxCbk831vfU+eFxMRKEZRpvrx4JJVSOXjp0?=
 =?iso-8859-1?Q?ZRz5JHvbWVZZWZyFaaOwA8T67yhNwtex38p5OhrpI3CNrVYV9tQAtoEUKN?=
 =?iso-8859-1?Q?WsYcEOwn/XBf3krL93IASftpfe0Quo3MUh+4mtN3rOyyepKE2q4ryD8bhe?=
 =?iso-8859-1?Q?WVrTLJUYdkYraQAFxwMDXvqSrv4szymze/2P54dzsUS2wnG/8M/nE+s0fj?=
 =?iso-8859-1?Q?krO7ZngdizIBjmClMt8qKTM394tOOZCEdhwNyygAnu9qwz3bmzkDig/12b?=
 =?iso-8859-1?Q?AeA2grfzomJoPDa5gZLFDcM5n5aO575GXt8hUpRrxg2Fji+GYQINqQ+HeW?=
 =?iso-8859-1?Q?fpWYBMmkEfXeQIPNCgOmzB7E4IlMm5mOr0BG8WkTVu/uW020Pvi5sVeZeW?=
 =?iso-8859-1?Q?PJ22+cpawwGTbDdQBL+3CzKAb4t4OLh1Fh/ny2yFNkJIZx5wFWhf+GGw2J?=
 =?iso-8859-1?Q?TFR5Z2O4K1fnmlZkRZKWb1RW99dGXLHSbH1WU4KSs6IJH9xQnP70gXfca2?=
 =?iso-8859-1?Q?MnIOGJUQr2WB0LtnrXMgw702IkNwLI1GGgUsVv5wIw60gTJadbSlBh535q?=
 =?iso-8859-1?Q?mO7p6TsZO0dQb/SM60hUDxppWIk8lFERo1G5tWHZroTHWNoOV/Y+j5su7r?=
 =?iso-8859-1?Q?RhMHBK0UMUuuQ4Lr/iEcTcZCm7FvLV4Z5RstBU7BZx1EcZXMNcINkO6CGv?=
 =?iso-8859-1?Q?kWRk7Hqm6dwjXwEN3uBOKGpRt/ENXasaCuXjTFaMZyY5/2j5U5fsbixg?=
 =?iso-8859-1?Q?=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 958f0c91-f514-4b05-c4c6-08dab7ecd38b
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1001MB2358.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 07:28:22.1757
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2BYjixnZkhRr8fu9oR8drUZhEfvupLydExubSQXHXty7uvjr8zytsPuN/2dw5IgpBtFVHN+x1+jKWuKfYvnfi+aJwWOABgY6GuY7AqSR3u4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6147
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-27_03,2022-10-26_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 adultscore=0 malwarescore=0 mlxscore=0 suspectscore=0 bulkscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2210270041
X-Proofpoint-GUID: GSfmEYrhINJ7iAVEMA5xzjSrQEweNGPI
X-Proofpoint-ORIG-GUID: GSfmEYrhINJ7iAVEMA5xzjSrQEweNGPI
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 27, 2022 at 08:17:31AM +0200, Christian K?nig wrote:
> 
> 
> Am 27.10.22 um 00:46 schrieb Dmitry Osipenko:
> > The drm_gem_vunmap() will crash with a NULL dereference if the passed
> > object pointer is NULL. It wasn't a problem before we added the locking
> > support to drm_gem_vunmap function because the mapping argument was always
> > NULL together with the object. Make drm_gem_vunmap() functions to handle
> > the NULL pointers better.
> > 
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Link: https://lore.kernel.org/dri-devel/Y1kFEGxT8MVlf32V@kili/  Fixes:
> > 79e2cf2e7a19 ("drm/gem: Take reservation lock for vmap/vunmap
> > operations")
> > Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> > ---
> >   drivers/gpu/drm/drm_gem.c | 9 ++++++---
> >   1 file changed, 6 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> > index b8db675e7fb5..ee0a246ff4ac 100644
> > --- a/drivers/gpu/drm/drm_gem.c
> > +++ b/drivers/gpu/drm/drm_gem.c
> > @@ -1175,11 +1175,11 @@ EXPORT_SYMBOL(drm_gem_vmap);
> >   void drm_gem_vunmap(struct drm_gem_object *obj, struct iosys_map *map)
> >   {
> > -	dma_resv_assert_held(obj->resv);
> > -
> > -	if (iosys_map_is_null(map))
> > +	if (!obj || iosys_map_is_null(map))
> >   		return;
> 
> I'm not very keen about that. Calling a function with all parameters NULL
> doesn't make much sense and is clearly a coding error. Hiding that somehow
> doesn't help but rather makes things worse.
> 
> The only execption to that are things like kfree() or *_put() which work
> with the lifetime of objects.
> 
> Why is the static checker complaining about that in the first place?
> 

drivers/gpu/drm/drm_client.c:240 drm_client_buffer_delete()
warn: variable dereferenced before check 'buffer->gem' (see line 238)

regards,
dan carpenter