Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Oct 2022 10:56:10 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Nam Cao <namcaov@gmail.com>
Cc:     UMWARI JOVIAL <umwarijovial@gmail.com>, gregkh@linuxfoundation.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        outreachy@lists.linux.dev
Subject: Re: [PATCH] Fixed[ERROR:trailing whitespace and braces around scalar
 initializer]
Message-ID: <Y1o5mktrnE5rbtCO@kadam>
References: <20221026132838.GA44037@rdm>
 <20221026171430.GA5592@nam-dell>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221026171430.GA5592@nam-dell>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8DQ3D2vyfssrUrU2rS7ke6Ihvc8mOVnMkJNmV0MxcjLB7LPDPaMAZBrT8r2v?=
 =?us-ascii?Q?UqtgUegLO9k7Gze6ZRmGa6+QXjcXQ7JFjATsi2TT4jN+pIJu1QLAa9W/x+na?=
 =?us-ascii?Q?p9mW+65aLlh0Q5r+LgdotExS++7AX7iYK5xjqQzCzHeVZ6WezvqlsNbACAXW?=
 =?us-ascii?Q?aWLBnkTAHWa5W4yO50HcxoDrEyVTFBFR7hCS6PkPKeb83hFl8F3FnAi92id9?=
 =?us-ascii?Q?D7pImT8RLjOlEX/SHEqAw1iuLrRZudO24OKnybOSn0HOT5qkXCdtWsHwx8Cf?=
 =?us-ascii?Q?Ze74xdT+S4Z1EfPCH40S2xiQi3HAQQdzbp9Po83szoOfhsrRavEY8JBJ1/2Q?=
 =?us-ascii?Q?sSGGjdssBC9vM15dyiOh3tV2kcQSidODTFDy60yxI5JnR2Iiul+ruvEo4iQl?=
 =?us-ascii?Q?jdDMG82tsF4i07CApGSUb2jAuUDhcSrnFZXrUfmzHtRCf8o+kI7yBqR0Pb4o?=
 =?us-ascii?Q?6eR4g1rNWajCJ9uhJ+8Ur/yJEy30QBu3niOg3TVRp99RF57QSHgENOuR9fFE?=
 =?us-ascii?Q?JqHlEyrNMFQI0RAhwe0abecriaqp7oQKD+Q/We62apZyk031Q5AkNjLdkDNO?=
 =?us-ascii?Q?JmSZs9ZbCueZfvhDzkxRAfuc51bwWfXizWyhOeA0in3vHDw20MbaNrxrbd/6?=
 =?us-ascii?Q?VaC5vko7wNhQq+M4MYjy7JFG3skRjC73v28Nx+jxqvUDpbNsAoOuY8PfcfJe?=
 =?us-ascii?Q?fkw6tXu0YSnJpLzpvR/X3qpvvkRBdjsOHhGZVvZLrF0p/eWSCxENCai4DAgw?=
 =?us-ascii?Q?aVMWzIMp6TQmH4n34bsyQ8Je+cIMNgb5LF9FWKmJQslEINXoVzVtvzQXX0os?=
 =?us-ascii?Q?1kYMesgB3yGCqUioY+u7rpSfr4nHvvdH1eNagQAOEelIYSBRIM5HWvevoOdS?=
 =?us-ascii?Q?Wu5cFIqgltDXc7IvORgkIXpPAmjjo4868jXixfzPtard1GVZSpkBmSjny5Q3?=
 =?us-ascii?Q?hmJdWkU1oalofh/A0hQlEKvMXxfTCzkvo+kbOt5lgHmV63bQhTQfnOJbgRxW?=
 =?us-ascii?Q?omerGBVZW2z30TB+nukOFahKa6BnMnhPBfYkIqgj1vjrJvkyX6/hjglv8vTy?=
 =?us-ascii?Q?nSEW7JwQ0/8JZiRhvbTw3X87BCfbHuJ/NPL9SRm6whySypwxW1pJx7AQDw47?=
 =?us-ascii?Q?1d2d/bQnZJL52QkiswUa7YWcskW5iUjsr5kWFrL3H8qJ+rym7yOaRzo3Ck5c?=
 =?us-ascii?Q?LlX0bWrdNCUggJ4uJIzEIvmwXbz1cgbxDTv9wrzK89RQUM27bJ/GNckYzJD+?=
 =?us-ascii?Q?yvxldYpva5cUbbAf0px16Sg1spzzqNDWrQ/VqlANtVCymabi5koworI07Bua?=
 =?us-ascii?Q?1a2QocvZ2cpaO/rXsuNgV40/1ze5qu3nETcAH/FgPVT0pF7Iod7iE3kVHJcN?=
 =?us-ascii?Q?QX0Hj4niZ0SdV6Tc3W6RcnRYFQ6XbqCg+R5gSIen8RrcrwYvRcPD+Zu9ftyV?=
 =?us-ascii?Q?ncbzCkjt61rrmHDK+vBVmIvlbUiXuQl1oVMWd/zsBF8rXBBAOK/Lkdl3f01X?=
 =?us-ascii?Q?BuF+xFb22UA3wN0nd9LdrD1e4ySugQgs/QSyQ5NDCi1GGTTKApiB73ad8Y0N?=
 =?us-ascii?Q?x9RphD5vuj5N83oDIwcRjrUpBsll3W04K1+spD1M37xqnQWV40Jmh63YGxge?=
 =?us-ascii?Q?lw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a409e01-4c9e-4928-077c-08dab7f0bfcd
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1001MB2358.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 07:56:26.6296
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K9GADk89mT1so5/gE+rNWQprZ1RgsL/9gXImqRwyulEM1M0LjS5FftHA5d0mMcvRCYbGUEL4e6KJLvWwUUxy9bGcodAopoeKizCPsLFKwZU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4564
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-27_03,2022-10-26_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 malwarescore=0
 phishscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2210270044
X-Proofpoint-GUID: JzvFobdXena6jzMAC9GHPmLfiaoF_zPP
X-Proofpoint-ORIG-GUID: JzvFobdXena6jzMAC9GHPmLfiaoF_zPP
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 26, 2022 at 07:14:34PM +0200, Nam Cao wrote:
> On Wed, Oct 26, 2022 at 04:28:38PM +0300, UMWARI JOVIAL wrote:
> > Using the checkpatch.pl script, found the below errors and  fixed
> > ERROR: trailing whitespace
> > CHECK: Please don't use multiple blank lines
> > warning: braces around scalar initializer
> > 
> > Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com>
> > ---
> >  drivers/staging/most/dim2/dim2.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
> > index 7a5f80e637a0..28259ce05024 100644
> > --- a/drivers/staging/most/dim2/dim2.c
> > +++ b/drivers/staging/most/dim2/dim2.c
> > @@ -987,7 +987,6 @@ static int rcar_gen2_enable(struct platform_device *pdev)
> >  		writel(0x04, dev->io_base + 0x600);
> >  	}
> >  
> > -
> >  	/* BBCR = 0b11 */
> >  	writel(0x03, dev->io_base + 0x500);
> >  	writel(0x0002FF02, dev->io_base + 0x508);
> > @@ -1084,7 +1083,6 @@ static const struct of_device_id dim2_of_match[] = {
> >  	{
> >  		.compatible = "xlnx,axi4-os62420_6pin-1.00.a",
> >  	},
> > -	{},
> 
> I'm no expert, but this looks like a null terminator and probably
> should not be removed.

You're absolutely correct.  Also I tried to see why checkpatch.pl was
printing an error for this but it doesn't print an error for me.

regards,
dan carpenter