Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761605AbXHBXQR (ORCPT ); Thu, 2 Aug 2007 19:16:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755729AbXHBXQF (ORCPT ); Thu, 2 Aug 2007 19:16:05 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:46297 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751446AbXHBXQE (ORCPT ); Thu, 2 Aug 2007 19:16:04 -0400 Date: Thu, 2 Aug 2007 16:15:49 -0700 From: Andrew Morton To: Daniel Ritz Cc: Linus Torvalds , Yinghai Lu , Bjorn Helgaas , linux-kernel@vger.kernel.org Subject: Re: REGRESSION: serial_cs broken by 8250 changes Message-Id: <20070802161549.fe069c07.akpm@linux-foundation.org> In-Reply-To: <200708030106.33917.daniel.ritz-ml@swissonline.ch> References: <200708030106.33917.daniel.ritz-ml@swissonline.ch> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1034 Lines: 25 On Fri, 3 Aug 2007 01:06:32 +0200 Daniel Ritz wrote: > commit 18a8bd949d6adb311ea816125ff65050df1f3f6e breaks serial_cs badly > with an oops, completely killing PCMCIA. > > register_console() now calls console->early_setup(). which in case of > 8250.c (the only user anyway) is serial8250_console_early_setup() > which is __init, calling 8250_early.c:serial8250_find_port_for_earlycon() > which is __init as well. boom. > > the changelog mentions SERIAL_PORT_DFNS removal which happens to be > commit 7e92b4fc345f5b6f57585fbe5ffdb0f24d7c9b26. but this got reverted > by commit 57d4810ea0d9ca58a7bcc1336607f0cede0a2abf. so i'd suggest to > just revert the 8250 changes as well. > Sounds like you'd be the ideal person to propose a patch ;) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/