Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-1087-g968661d8e1-fm-20221021.001-g968661d8
Mime-Version: 1.0
Message-Id: <83c93b5e-c589-4ca9-8bc0-ad3571f7f54d@app.fastmail.com>
In-Reply-To: <CA+G9fYvvtyO8fsYQb25L+bLXUnHJ5LoFToD+cYbKCcE6JUk5FQ@mail.gmail.com>
References: <CA+G9fYvvtyO8fsYQb25L+bLXUnHJ5LoFToD+cYbKCcE6JUk5FQ@mail.gmail.com>
Date:   Thu, 27 Oct 2022 11:09:10 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Naresh Kamboju" <naresh.kamboju@linaro.org>,
        patches@opensource.cirrus.com,
        "Linux ARM" <linux-arm-kernel@lists.infradead.org>,
        "Linux Samsung SOC" <linux-samsung-soc@vger.kernel.org>,
        "open list" <linux-kernel@vger.kernel.org>, llvm@lists.linux.dev
Cc:     "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
        "Russell King" <linux@armlinux.org.uk>,
        "Alim Akhtar" <alim.akhtar@samsung.com>,
        "Nathan Chancellor" <nathan@kernel.org>,
        "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Subject: Re: s3c6400_defconfig: arch/arm/mach-s3c/mach-crag6410.c:183:12: error: use of
 undeclared identifier 'KEY_VOLUMEUP'
Content-Type: text/plain
Precedence: bulk

On Thu, Oct 27, 2022, at 09:29, Naresh Kamboju wrote:
> Following build warnings / errors noticed while building arm s3c6400_defconfig
> with clang tool chain.

Do you mean this is a clang specific issue? 

> arch/arm/mach-s3c/mach-crag6410.c:183:12: error: use of undeclared
> identifier 'KEY_VOLUMEUP'
>         KEY(0, 0, KEY_VOLUMEUP),
>                   ^

I can see that KEY_VOLUMEUP is defined in <linux/input-event-codes.h>,
which is included by a couple of files in the kernel, but not
from this specific board file, so I don't see how it works with gcc.

Isn't this just a regression from commit 1810e248b2dc ("Input:
matrix_keypad - replace header inclusions by forward declarations")?

If that is the problem, I would expect to see the same thing in
all of these files, regardless of the compiler:

$ git grep -wl '\(linux/input/matrix_keypad.h\|linux/mfd/twl.h\|linux/platform_data/keyboard-spear.h\|linux/platform_data/keypad-nomadik-ske.h\|linux/platform_data/keypad-omap.h\|linux/platform_data/keypad-pxa27x.h\|linux/input/samsung-keypad.h\|\"keypad.h\"\)'  | xargs grep -l \\\<KEY_ | xargs grep -L '\(linux/input-events-code.h\|linux/input.h\)' | grep '\.c$'

arch/arm/mach-pxa/corgi.c
arch/arm/mach-pxa/littleton.c
arch/arm/mach-pxa/spitz.c
arch/arm/mach-pxa/tavorevb.c
arch/arm/mach-pxa/z2.c
arch/arm/mach-pxa/zylonite.c
arch/arm/mach-s3c/mach-crag6410.c

   Arnd