Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761233AbXHCATR (ORCPT ); Thu, 2 Aug 2007 20:19:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759246AbXHCATB (ORCPT ); Thu, 2 Aug 2007 20:19:01 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:42736 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756876AbXHCAS7 (ORCPT ); Thu, 2 Aug 2007 20:18:59 -0400 Date: Fri, 3 Aug 2007 09:19:39 +0900 From: KAMEZAWA Hiroyuki To: Christoph Lameter Cc: Yasunori Goto , Adrian Bunk , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [2.6 patch] mm/migrate.c: cleanups Message-Id: <20070803091939.233f296f.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: References: <20070729150320.GF16817@stusta.de> <20070802191502.B7A6.Y-GOTO@jp.fujitsu.com> Organization: Fujitsu X-Mailer: Sylpheed 2.4.2 (GTK+ 2.10.11; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 849 Lines: 27 On Thu, 2 Aug 2007 11:43:21 -0700 (PDT) Christoph Lameter wrote: > On Thu, 2 Aug 2007, Yasunori Goto wrote: > > > But, this patch is the cause of compile error of memory unplug code of > > 2.6.23-rc1-mm2. It uses putback_lru_pages(). > > Don't make it static please... :-( > > Right. But Adrian insisted since it was currently not used upstream. > > So I guess you will have to revert this piece in your unplug code. > Okay, I'll take are. But I'm too busy in these days. Andrew, If you have to drop unplug patch set, please do. I'll rework all when I find time. Thanks, -Kame - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/